TheArchive/session-android
1
0
Fork 0
mirror of https://github.com/oxen-io/session-android.git synced 2024-12-23 08:27:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use a set for the from/to serialized lists (#1370)

Browse Source
This commit is contained in:
0x330a 2024-03-27 15:20:50 +11:00 committed by GitHub
parent 0febb0456e
commit 901e800012
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libsession/src/main/java/org/session/libsession/utilities/Address.kt
View File

@ -8,7 +8,6 @@ import androidx.annotation.VisibleForTesting
import org.session.libsignal.utilities.IdPrefix import org.session.libsignal.utilities.IdPrefix
import org.session.libsignal.utilities.Util import org.session.libsignal.utilities.Util
import org.session.libsignal.utilities.guava.Optional import org.session.libsignal.utilities.guava.Optional
import java.util.Collections
import java.util.LinkedList import java.util.LinkedList
import java.util.concurrent.atomic.AtomicReference import java.util.concurrent.atomic.AtomicReference
import java.util.regex.Matcher import java.util.regex.Matcher
@ -168,8 +167,9 @@ class Address private constructor(address: String) : Parcelable, Comparable<Addr
@JvmStatic @JvmStatic
fun fromSerializedList(serialized: String, delimiter: Char): List<Address> { fun fromSerializedList(serialized: String, delimiter: Char): List<Address> {
val escapedAddresses = DelimiterUtil.split(serialized, delimiter) val escapedAddresses = DelimiterUtil.split(serialized, delimiter)
val set = escapedAddresses.toSet().sorted()
val addresses: MutableList<Address> = LinkedList() val addresses: MutableList<Address> = LinkedList()
for (escapedAddress in escapedAddresses) { for (escapedAddress in set) {
addresses.add(fromSerialized(DelimiterUtil.unescape(escapedAddress, delimiter))) addresses.add(fromSerialized(DelimiterUtil.unescape(escapedAddress, delimiter)))
} }
return addresses return addresses
@ -177,9 +177,9 @@ class Address private constructor(address: String) : Parcelable, Comparable<Addr
@JvmStatic @JvmStatic
fun toSerializedList(addresses: List<Address>, delimiter: Char): String { fun toSerializedList(addresses: List<Address>, delimiter: Char): String {
Collections.sort(addresses) val set = addresses.toSet().sorted()
val escapedAddresses: MutableList<String> = LinkedList() val escapedAddresses: MutableList<String> = LinkedList()
for (address in addresses) { for (address in set) {
escapedAddresses.add(DelimiterUtil.escape(address.serialize(), delimiter)) escapedAddresses.add(DelimiterUtil.escape(address.serialize(), delimiter))
} }
return Util.join(escapedAddresses, delimiter.toString() + "") return Util.join(escapedAddresses, delimiter.toString() + "")