TheArchive/session-android
1
0
Fork 0
mirror of https://github.com/oxen-io/session-android.git synced 2025-06-08 05:58:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not set or read quote author phone number.

Browse Source
This commit is contained in:
Alan Evans 2020-11-03 11:00:07 -04:00
parent ecee797d00
commit 936e772ba0
3 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libsignal/service/src/main/java/org/whispersystems/signalservice/api/SignalServiceMessageSender.java
View File

@ -584,11 +584,6 @@ public class SignalServiceMessageSender {
quoteBuilder.setAuthorUuid(message.getQuote().get().getAuthor().getUuid().get().toString()); quoteBuilder.setAuthorUuid(message.getQuote().get().getAuthor().getUuid().get().toString());
} }
// TODO [Alan] PhoneNumberPrivacy: Do not set this number
if (message.getQuote().get().getAuthor().getNumber().isPresent()) {
quoteBuilder.setAuthorE164(message.getQuote().get().getAuthor().getNumber().get());
}
if (!message.getQuote().get().getMentions().isEmpty()) { if (!message.getQuote().get().getMentions().isEmpty()) {
for (SignalServiceDataMessage.Mention mention : message.getQuote().get().getMentions()) { for (SignalServiceDataMessage.Mention mention : message.getQuote().get().getMentions()) {
quoteBuilder.addBodyRanges(DataMessage.BodyRange.newBuilder() quoteBuilder.addBodyRanges(DataMessage.BodyRange.newBuilder()

6
libsignal/service/src/main/java/org/whispersystems/signalservice/api/messages/SignalServiceContent.java
View File

@ -660,8 +660,8 @@ public final class SignalServiceContent {
attachment.hasThumbnail() ? createAttachmentPointer(attachment.getThumbnail()) : null)); attachment.hasThumbnail() ? createAttachmentPointer(attachment.getThumbnail()) : null));
} }
if (SignalServiceAddress.isValidAddress(content.getQuote().getAuthorUuid(), content.getQuote().getAuthorE164())) { if (SignalServiceAddress.isValidAddress(content.getQuote().getAuthorUuid(), null)) {
SignalServiceAddress address = new SignalServiceAddress(UuidUtil.parseOrNull(content.getQuote().getAuthorUuid()), content.getQuote().getAuthorE164()); SignalServiceAddress address = new SignalServiceAddress(UuidUtil.parseOrNull(content.getQuote().getAuthorUuid()), null);
return new SignalServiceDataMessage.Quote(content.getQuote().getId(), return new SignalServiceDataMessage.Quote(content.getQuote().getId(),
address, address,
@ -669,7 +669,7 @@ public final class SignalServiceContent {
attachments, attachments,
createMentions(content.getQuote().getBodyRangesList(), content.getQuote().getText(), isGroupV2)); createMentions(content.getQuote().getBodyRangesList(), content.getQuote().getText(), isGroupV2));
} else { } else {
Log.w(TAG, "Quote was missing an author! Returning null."); Log.w(TAG, "Quote was missing author's UUID! Returning null.");
return null; return null;
} }
} }

2
libsignal/service/src/main/proto/SignalService.proto
View File

@ -128,7 +128,7 @@ message DataMessage {
} }
optional uint64 id = 1; optional uint64 id = 1;
optional string authorE164 = 2; // optional string authorE164 = 2;
optional string authorUuid = 5; optional string authorUuid = 5;
optional string text = 3; optional string text = 3;
repeated QuotedAttachment attachments = 4; repeated QuotedAttachment attachments = 4;