TheArchive/session-android
1
0
Fork 0
mirror of https://github.com/oxen-io/session-android.git synced 2024-11-23 18:15:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

disconnect radio regardless of MMS exception

Browse Source 
Fixes #2498
Closes #2544
// FREEBIE
This commit is contained in:
Jake McGinty 2015-02-27 14:13:45 -08:00 committed by Moxie Marlinspike
parent ac312ff5d5
commit 96896bf8f1
2 changed files with 34 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/org/thoughtcrime/securesms/jobs/MmsDownloadJob.java
View File

@ -110,30 +110,31 @@ public class MmsDownloadJob extends MasterSecretJob {
Log.w(TAG, "Changing radio to MMS mode.."); Log.w(TAG, "Changing radio to MMS mode..");
radio.connect(); radio.connect();
Log.w(TAG, "Downloading in MMS mode with proxy...");
try { try {
retrieveAndStore(masterSecret, radio, messageId, threadId, contentLocation, Log.w(TAG, "Downloading in MMS mode with proxy...");
transactionId, true, true);
radio.disconnect();
return;
} catch (IOException e) {
Log.w(TAG, e);
}
Log.w(TAG, "Downloading in MMS mode without proxy..."); try {
retrieveAndStore(masterSecret, radio, messageId, threadId, contentLocation,
transactionId, true, true);
return;
} catch (IOException e) {
Log.w(TAG, e);
}
try { Log.w(TAG, "Downloading in MMS mode without proxy...");
retrieveAndStore(masterSecret, radio, messageId, threadId,
contentLocation, transactionId, true, false); try {
retrieveAndStore(masterSecret, radio, messageId, threadId,
contentLocation, transactionId, true, false);
} catch (IOException e) {
Log.w(TAG, e);
handleDownloadError(masterSecret, messageId, threadId,
MmsDatabase.Status.DOWNLOAD_SOFT_FAILURE,
context.getString(R.string.MmsDownloader_error_connecting_to_mms_provider),
automatic);
}
} finally {
radio.disconnect(); radio.disconnect();
} catch (IOException e) {
Log.w(TAG, e);
radio.disconnect();
handleDownloadError(masterSecret, messageId, threadId,
MmsDatabase.Status.DOWNLOAD_SOFT_FAILURE,
context.getString(R.string.MmsDownloader_error_connecting_to_mms_provider),
automatic);
} }
} catch (ApnUnavailableException e) { } catch (ApnUnavailableException e) {

27
src/org/thoughtcrime/securesms/jobs/MmsSendJob.java
View File

@ -118,23 +118,22 @@ public class MmsSendJob extends SendJob {
radio.connect(); radio.connect();
try { try {
MmsSendResult result = sendMms(masterSecret, radio, message, true, true); try {
radio.disconnect(); return sendMms(masterSecret, radio, message, true, true);
return result; } catch (IOException e) {
} catch (IOException e) { Log.w(TAG, e);
Log.w(TAG, e); }
}
Log.w(TAG, "Sending MMS with radio change and without proxy..."); Log.w(TAG, "Sending MMS with radio change and without proxy...");
try { try {
MmsSendResult result = sendMms(masterSecret, radio, message, true, false); return sendMms(masterSecret, radio, message, true, false);
} catch (IOException ioe) {
Log.w(TAG, ioe);
throw new UndeliverableMessageException(ioe);
}
} finally {
radio.disconnect(); radio.disconnect();
return result;
} catch (IOException ioe) {
Log.w(TAG, ioe);
radio.disconnect();
throw new UndeliverableMessageException(ioe);
} }
} catch (MmsRadioException mre) { } catch (MmsRadioException mre) {