diff --git a/app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java b/app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java index 4ac25cc0c1..26e3667542 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java +++ b/app/src/main/java/org/thoughtcrime/securesms/notifications/DefaultMessageNotifier.java @@ -521,9 +521,9 @@ public class DefaultMessageNotifier implements MessageNotifier { // If we received some manner of notification but Session is locked.. } else if (KeyCachingService.isLocked(context)) { - // Note: We provide 0 because `messageNewYouveGot` is now a plurals string and we don't have a count yet, so just - // giving it zero will result in "You got a new message". - body = SpanUtil.italic(context.getResources().getQuantityString(R.plurals.messageNewYouveGot, 0, 0)); + // Note: We provide 1 because `messageNewYouveGot` is now a plurals string and we don't have a count yet, so just + // giving it 1 will result in "You got a new message". + body = SpanUtil.italic(context.getResources().getQuantityString(R.plurals.messageNewYouveGot, 1, 1)); // ----- All further cases assume we know the contact and that Session isn't locked ----- diff --git a/app/src/main/java/org/thoughtcrime/securesms/notifications/PushReceiver.kt b/app/src/main/java/org/thoughtcrime/securesms/notifications/PushReceiver.kt index 25d18143af..0274deee82 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/notifications/PushReceiver.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/notifications/PushReceiver.kt @@ -56,8 +56,8 @@ class PushReceiver @Inject constructor(@ApplicationContext val context: Context) .setColor(context.getColor(R.color.textsecure_primary)) .setContentTitle(getString(context, R.string.sessionMessenger)) - // Note: We set the count to zero in the below plurals string so it says "You've got a new message" (singular) - .setContentText(context.resources.getQuantityString(R.plurals.messageNewYouveGot, 0, 0)) + // Note: We set the count to 1 in the below plurals string so it says "You've got a new message" (singular) + .setContentText(context.resources.getQuantityString(R.plurals.messageNewYouveGot, 1, 1)) .setPriority(NotificationCompat.PRIORITY_DEFAULT) .setAutoCancel(true) diff --git a/content-descriptions/src/main/res/values/strings.xml b/content-descriptions/src/main/res/values/strings.xml index ab47da53cb..afd3ff8720 100644 --- a/content-descriptions/src/main/res/values/strings.xml +++ b/content-descriptions/src/main/res/values/strings.xml @@ -184,8 +184,10 @@ Close Dialog Image or video Toggle attachment drawer - Original version of disappearing messages. Expand - Media message + + + Original version of disappearing messages. + \ No newline at end of file diff --git a/libsession/src/main/res/values/strings.xml b/libsession/src/main/res/values/strings.xml index c348eed20a..07f727784e 100644 --- a/libsession/src/main/res/values/strings.xml +++ b/libsession/src/main/res/values/strings.xml @@ -6,31 +6,26 @@ %1$d member %1$d members - %1$d active member %1$d active members - %1$d of %2$d match %1$d of %2$d matches - You\'ve got a new message. You\'ve got %1$d new messages. - And %1$d other has reacted %2$s to this message. And %1$d others have reacted %2$s to this message. - Failed to delete message @@ -49,8 +44,10 @@ - @@ -61,7 +58,8 @@ may still need to cater to _seeing_ Legacy disappearing messages from clients which haven't been updated, perhaps? Figma: https://www.figma.com/design/tEgZ8ujg76DdtPwEJv8zFp/Disappearing-Messages?t=25H0THKH9VADKm9s-0 - Morgan 2024/07/31: "once the Onboarding release has gone out we can remove the "Legacy" disappearing message settings (there is a PR for iOS to do so already)" + Morgan 2024/07/31: "once the Onboarding release has gone out we can remove the 'Legacy' + disappearing message settings (there is a PR for iOS to do so already)" --> Legacy