From b5eaed3cbb6b5643ef265f2d8de8fb30e3715d97 Mon Sep 17 00:00:00 2001
From: 0x330a <92654767+0x330a@users.noreply.github.com>
Date: Thu, 15 Jun 2023 17:44:16 +1000
Subject: [PATCH] fix: reduce attempts for downloading image, invert
 unreachable type check

---
 .../java/org/session/libsession/snode/OnionRequestAPI.kt    | 2 +-
 .../org/session/libsession/utilities/DownloadUtilities.kt   | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/libsession/src/main/java/org/session/libsession/snode/OnionRequestAPI.kt b/libsession/src/main/java/org/session/libsession/snode/OnionRequestAPI.kt
index 087c8e29d3..f3b2c5f93f 100644
--- a/libsession/src/main/java/org/session/libsession/snode/OnionRequestAPI.kt
+++ b/libsession/src/main/java/org/session/libsession/snode/OnionRequestAPI.kt
@@ -446,8 +446,8 @@ object OnionRequestAPI {
         val payloadData = JsonUtil.toJson(payload).toByteArray()
         return sendOnionRequest(Destination.Snode(snode), payloadData, version).recover { exception ->
             val error = when (exception) {
-                is HTTP.HTTPRequestFailedException -> SnodeAPI.handleSnodeError(exception.statusCode, exception.json, snode, publicKey)
                 is HTTPRequestFailedAtDestinationException -> SnodeAPI.handleSnodeError(exception.statusCode, exception.json, snode, publicKey)
+                is HTTP.HTTPRequestFailedException -> SnodeAPI.handleSnodeError(exception.statusCode, exception.json, snode, publicKey)
                 else -> null
             }
             if (error != null) { throw error }
diff --git a/libsession/src/main/java/org/session/libsession/utilities/DownloadUtilities.kt b/libsession/src/main/java/org/session/libsession/utilities/DownloadUtilities.kt
index b850baa253..27b6b244ba 100644
--- a/libsession/src/main/java/org/session/libsession/utilities/DownloadUtilities.kt
+++ b/libsession/src/main/java/org/session/libsession/utilities/DownloadUtilities.kt
@@ -4,7 +4,9 @@ import okhttp3.HttpUrl
 import org.session.libsession.messaging.file_server.FileServerApi
 import org.session.libsignal.utilities.HTTP
 import org.session.libsignal.utilities.Log
-import java.io.*
+import java.io.File
+import java.io.FileOutputStream
+import java.io.OutputStream
 
 object DownloadUtilities {
 
@@ -14,7 +16,7 @@ object DownloadUtilities {
     @JvmStatic
     fun downloadFile(destination: File, url: String) {
         val outputStream = FileOutputStream(destination) // Throws
-        var remainingAttempts = 4
+        var remainingAttempts = 2
         var exception: Exception? = null
         while (remainingAttempts > 0) {
             remainingAttempts -= 1