From bb0ec65744d59dd42d9c511b1631daed3a5abe1d Mon Sep 17 00:00:00 2001 From: Moxie Marlinspike Date: Wed, 19 Sep 2012 19:56:04 -0700 Subject: [PATCH] Include source origin in string key name. This should help eliminate string duplicates, as well as provide visibility into where strings in a resource file are being used. --- AndroidManifest.xml | 24 +- res/layout/auto_initiate_activity.xml | 6 +- res/layout/change_passphrase_activity.xml | 8 +- .../contact_selection_group_activity.xml | 2 +- .../contact_selection_list_activity.xml | 2 +- .../contact_selection_recent_activity.xml | 2 +- res/layout/conversation_activity.xml | 6 +- res/layout/conversation_fragment_cab.xml | 2 +- res/layout/create_passphrase_activity.xml | 8 +- res/layout/key_caching_notification.xml | 4 +- res/layout/prompt_passphrase_activity.xml | 2 +- res/layout/receive_key_activity.xml | 6 +- res/layout/recipients_panel.xml | 2 +- res/layout/review_identities.xml | 2 +- res/layout/save_identity_activity.xml | 4 +- res/layout/verify_identity_activity.xml | 4 +- .../verify_imported_identity_activity.xml | 10 +- res/layout/verify_keys_activity.xml | 4 +- res/layout/view_identity_activity.xml | 4 +- res/menu/contact_selection.xml | 2 +- res/menu/contact_selection_list.xml | 4 +- res/menu/conversation.xml | 4 +- res/menu/conversation_button_context.xml | 2 +- res/menu/conversation_callable.xml | 2 +- res/menu/conversation_context.xml | 8 +- res/menu/conversation_insecure.xml | 2 +- res/menu/conversation_list.xml | 2 +- res/menu/conversation_list_batch.xml | 4 +- res/menu/conversation_secure_unverified.xml | 8 +- res/menu/conversation_secure_verified.xml | 8 +- res/menu/key_scanning.xml | 6 +- res/menu/text_secure_locked.xml | 2 +- res/menu/text_secure_normal.xml | 12 +- res/menu/verify_keys.xml | 2 +- res/values/strings.xml | 514 +++++++++--------- res/xml/preferences.xml | 74 +-- .../securesms/ApplicationExportManager.java | 28 +- .../ApplicationMigrationManager.java | 14 +- .../ApplicationPreferencesActivity.java | 16 +- .../securesms/ConversationActivity.java | 33 +- .../securesms/ConversationFragment.java | 5 +- .../securesms/ConversationItem.java | 36 +- .../securesms/ConversationListAdapter.java | 4 +- .../securesms/ConversationListFragment.java | 8 +- .../securesms/ConversationListItem.java | 3 +- .../securesms/KeyScanningActivity.java | 3 +- .../securesms/PassphraseChangeActivity.java | 5 +- .../securesms/PassphraseCreateActivity.java | 7 +- .../securesms/PassphrasePromptActivity.java | 2 +- .../securesms/ReceiveKeyActivity.java | 22 +- .../securesms/ReviewIdentitiesActivity.java | 6 +- .../securesms/SaveIdentityActivity.java | 11 +- .../securesms/VerifyIdentityActivity.java | 30 +- .../VerifyImportedIdentityActivity.java | 22 +- .../securesms/VerifyKeysActivity.java | 21 +- .../securesms/ViewIdentityActivity.java | 14 +- .../crypto/KeyExchangeInitiator.java | 32 +- .../crypto/MessageDisplayHelper.java | 8 +- .../securesms/database/MmsDatabase.java | 10 +- .../securesms/database/MmsMessageRecord.java | 6 +- .../service/ApplicationMigrationService.java | 6 +- .../securesms/service/KeyCachingService.java | 8 +- .../securesms/service/MessageNotifier.java | 8 +- 63 files changed, 579 insertions(+), 547 deletions(-) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 979dcadb32..aca8e239cd 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -58,58 +58,58 @@ diff --git a/res/layout/auto_initiate_activity.xml b/res/layout/auto_initiate_activity.xml index 437021cc56..1925c3a769 100644 --- a/res/layout/auto_initiate_activity.xml +++ b/res/layout/auto_initiate_activity.xml @@ -12,7 +12,7 @@ android:layout_marginTop="5dip" android:layout_marginBottom="5dip" android:textAppearance="?android:attr/textAppearanceMedium" - android:text="@string/you_have_received_a_message_from_someone_who_supports_textsecure_encrypted_sessions_would_you_like_to_initiate_a_secure_session"/> + android:text="@string/auto_initiate_activity__you_have_received_a_message_from_someone_who_supports_textsecure_encrypted_sessions_would_you_like_to_initiate_a_secure_session"/>