From 43c6e86da0dc00f52cde966493782f2d85977139 Mon Sep 17 00:00:00 2001 From: ThomasSession Date: Tue, 20 Aug 2024 11:56:15 +1000 Subject: [PATCH 1/3] Bumped version code --- app/build.gradle | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index bfb2c0cdd0..eb31dce293 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -13,8 +13,8 @@ configurations.forEach { it.exclude module: "commons-logging" } -def canonicalVersionCode = 379 -def canonicalVersionName = "1.19.1" +def canonicalVersionCode = 380 +def canonicalVersionName = "1.19.2" def postFixSize = 10 def abiPostFix = ['armeabi-v7a' : 1, From afbb71351a74220c312a09c25cc1c79738453c12 Mon Sep 17 00:00:00 2001 From: AL-Session <160798022+AL-Session@users.noreply.github.com> Date: Fri, 23 Aug 2024 14:37:07 +1000 Subject: [PATCH 2/3] Applied save-crash workaround (#1640) --- .../org/thoughtcrime/securesms/util/SaveAttachmentTask.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/SaveAttachmentTask.kt b/app/src/main/java/org/thoughtcrime/securesms/util/SaveAttachmentTask.kt index 17ef3bd7f8..ccbab486c6 100644 --- a/app/src/main/java/org/thoughtcrime/securesms/util/SaveAttachmentTask.kt +++ b/app/src/main/java/org/thoughtcrime/securesms/util/SaveAttachmentTask.kt @@ -61,7 +61,12 @@ class SaveAttachmentTask @JvmOverloads constructor(context: Context, count: Int fun saveAttachment(context: Context, attachment: Attachment): String? { val contentType = checkNotNull(MediaUtil.getCorrectedMimeType(attachment.contentType)) var fileName = attachment.fileName - if (fileName == null) fileName = generateOutputFileName(contentType, attachment.date) + + // Added for SES-2624 to prevent Android API 28 devices and lower from crashing because + // for unknown reasons it provides us with an empty filename when saving files. + // TODO: Further investigation into root cause and fix! + if (fileName.isNullOrEmpty()) fileName = generateOutputFileName(contentType, attachment.date) + fileName = sanitizeOutputFileName(fileName) val outputUri: Uri = getMediaStoreContentUriForType(contentType) val mediaUri = createOutputUri(context, outputUri, contentType, fileName) From a50e3049384a5fe6f000e1f4d1a62ca669d6734b Mon Sep 17 00:00:00 2001 From: ThomasSession Date: Mon, 26 Aug 2024 08:07:47 +1000 Subject: [PATCH 3/3] Removing resources --- app/src/main/res/values-small/dimens.xml | 1 - app/src/main/res/values-sw360dp/dimens.xml | 4 ---- app/src/main/res/values-sw400dp/dimens.xml | 4 ---- app/src/main/res/values-sw480dp/dimens.xml | 3 +-- 4 files changed, 1 insertion(+), 11 deletions(-) diff --git a/app/src/main/res/values-small/dimens.xml b/app/src/main/res/values-small/dimens.xml index 63b56ddac7..b1da3441b0 100644 --- a/app/src/main/res/values-small/dimens.xml +++ b/app/src/main/res/values-small/dimens.xml @@ -9,7 +9,6 @@ 15sp 20sp 24sp - 50sp diff --git a/app/src/main/res/values-sw360dp/dimens.xml b/app/src/main/res/values-sw360dp/dimens.xml index 65d2c52883..485456ec3e 100644 --- a/app/src/main/res/values-sw360dp/dimens.xml +++ b/app/src/main/res/values-sw360dp/dimens.xml @@ -6,10 +6,6 @@ 168dp 167dp 83dp - 252dp - 125dp - 210dp - 125dp 83dp 240dp \ No newline at end of file diff --git a/app/src/main/res/values-sw400dp/dimens.xml b/app/src/main/res/values-sw400dp/dimens.xml index ca8387562c..9376913d52 100644 --- a/app/src/main/res/values-sw400dp/dimens.xml +++ b/app/src/main/res/values-sw400dp/dimens.xml @@ -14,10 +14,6 @@ 200dp 199dp 99dp - 300dp - 149dp - 250dp - 149dp 99dp 300dp \ No newline at end of file diff --git a/app/src/main/res/values-sw480dp/dimens.xml b/app/src/main/res/values-sw480dp/dimens.xml index 80c9e9b466..0d2c4cc409 100644 --- a/app/src/main/res/values-sw480dp/dimens.xml +++ b/app/src/main/res/values-sw480dp/dimens.xml @@ -1,5 +1,4 @@ - 350dp - 300dp + \ No newline at end of file