Only store remote values for flags in a whitelist.

This commit is contained in:
Greyson Parrelli 2020-02-05 21:53:04 -05:00
parent d9c5907ea9
commit c041614d1f
2 changed files with 4 additions and 2 deletions

View File

@ -633,7 +633,8 @@ public class SubmitLogFragment extends Fragment {
Map<String, Boolean> disk = FeatureFlags.getDiskValues(); Map<String, Boolean> disk = FeatureFlags.getDiskValues();
Map<String, Boolean> forced = FeatureFlags.getForcedValues(); Map<String, Boolean> forced = FeatureFlags.getForcedValues();
int remoteLength = Stream.of(memory.keySet()).map(String::length).max(Integer::compareTo).orElse(0); int remoteLength = Stream.of(memory.keySet()).map(String::length).max(Integer::compareTo).orElse(0);
int forcedLength = Stream.of(disk.keySet()).map(String::length).max(Integer::compareTo).orElse(0); int diskLength = Stream.of(disk.keySet()).map(String::length).max(Integer::compareTo).orElse(0);
int forcedLength = Stream.of(forced.keySet()).map(String::length).max(Integer::compareTo).orElse(0);
out.append("-- Memory\n"); out.append("-- Memory\n");
for (Map.Entry<String, Boolean> entry : memory.entrySet()) { for (Map.Entry<String, Boolean> entry : memory.entrySet()) {
@ -643,7 +644,7 @@ public class SubmitLogFragment extends Fragment {
out.append("-- Disk\n"); out.append("-- Disk\n");
for (Map.Entry<String, Boolean> entry : disk.entrySet()) { for (Map.Entry<String, Boolean> entry : disk.entrySet()) {
out.append(Util.rightPad(entry.getKey(), forcedLength)).append(": ").append(entry.getValue()).append("\n"); out.append(Util.rightPad(entry.getKey(), diskLength)).append(": ").append(entry.getValue()).append("\n");
} }
out.append("\n"); out.append("\n");

View File

@ -58,6 +58,7 @@ public final class FeatureFlags {
* We will only store remote values for flags in this set. If you want a flag to be controllable * We will only store remote values for flags in this set. If you want a flag to be controllable
* remotely, place it in here. * remotely, place it in here.
*/ */
private static final Set<String> REMOTE_CAPABLE = Sets.newHashSet( private static final Set<String> REMOTE_CAPABLE = Sets.newHashSet(
PINS_FOR_ALL, PINS_FOR_ALL,
PINS_MEGAPHONE_KILL_SWITCH PINS_MEGAPHONE_KILL_SWITCH