From 87e8214bae6064ff507f4670b2cacef935a9214b Mon Sep 17 00:00:00 2001 From: joeykrim Date: Mon, 8 Jul 2013 10:16:25 -0400 Subject: [PATCH 1/2] Small clarification in the comments on the types of SMS to ignore --- src/org/thoughtcrime/securesms/service/SmsListener.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/org/thoughtcrime/securesms/service/SmsListener.java b/src/org/thoughtcrime/securesms/service/SmsListener.java index c5fb38aee5..c6b3b09b4f 100644 --- a/src/org/thoughtcrime/securesms/service/SmsListener.java +++ b/src/org/thoughtcrime/securesms/service/SmsListener.java @@ -46,11 +46,11 @@ public class SmsListener extends BroadcastReceiver { return true; } - // Sprint Visual Voicemail return message.getOriginatingAddress().length() < 7 && - (messageBody.startsWith("//ANDROID:") || messageBody.startsWith("//Android:") || - messageBody.startsWith("//android:") || messageBody.startsWith("//BREW:")); + (messageBody.startsWith("//ANDROID:") || messageBody.startsWith("//Android:") || // Sprint Visual Voicemail + messageBody.startsWith("//android:") || + messageBody.startsWith("//BREW:")); //BREW stands for “Binary Runtime Environment for Wireless" } private SmsMessage getSmsMessageFromIntent(Intent intent) { From 8464bc775a3937547f37e1ce0b3f724089a34809 Mon Sep 17 00:00:00 2001 From: joeykrim Date: Sat, 13 Jul 2013 16:41:09 -0400 Subject: [PATCH 2/2] Removed extra comparisons by converting original phrase to uppercase, then comparing Removed previous multiple comparisons that were variations of capitalizing the same phrase by converting the original phrase to all uppercase and then comparing --- src/org/thoughtcrime/securesms/service/SmsListener.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/org/thoughtcrime/securesms/service/SmsListener.java b/src/org/thoughtcrime/securesms/service/SmsListener.java index c6b3b09b4f..e6836e95d3 100644 --- a/src/org/thoughtcrime/securesms/service/SmsListener.java +++ b/src/org/thoughtcrime/securesms/service/SmsListener.java @@ -48,8 +48,7 @@ public class SmsListener extends BroadcastReceiver { return message.getOriginatingAddress().length() < 7 && - (messageBody.startsWith("//ANDROID:") || messageBody.startsWith("//Android:") || // Sprint Visual Voicemail - messageBody.startsWith("//android:") || + (messageBody.toUpperCase().startsWith("//ANDROID:") || // Sprint Visual Voicemail messageBody.startsWith("//BREW:")); //BREW stands for “Binary Runtime Environment for Wireless" }