be safer when processing parts in AttachmentDownloadJob

Closes #4166
// FREEBIE
This commit is contained in:
Jake McGinty
2015-10-01 12:28:29 -07:00
committed by Moxie Marlinspike
parent c6abb7dc64
commit cdf982a356
5 changed files with 93 additions and 7 deletions

View File

@@ -0,0 +1,39 @@
package org.thoughtcrime.securesms.jobs;
import android.content.Context;
import org.junit.Before;
import org.junit.Test;
import org.thoughtcrime.securesms.BaseUnitTest;
import org.thoughtcrime.securesms.database.PartDatabase.PartId;
import org.thoughtcrime.securesms.jobs.AttachmentDownloadJob.InvalidPartException;
import org.thoughtcrime.securesms.util.Util;
import ws.com.google.android.mms.pdu.PduPart;
import static org.powermock.api.mockito.PowerMockito.mock;
public class AttachmentDownloadJobTest extends BaseUnitTest {
private AttachmentDownloadJob job;
@Before
@Override
public void setUp() throws Exception {
super.setUp();
job = new AttachmentDownloadJob(mock(Context.class), 1L, new PartId(1L, 1L));
}
@Test(expected = InvalidPartException.class)
public void testCreateAttachmentPointerInvalidId() throws Exception {
PduPart part = new PduPart();
part.setContentDisposition(Util.toIsoBytes("a long and acceptable valid key like we all want"));
job.createAttachmentPointer(masterSecret, part);
}
@Test(expected = InvalidPartException.class)
public void testCreateAttachmentPointerInvalidKey() throws Exception {
PduPart part = new PduPart();
part.setContentDisposition(Util.toIsoBytes("1"));
job.createAttachmentPointer(masterSecret, part);
}
}