reduce overdraw

Closes #3856
// FREEBIE

src/org/thoughtcrime/securesms/components/DividerItemDecoration.java

@@ -1,102 +0,0 @@
-/*
- * Copyright (C) 2014 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.thoughtcrime.securesms.components;
-
-import android.content.Context;
-import android.content.res.TypedArray;
-import android.graphics.Canvas;
-import android.graphics.Rect;
-import android.graphics.drawable.Drawable;
-import android.support.annotation.AttrRes;
-import android.support.v7.widget.LinearLayoutManager;
-import android.support.v7.widget.RecyclerView;
-import android.view.View;
-
-public class DividerItemDecoration extends RecyclerView.ItemDecoration {
-
-  private static final int DEFAULT_ATTR = android.R.attr.listDivider;
-
-  private Drawable mDivider;
-  private int      mOrientation;
-
-  public DividerItemDecoration(Context context, int orientation) {
-    this(context, orientation, DEFAULT_ATTR);
-  }
-
-  public DividerItemDecoration(Context context, int orientation, @AttrRes int attr) {
-    final TypedArray a = context.obtainStyledAttributes(new int[]{attr});
-    mDivider = a.getDrawable(0);
-    a.recycle();
-    setOrientation(orientation);
-  }
-
-  public void setOrientation(int orientation) {
-    if (orientation != LinearLayoutManager.HORIZONTAL && orientation != LinearLayoutManager.VERTICAL) {
-      throw new IllegalArgumentException("invalid orientation");
-    }
-    mOrientation = orientation;
-  }
-
-  @Override
-  public void onDraw(Canvas c, RecyclerView parent) {
-    if (mOrientation == LinearLayoutManager.VERTICAL) {
-      drawVertical(c, parent);
-    } else {
-      drawHorizontal(c, parent);
-    }
-  }
-
-  public void drawVertical(Canvas c, RecyclerView parent) {
-    final int left = parent.getPaddingLeft();
-    final int right = parent.getWidth() - parent.getPaddingRight();
-
-    final int childCount = parent.getChildCount();
-    for (int i = 0; i < childCount; i++) {
-      final View child = parent.getChildAt(i);
-      final RecyclerView.LayoutParams params = (RecyclerView.LayoutParams) child
-          .getLayoutParams();
-      final int top = child.getBottom() + params.bottomMargin;
-      final int bottom = top + mDivider.getIntrinsicHeight();
-      mDivider.setBounds(left, top, right, bottom);
-      mDivider.draw(c);
-    }
-  }
-
-  public void drawHorizontal(Canvas c, RecyclerView parent) {
-    final int top = parent.getPaddingTop();
-    final int bottom = parent.getHeight() - parent.getPaddingBottom();
-
-    final int childCount = parent.getChildCount();
-    for (int i = 0; i < childCount; i++) {
-      final View child = parent.getChildAt(i);
-      final RecyclerView.LayoutParams params = (RecyclerView.LayoutParams) child
-          .getLayoutParams();
-      final int left = child.getRight() + params.rightMargin;
-      final int right = left + mDivider.getIntrinsicHeight();
-      mDivider.setBounds(left, top, right, bottom);
-      mDivider.draw(c);
-    }
-  }
-
-  @Override
-  public void getItemOffsets(Rect outRect, int itemPosition, RecyclerView parent) {
-    if (mOrientation == LinearLayoutManager.VERTICAL) {
-      outRect.set(0, 0, 0, mDivider.getIntrinsicHeight());
-    } else {
-      outRect.set(0, 0, mDivider.getIntrinsicWidth(), 0);
-    }
-  }
-}

src/org/thoughtcrime/securesms/components/camera/CameraView.java

@@ -19,6 +19,7 @@ import android.annotation.TargetApi;
 import android.app.Activity;
 import android.content.Context;
 import android.content.pm.ActivityInfo;
+import android.graphics.Color;
 import android.hardware.Camera;
 import android.hardware.Camera.PreviewCallback;
 import android.os.Build;
@@ -68,6 +69,7 @@ public class CameraView extends FrameLayout {
 
   public CameraView(Context context, AttributeSet attrs, int defStyle) {
     super(context, attrs, defStyle);
+    setBackgroundColor(Color.BLACK);
 
     onOrientationChange = new OnOrientationChange(context.getApplicationContext());
   }

src/org/thoughtcrime/securesms/components/camera/QuickAttachmentDrawer.java

@@ -78,6 +78,8 @@ public class QuickAttachmentDrawer extends ViewGroup implements InputView {
     updateControlsView();
 
     coverViewPosition = getChildCount();
+    controls.setVisibility(GONE);
+    quickCamera.setVisibility(GONE);
   }
 
   public static boolean isDeviceSupported(Context context) {
@@ -271,8 +273,8 @@ public class QuickAttachmentDrawer extends ViewGroup implements InputView {
 
     if (slideOffset == 0 && quickCamera.isStarted()) {
       quickCamera.onPause();
-      controls.setVisibility(INVISIBLE);
-      quickCamera.setVisibility(INVISIBLE);
+      controls.setVisibility(GONE);
+      quickCamera.setVisibility(GONE);
     } else if (slideOffset != 0 && !quickCamera.isStarted() & !paused) {
       controls.setVisibility(VISIBLE);
       quickCamera.setVisibility(VISIBLE);