TheArchive/session-android
1
0
Fork 0
mirror of https://github.com/oxen-io/session-android.git synced 2025-01-11 19:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix LoaderManager inefficiencies

Browse Source 
Redundant calls in ConversationActivity and ConversationListActivity
was causing unnecessary view invalidations.

Closes #2592
This commit is contained in:
Rhodey Orbits 2015-03-05 16:06:11 -08:00 committed by Jake McGinty
parent ca2c8b961e
commit db7a657001
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/org/thoughtcrime/securesms/ConversationFragment.java
View File

@ -103,7 +103,6 @@ public class ConversationFragment extends ListFragment
initializeResources();
initializeListAdapter();
getLoaderManager().restartLoader(0, null, this);
}
private void initializeResources() {
@ -117,7 +116,7 @@ public class ConversationFragment extends ListFragment
(!this.recipients.isSingleRecipient()) || this.recipients.isGroupRecipient(),
DirectoryHelper.isPushDestination(getActivity(), this.recipients)));
getListView().setRecyclerListener((ConversationAdapter)getListAdapter());
getLoaderManager().initLoader(0, null, this);
getLoaderManager().restartLoader(0, null, this);
}
}
@ -127,12 +126,9 @@ public class ConversationFragment extends ListFragment
}
private void setCorrectMenuVisibility(Menu menu) {
ConversationAdapter adapter = (ConversationAdapter) getListAdapter();
List<MessageRecord> messageRecords = getSelectedMessageRecords();
if (actionMode != null && messageRecords.size() == 0) {
adapter.getBatchSelected().clear();
adapter.notifyDataSetChanged();
actionMode.finish();
return;
}
@ -170,9 +166,11 @@ public class ConversationFragment extends ListFragment
public void reload(Recipients recipients, long threadId) {
this.recipients = recipients;
this.threadId = threadId;
initializeListAdapter();
if (this.threadId != threadId) {
this.threadId = threadId;
initializeListAdapter();
}
}
public void scrollToBottom() {

2
src/org/thoughtcrime/securesms/ConversationListFragment.java
View File

@ -96,8 +96,6 @@ public class ConversationListFragment extends ListFragment
});
initializeListAdapter();
initializeBatchListener();
getLoaderManager().initLoader(0, null, this);
}
@Override