TheArchive/session-android
1
0
Fork 0
mirror of https://github.com/oxen-io/session-android.git synced 2024-12-27 18:27:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
4,445 Commits 46 Branches 892 Tags 484 MiB
Commit Graph

2823 Commits

Author SHA1 Message Date
Greyson Parrelli
d25ebdc818 Fix indentation in preference fragments. 
Unfortunately, while there does exist an XML property to disable the
indentation, it's bugged for category headings, so we have to do this
silly thing where we strip the padding in the adapter. Hopefully they'll
fix the bug and we can move to use the sanctioned property.

See: https://issuetracker.google.com/issues/111662669

Fixes #8233
 2018-10-02 12:08:01 -07:00
Greyson Parrelli
24e82abf80 Don't report contact discovery accuracy if it encountered an error. 
Otherwise we're double-reporting. Also made the sanitize method more
accurate.
 2018-10-02 09:16:37 -07:00
Greyson Parrelli
cfa13867e5 Allow null for profileAvatar in RetrieveProfileAvatarJob. 2018-10-02 08:43:18 -07:00
Greyson Parrelli
34770a2333 Fixed Camera capture crash on API <= 19. 
On older versions of Android, TextureView#getBitmap() needs to be called
on the main thread. On mid range phones, this is ~50ms. Normally that'd
be bad, but the UI isn't doing anything at that point anyway.

Fixes #8232
 2018-10-01 23:53:33 -07:00
Greyson Parrelli
2c5fa155ae Fix re-enabling tab switching in MediaOverview. 
We were being inconsistent in how we were handling exiting multiselect,
and it wasn't behaving properly when you left by clicking the 'x'. Now
it's all handled centrally.

Fixes #8234
 2018-10-01 23:38:07 -07:00
Greyson Parrelli
12afdad291 Log Job retryable exceptions. 2018-10-01 16:14:45 -07:00
Greyson Parrelli
2f530dc970 Remove CameraView usage of JobManager. 
WorkManager flat-out can't handle anonymous implementations of Worker
classes due to it using reflection to instantiate them.
 2018-10-01 12:12:50 -07:00
Greyson Parrelli
87e6aa48bb Schedule jobs with WorkManager. 
Should help solve most of our pressing targetSdk=26 migration issues.
 2018-10-01 12:12:50 -07:00
Greyson Parrelli
d10a44f8eb Suppress some noisy logs. 2018-10-01 12:12:50 -07:00
Greyson Parrelli
6359961a82 Ensure numbers are properly formatted before giving them to contact discovery service. 
We were sending "Unknown" addresses, which would cause the service to
choke.
 2018-10-01 12:12:12 -07:00
Greyson Parrelli
616912d85f Prefer local state in dial click listener. 2018-09-27 11:45:56 -07:00
Greyson Parrelli
bd38b96095 Long-press timestamps in message details to copy. 2018-09-27 11:34:43 -07:00
Greyson Parrelli
12d9d7741b Clean up batch saving. 
- Post a better string for when batch saving completes successfully
- Exit multi-select after saving
 2018-09-27 10:35:56 -07:00
FeuRenard
91a119393c Allow batch saving in media overview 2018-09-27 10:35:56 -07:00
FeuRenard
c82afd8944 Allow selecting all media in overview 2018-09-27 10:35:56 -07:00
Greyson Parrelli
84c71fce16 Disable tab switching in media overview during multiselect. 
Multiselect only applies to items in the "media" tab, so people
shouldn't be able to switch tabs during multiselect.
 2018-09-27 10:35:56 -07:00
Greyson Parrelli
a0ab252bc9 Add preliminary contact discovery service support. 2018-09-27 10:35:56 -07:00
Greyson Parrelli
08ace15f95 Implemented new camera capture flow. 
A new, fullscreen camera capture flow that easily allows you to capture
and edit a photo before sending it. Replaces the current half-screen
camera button.
 2018-09-27 10:35:56 -07:00
Greyson Parrelli
e9a38bab1e Turned SingleUseBlobProvider into MemoryBlobProvider. 
Keep the single-use behavior, but allow the creation of multi-use memory
blobs that can be deleted when we're done with them. Will help out with
having URI's for temporary images during the camera capture flow.
 2018-09-27 10:35:56 -07:00
Greyson Parrelli
e63773e5c8 Added OrderEnforcer class to schedule ordered tasks. 2018-09-27 10:35:56 -07:00
Greyson Parrelli
bcebf58b76 Added a new Stopwatch class to easily log timings. 2018-09-27 10:35:56 -07:00
Greyson Parrelli
6eb8693546 Don't block messages from unknown groups. 
We were incorrectly considering unknown groups to have been "left".
 2018-09-25 10:00:14 -07:00
Greyson Parrelli
11127c0d97 Clear external cache upon upgrade. 2018-09-19 16:41:51 -07:00
Greyson Parrelli
45c4eafbd7 Add the ability to block groups. 
This also fixes the situation where we block group-leave messages,
preventing blocked contacts from leaving groups.

Fixes #7970

Also, this forced us to upgrade libsignal-service, which fixes the
websocket timeout issues. Thanks to @dpapavas!

Fixes #6644
 2018-09-18 15:26:50 -07:00
Greyson Parrelli
741b775d3e Ensure external camera blob is deleted. 2018-09-17 20:29:21 -07:00
Greyson Parrelli
e09c99102e Clear Glide disk cache after image deletion. 2018-09-17 19:17:36 -07:00
Greyson Parrelli
1d4020ffc6 Disable forwarding for shared contacts. 
Forwarding of shared contacts currently just creates an empty draft.
You can't preview a shared contact before you send, which would make the
forwarding flow inconsistent across media types. So it's easier to just
hide it for now.

Fixes #8195
 2018-09-16 22:50:59 -07:00
Greyson Parrelli
5d11e321a8 Fix setting global notification sound to 'None'. 
Fixes #8206
 2018-09-16 22:29:55 -07:00
Greyson Parrelli
9dd3e50ebd Don't set subscriptionId for quick-reply push messages. 
This could cause us to think push messages were actually sent with
a SIM. We also now prevent rendering SIM info on push messages in
the conversation view.

Fixes #8176
 2018-09-08 10:08:22 -07:00
Greyson Parrelli
440ad70d79 Allow submitting a debug log during registration. 2018-09-08 07:48:20 -07:00
Greyson Parrelli
a1b2887bf3 Fixed off-by-one crash when navigating to message from FTS. 
Related to #8145
 2018-09-08 07:48:20 -07:00
Greyson Parrelli
db9bfb4b2f Update ExoPlayer to 2.8.4 2018-09-08 07:48:20 -07:00
Greyson Parrelli
c3bdc48ee3 Create placeholder ContentProviders for database observations. 
Required for the API 26 migration.

See https://developer.android.com/about/versions/oreo/android-8.0-changes#ccn
 2018-09-08 07:48:20 -07:00
Greyson Parrelli
7c5e1db6a2 Fix NPE in MultiDeviceContactUpdateJob. 
Fixes #8180
 2018-09-07 17:52:50 -07:00
Greyson Parrelli
82c0ea792a Fix animation crash. 
Shoutout to @bomba1990 for fixing this around the same time as me :)

Fixes #8182
 2018-09-07 17:52:50 -07:00
Greyson Parrelli
70eecb754e Address bugs in notification channel backup restore. 2018-09-07 17:49:15 -07:00
Greyson Parrelli
ad036b0d6a Fix backup restore issues from restoring newer Signal backups. 
Fixes #8184
 2018-09-07 16:08:45 -07:00
Greyson Parrelli
15b4517e35 Prevent restoring newer backups into older versions of Signal. 
Relates to #8184
 2018-09-07 15:54:38 -07:00
Greyson Parrelli
8d43fb850d Make group notifications use the latest sender's ringtone. 2018-09-04 18:10:47 -07:00
Greyson Parrelli
11d34512a0 Fix double notifications in O+. 2018-09-04 18:10:42 -07:00
Greyson Parrelli
73b18fc1dd Fix NotificationChannel backup import. 
We were recreating the channels before the database upgrade. We
have to do it after.

Fixes #8174
 2018-09-04 10:57:33 -07:00
Greyson Parrelli
d9ba6962c7 Fixed NPE during channel update. 2018-09-03 17:48:55 -07:00
Greyson Parrelli
3da1a3e270 Restore notification channels after backup. 2018-08-31 12:00:46 -07:00
Greyson Parrelli
e840dc6687 Move notification preferences back in-app for O+. 
Fixes #8147
 2018-08-31 11:10:54 -07:00
Greyson Parrelli
5d91a94252 Fix shortcut images being too large. 
We were hitting the transaction limit size. This change scales down
shortcut icons to be at most 300x300, which comes out to ~360kb, which
should be safely under the limit of 1mb.

Fixes #8139
 2018-08-25 10:40:58 -07:00
Greyson Parrelli
ab58eab9f4 Fix potential crash with recipient preferences. 2018-08-24 12:00:02 -07:00
Greyson Parrelli
cedab7f504 Fix migration of group names when creating Notification Channels. 2018-08-22 14:19:37 -07:00
Greyson Parrelli
ca2efcac8a Added safeguards during NotificationChannel creation. 
We were getting an IllegalArgumentException during channel creation on
some Samsung phones. Stack trace didn't give me much more than that, so
just adding in some additional safeguards that make sense based on
reading AOSP.
 2018-08-22 13:19:59 -07:00
Greyson Parrelli
f1efe2b589 Use correct in-thread message tone on O+. 
We manually play the ringtone when in-thread notifications are enabled,
but we weren't using the sound specified by the channel in the system
settings. This fixes that problem by reading the NotificationChannel
setting.
 2018-08-22 11:58:41 -07:00
Greyson Parrelli
e1f8e87327 Fix log submission OOM, improve log scrolling. 
We were getting a TransactionTooLargeException when giving an
EditText a very large (1.5MB+) text block. This has been resolved
by switching to a RecyclerView to show the text line-by-line. As a
side-effect, this improves scroll performance on lower-end devices.

Also, I added a button to jump to the bottom of the log because I
really wanted one :)

Fixes #8124
 2018-08-20 01:24:36 -07:00
Greyson Parrelli
88d94cad92 Substantially improve Scrubber performance. 
Previously, we were making a new copy of the entire source string after
every scrubbed substitution. In the case of our new, larger log files,
this was very slow. It's been changed so we only ever create one new
copy.

In practice, on a Moto E (2014), scrubbing a 1.5MB log went from
>4000ms to ~100ms.
 2018-08-19 23:19:08 -07:00
Greyson Parrelli
e9b85a10a6 Add per-contact notification channels. 
Fixes #8119
Fixes #8121
Fixes #8122
 2018-08-17 15:51:01 -07:00
Greyson Parrelli
c49b0348bd Add failsafe for invalid shortcuts. 
Some launchers may create broken shortcuts, so we just want to have
a smooth fallback in that scenario.

Fixes #8109
 2018-08-15 12:48:04 -07:00
Greyson Parrelli
3c6b8bcf9b Hide inline attachment button when attachment present. 2018-08-15 12:35:41 -07:00
Greyson Parrelli
a6473bc922 Link priority setting to message channel setting on Oreo+ 
When using notification channels, us setting priority actually has
no effect. So instead of having a non-functional setting, we've
routed the notification priority setting to go to the system
notification channel settings page for our Messages channel.
 2018-08-15 12:11:10 -07:00
Greyson Parrelli
10a790df88 Fix notifications triggering too often. 2018-08-14 20:19:25 -07:00
Greyson Parrelli
eabaead700 Revert "Fingerprint unlock UX improvements" 
This reverts commit 8441ac4091fff3c6f6ae984d9b76c4b45b10c36b.

Fixes #8106
 2018-08-14 13:04:33 -07:00
Greyson Parrelli
d581525a61 Fix Log secret reading. 
Accidentally typed '>' instead of '>='.

Fixes #8107
 2018-08-14 15:09:24 -04:00
Greyson Parrelli
d79564021f Remove extra space below notification text. 
Special thanks to @dwong

Fixes #7905
 2018-08-13 18:38:59 -04:00
Greyson Parrelli
2acbea014b Fix videos losing their extension after forwarding. 
Special thanks to @signalien

Fixes #7783
 2018-08-13 18:38:59 -04:00
Greyson Parrelli
2882ef6d9f Reset register button status after an error. 
Fixes #8052
 2018-08-13 18:38:59 -04:00
art1fa
8441ac4091 Fingerprint unlock UX improvements 2018-08-13 18:38:59 -04:00
Greyson Parrelli
20c896413b Stop linkifying addresses. 
Address linkification on Android is pretty busted, and the docs
acknowledge it (see Linkify#MAP_ADDRESSES). Safest thing to do
at the moment is remove it. Looks like we may be able to get
better address linkification on API >= 28, but adding it will
be more involved.

Fixes #7730
 2018-08-13 18:38:59 -04:00
Greyson Parrelli
13c72779af Visually note quotes for messages you don't have. 
We will now show a small footer under quotes for messages that you
don't have locally.

Also fixes #7850
 2018-08-13 18:38:59 -04:00
Greyson Parrelli
5cdf5499d0 Clean up shortcut code. 2018-08-13 18:38:59 -04:00
Leonard Ehrenfried
c3c44e324b Allow users to add conversation shortcuts to the home screen. 2018-08-13 18:38:59 -04:00
Greyson Parrelli
c7da83a702 Show attachment button while composing text. 
Previously, we'd only show the attachment button when the user had
yet to enter any text. To add an attachment after text was entered,
you'd have to go to the three-dot menu. Now we just show a little
attach button in the text area.

I also took the opportunity to clean up other button paddings and
stuff in the compose area so things look better and react to text
sizes more predictably.
 2018-08-13 18:38:59 -04:00
Greyson Parrelli
dbd42c4af2 Add notification channel support. 
Bucket our notifications into channels. Required to target API 26.
 2018-08-13 18:38:53 -04:00
Greyson Parrelli
d0db6aa509 Added more logging around message sending and attachment downloads. 2018-08-06 10:50:06 -04:00
Greyson Parrelli
43068e0613 Reduce usage of Log.w() 2018-08-06 10:50:06 -04:00
Greyson Parrelli
a498176043 Switch logs to use new Log class. 2018-08-06 10:50:06 -04:00
Greyson Parrelli
acb40c6133 Added new logger. 
Added a new logger that persists logs for a longer duration to the
user's cache directory. Logs are encrypted. The new logs are sent
in addition to the user's logcat output.
 2018-08-06 10:50:06 -04:00
Greyson Parrelli
b7d83c7a1f Make libpaste a source dependency. 2018-08-06 10:50:06 -04:00
Greyson Parrelli
c8571d7bc7 Use correct timestamp for footer collapse. 
Fixes #8071
 2018-08-06 10:34:02 -04:00
Greyson Parrelli
d42cecc32a Fix timer issue with sync messages from desktop. 
Related to #8068
 2018-08-03 14:08:16 -04:00
Greyson Parrelli
c5014f9471 Fix quote crash when we decode an image of 0 length. 
Fixes #7983
 2018-08-02 15:57:30 -04:00
Greyson Parrelli
6db3f249c6 Populate contact name when adding shared contact. 
Fixes #8016
 2018-08-02 15:16:51 -04:00
Greyson Parrelli
5a1ef31b49 Fix crash with moveToLastSeen() 2018-08-02 11:57:10 -04:00
art1fa
faea8fd2ec Apply message bubble paddings to both top and bottom 
Batch selecting messages now feels better. Fixes #8035.
 2018-07-27 16:15:37 -04:00
Greyson Parrelli
79830049c4 Fix emoji vertical positioning. 
Fixes #8023
 2018-07-27 16:01:52 -04:00
Greyson Parrelli
a3115c14ac Use proper target for Glide bitmap requests. 
Fixes #8042
 2018-07-27 09:12:54 -04:00
Greyson Parrelli
67190774cc Jump to the oldest unread message after loading a draft. 2018-07-25 13:10:35 -04:00
Greyson Parrelli
d5753bc306 Fix spacing issue between short clustered group chats. 
For short messages in a cluster, the contact photo was sometimes taller
than the actual bubble, leading to extra weird space. So instead we use
a container to hold the width of the cell, and set the avatar to be GONE
instead of INVISIBLE.
 2018-07-25 01:16:48 -04:00
Greyson Parrelli
e96a02ab35 Fix next/prev message detection with fastRecords. 
The previous way we were getting the next/previous record didn't take into
consideration that some records aren't in the cursor -- some are in the
fastRecords map. We now use the proper position to get the next/previous
message.
 2018-07-25 00:24:49 -04:00
Christian Ascheberg
0bb44f2034 Improve disappearing message time strings 
Fixes #7501
 2018-07-24 20:35:51 -04:00
Moxie Marlinspike
fbd3f3db3f Update webrtc to M68 2018-07-24 17:06:43 -07:00
Greyson Parrelli
d82e91ca20 Fix message button in conversation settings. 
Switching to use our convenience methods for start texts and calls.

Fixes #8026
 2018-07-24 17:15:03 -04:00
Greyson Parrelli
c7fb1d79c4 Properly show group message header after a date divider. 2018-07-24 16:33:45 -04:00
Greyson Parrelli
0ced767ef2 Use person's name in call update text. 2018-07-24 16:33:05 -04:00
Greyson Parrelli
39b27a9d7a Properly map hashed legacy colors to the new color palette. 
Fixes #8021
 2018-07-24 12:53:36 -04:00
Greyson Parrelli
6a1fd8b1c6 Increase difference between read/unread conversations in list. 
Updating to match the design.
 2018-07-24 12:34:21 -04:00
Greyson Parrelli
d8ddb142a9 Fixed bug in onMeasure() overflow safeguard. 
Fixes #8008
 2018-07-23 07:54:24 -07:00
Greyson Parrelli
214658b99e Fix recording not resetting properly after a send on older API's. 
Apparently onAnimationEnd is not a reliable event on some Android
versions, so I've moved to instead using a simple postDelayed() that is
the same length as the animation.
 2018-07-20 19:02:19 -07:00
Greyson Parrelli
415fe3463d Don't collapse outgoing footers for pending or failed messages. 2018-07-20 18:45:18 -07:00
Greyson Parrelli
6234e56e78 Allow outgoing messages to collapse footers. 2018-07-20 18:35:04 -07:00
Greyson Parrelli
f82b2c0d3f Prevent author name from making media messages too wide. 
The media size traditionally determines the bubble size, but the author
could make it wider, which would lead to rendering issues. In the case
of media attachments (images, videos, and shared contacts), we restrict
the width of the author name. When there's a number+profile name combo,
we split the space 50/50 between the two.
 2018-07-20 18:24:52 -07:00
Greyson Parrelli
a4214300ec Fix crash with conversations with "uknown contact" header. 
We weren't accounting for ConversationAdapter header position when
getting the next and previous record in a conversation.
 2018-07-20 17:50:54 -07:00
Greyson Parrelli
c9bb3dd469 Remove now-unnecessary thumbnail onMeasure(). 2018-07-20 16:16:19 -07:00
Greyson Parrelli
aa25f39fe9 Fix footer icon tints. 2018-07-20 15:40:13 -07:00
Greyson Parrelli
860047c2d3 Remove CornerMaskingView. 2018-07-20 14:24:04 -07:00
Greyson Parrelli
d0eaee60e9 Add additional safeguards for picking an expiration timer frame. 
Fixes #8010
 2018-07-20 14:08:58 -07:00
Greyson Parrelli
d303a88803 Fix quote dismiss button not showing up. 
Fixes #8006
 2018-07-20 14:03:03 -07:00
Greyson Parrelli
8f551c8b32 Fix various redesign issues with Android 4.x. 
In particular, there were many issues with drawing corners.
Unfortunately, there's no pretty way to get masking working on every
Android version, so we have to switch back to using custom backgrounds
and then using multiple masking methods depending on Android version.

Also, I had to remove attr references in drawables. They crash on 4.x.
 2018-07-18 16:53:36 -07:00
Jonathan Fung
85d963047e Adding a long press icon description for the Search icon 
Fixes #7836
 2018-07-18 09:04:42 -07:00
floesche
df9833472f Add z5 compact (E5823) to AEC blacklist 
Following fixes for other models to reduce echo on callee side during Signal call. 

The problem has been reported for this model for example in #6241
 2018-07-18 08:53:27 -07:00
Greyson Parrelli
bf692e8da3 Throttle background contact syncs to once every 6 hours. 
Unfortunately, there's apps out there that trigger contact changes
very frequently. Because we listen to the system for contact
changes to tell us when to sync, that could result in us sending
an abundance of contact syncs to linked desktop instances.

This throttles contact sync requests using the following methodology:

- By default, throttle contact syncs to 6 hrs while the app is
  backgrounded.
- If a sync is throttled in the background, we set a dirty flag and
  will execute the sync the next time the app is foregrounded.
- Syncs explicitly requested by desktop are never throttled.
 2018-07-17 12:06:50 -07:00
Greyson Parrelli
8579c30909 Styling improvements and code cleanup. 2018-07-17 12:06:42 -07:00
Greyson Parrelli
845fcf0864 Remove ability to set group conversation colors (for now). 2018-07-17 09:54:13 -07:00
Greyson Parrelli
24b062d8dd Improve the look of message bubbles. 2018-07-17 09:53:52 -07:00
Greyson Parrelli
b02dda405c Use NetworkBackoffRequirement for group messages. 2018-07-12 10:59:10 -07:00
Moxie Marlinspike
bc60cba2b8 Fix default SMS app intent >= N 
Fixes #7964
 2018-07-10 10:14:35 -07:00
Greyson Parrelli
84e2fcad54 Update UI of toggling shared contact photo. 2018-07-05 10:05:54 -07:00
Greyson Parrelli
6ce8516b93 Make contact photos optional when sharing contacts. 
Previously, if you had a contact photo for a user, we'd always send it
Now you can choose whether or not it is sent.
 2018-07-03 17:16:50 -07:00
Greyson Parrelli
67407ec667 Hard-code migration for full-text search. 2018-07-02 18:10:11 -07:00
b0m0x
2290549349 add Mi A1 to hardware AEC blacklist 
See #7635
 2018-07-02 17:45:55 -07:00
Greyson Parrelli
bf07048d7b Use earlier read timestamp when syncing read status with desktop. 
Previously, we'd always use the value desktop gave us. However, if we
have an earlier read time locally, we want to use that instead.
 2018-07-02 17:39:10 -07:00
Greyson Parrelli
3134837d56 Remove plaintext backup import option. 
We have our own secure backup solution built into the app now.
No need to support plaintext backups.
 2018-07-02 17:11:13 -07:00
Greyson Parrelli
c7066c0796 Cast to MmsMessageRecord in ConversationFragment#handleForwardMessage. 
Was causing a crash for MMS messages.

Fixes #7951
 2018-07-02 08:56:11 -07:00
Greyson Parrelli
18756aedf6 Remove the ability to save backups to the external SD card. 
The directory we were previously saving backups to on the external SD
card is actually deleted upon app uninstall and/or clearing the app's
data. There's also no reliable way to write to the root of an external
SD card (that isn't comically inconvenient), so for now it's safer if we
just move back to getting the regular 'ol standard external storage
directory (which is likely internal storage, despite its name).

Fixes #7845
 2018-06-29 14:10:45 -07:00
Greyson Parrelli
290b184491 Enable shared contact sending. 2018-06-29 11:08:13 -07:00
Greyson Parrelli
0d386d3c14 Fix progress bar showing for self-sends. 
For self-sends, we were never marking attachments as uploaded. I made is
so that happens now, but to prevent it for showing for already-sent
messages, we also don't show controls for self-send conversations.
 2018-06-28 12:07:23 -07:00
Greyson Parrelli
fd6d947df3 Fix ClassCastException in ThreadDatabase. 
I casted too deep. Forgot about NotificationMmsMessageRecord.
 2018-06-27 09:43:02 -07:00
Greyson Parrelli
381547d668 Fix crash with formatting emails in recipient settings. 
Fixes #7868
 2018-06-22 13:24:36 -07:00
Greyson Parrelli
f72f75ee61 Show a link for privacy policy. 2018-06-22 13:09:43 -07:00
Greyson Parrelli
b39a7ac939 Add expiration time to group update requests. 2018-06-22 11:29:16 -07:00
Greyson Parrelli
b5d4cac90a Send/receive expiration times for group updates. 
This particularly helps with the bug where people who were newly added
to a group wouldn't receive an expiration timer until the first message
was sent.
 2018-06-22 11:01:55 -07:00
Greyson Parrelli
dae655fd01 Fix conversation snippet for contact shares. 
Previously, contact shares would be displayed as "Media Message". Now
it'll show the same as it does in a notification, namely
"{contact-emoji} {contact-name}".
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
933be54035 Update scheduling of ServiceOutageDetectionJob. 
Previously, we were running this job in PushSendJob#onCanceled().
However, with the new retry logic, this won't happen for 24 hours.

Instead, we now schedule the job in PushSendJob#onRetry().
 2018-06-22 10:59:53 -07:00
2-4601
f1d8fd8838 Add devices to hardware AEC blacklist 
- Moto G4
- Nokia 5 (TA-1053)

Alleviates #7635
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
a50edc3d25 Keep retrying message sends for 24 hours. 
Previously, we retried based on a count. Now we've added the ability to
keep retrying for a specified time, using exponential backoff to
throttle attempts.
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
62c42a3513 Fix disappearing message corner case. 
We never properly registered the ExpirationListener, meaning we were
relying on the wait-notify loop of ExpirationManager to delete things.
This normally works, but fails when your phone goes to sleep. So I
properly registered the receiver, and then added a failsafe to re-run
the ExpirationManager if we're about to render an expired message.

Fixes #7906
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
42f1baaf61 Imported JobManager as a source dependency. 
We have to make some changes, and it's gotten to the point where
maintaining it as a separate library is more hassle than it's worth,
especially with Google releasing WorkManager as the preferred job
scheduling library.
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
5f99470226 Allow searching for words with apostrophes. 
Previously, because apostrophes were 'banned' characters, searching for
them wouldn't work. That meant you couldn't find words like "I'm". Now
we just replace the apostrophe with a space and things "just work"
because of the nature of SQLite tokenization and prefix queries.
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
afec9e8cb0 Improve highlighting in search results. 
Previously, we didn't support highlighting search results that had
tokens in the middle of the matches, which is a possibility with FTS.
Now we do more robust highlighting, as well as highlight matches in
phone numbers.
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
89fd7dda23 Break FTS queries into multiple prefix queries. 
Previously, we made each full-text search query a single prefix query.
That means that the query "do c" would turn into "do c*". That means it
would match "do cat" but not "dog cat".

Now, we make each token a prefix query. So "do c" would turn into
"do* c*". That means it would match both "do cat" and "dog cat".
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
3563efc7de Update search query results when messages disappear. 
Previously, if a message disappeared while looking at it in the search
results, it'd still stick around. Now they'll disappear from the results
in real-time.
 2018-06-22 10:59:53 -07:00
Greyson Parrelli
ea4ac9db30 Fixed issue where self-sends didn't auto download. 
1) There was an issue where we wouldn't auto-download group syncs.
2) There was another issue where we didn't show the download controls
   for messages you sent yourself.

Fixed #7920
 2018-06-22 10:37:07 -07:00
Greyson Parrelli
71a34dac5f Fix backup/import issue with expiring messages. 
There was an issue where we were backing up group receipts and attachments
that were for expiring messages (which are already excluded from the backup).

This commit excludes these items from the backup, and for backups made
before this change, this commit also deletes these invalid entries at
the end of the restore process.

We also do a little database migration to cleanup any bad state that may
have been imported in the past.
 2018-06-21 19:07:27 -07:00
Greyson Parrelli
61b2da9c8a Fix NPE during busy call. 2018-06-21 18:47:14 -07:00
Greyson Parrelli
3a85c966d0 Fix false-positive outage detection. 
Turns out that there's some weird quasi-state when you come out of
airplane mode, that if you do an InetAdress lookup, it returns some
weird IPv6-looking garbage address. Going to retry in that scenario
instead of assuming an outage.
 2018-06-20 13:24:33 -07:00
Greyson Parrelli
fe4ce88439 Revert "Upgrade SQLCipher to respect a max window size." 
This reverts commit dace93abb3cd5bf5cf7bd722d688b0ae302a4722.
 2018-06-18 16:24:35 -07:00
Greyson Parrelli
542e962be9 Fixed crash when ScribbleView failed to save. 
Previously, if an operation failed, we set the result to "null".
However, this was a mistake. Setting the result at all assumes success.
Instead, we need to set an exception so the ListenableFuture knows that
the operation failed.
 2018-06-18 14:33:44 -07:00
Greyson Parrelli
2c17b54ef9 Show a banner in the event of a service outage. 
We will now determine if there has been a service outage and render a
banner at the top of the conversation list if we detect that there has
been one.
 2018-06-18 14:32:45 -07:00
Greyson Parrelli
0999359454 Improve the image editor. 
A variety of improvements to the image editor, such as:

- New, fullscreen styling
- Smoother lines
- Better text and sticker handling
- Improved color picker with a history pallette
- New highlighter tool
 2018-06-18 14:32:45 -07:00
Greyson Parrelli
dace93abb3 Upgrade SQLCipher to respect a max window size. 
Previously, SQLCipher's memory usage would grow indefinitely, up until
it hit the end of the cursor. We've now switched to a release where the
memory  used by the cursor can be bounded.
 2018-06-18 14:32:45 -07:00
Greyson Parrelli
df2c5d38b0 Don't notify new users if there is a pending SQLCipher migration. 
If a user is upgrading to use the SQLCipher database (which happened
back in 4.16, so this only applies to relatively dormant users who are
just getting back into the app) and received a new "user X joind signal"
message, then it could screw up the migration. So we're just dropping
these notifications that happen in this narrow window.
 2018-06-18 14:32:45 -07:00
Greyson Parrelli
79857b98b3 Fix bug with quoted reply notifications. 2018-06-18 14:08:47 -07:00
Greyson Parrelli
626e6930a5 Fix search header rendering after rotation. 
The sticky header cache was keeping views across rotations, causing them
to render incorrectly afterwards. I added a method to invalidate the
header layouts after rotation.

Fixes #7890.
 2018-06-14 10:50:21 -07:00
Greyson Parrelli
44f5cc9070 Annotate methods in AttachmentUtil as @WorkerThread. 2018-06-11 11:08:25 -07:00
Greyson Parrelli
30be732ae8 Don't auto-download attachments from unknown contacts. 2018-06-11 10:47:27 -07:00
Greyson Parrelli
2b45b3caa2 Fixed export and restore of FTS tables. 
First, FTS index contents do not need to be exported. They will be recreated naturally.

Second, we can't export the secret FTS tables, or SQLite will think it's corrupted.
 2018-06-06 20:12:17 -07:00
Greyson Parrelli
b7282589de Fixed issue with backup and restore when creating new tables. 
Fixes #7863
 2018-06-06 09:07:38 -07:00
Greyson Parrelli
6bc7f2a5a4 Fix NPE in FTS when snippet is null. 2018-06-06 08:08:52 -07:00
Greyson Parrelli
3731e2a74a Fix jumbomoji rendering and EmojiTextView resizing. 
Fixed an issue where jumbomoji were not properly being rendered
when using system emoji. Also fixed an issue where the text
content wasn't properly being recalculated when the view is
resized.

Fixes #7875
 2018-06-06 07:57:03 -07:00
Greyson Parrelli
f0e5aa312e Allow EmojiTextView to redraw after changing emoji setting. 
Also just fixed some minor formatting issues.
 2018-05-28 17:20:28 -04:00
Greyson Parrelli
ceafb0d130 Reduce emoji flickering and other ellipsize woes. 
1. Switch to using default text rendering if there's no emoji present in
the string.

2. Reduce redudant redraws by skipping of setText() calls for identical
strings.

Together, these two changes should reduce the vast majority of
flickering we see with EmojiTextView ellipsizing.
 2018-05-24 13:32:56 -04:00
Moxie Marlinspike
70c2a863cc Correctly store backup 
Fixes #7831
 2018-05-24 09:57:16 -07:00
Greyson Parrelli
d813275f42 Increase number of recent conversations shown when sharing. 
Intended to reduce the pain of #7202.
 2018-05-24 10:25:58 -04:00
Greyson Parrelli
5650a02cfb Sort search results exclusively by date. 
I think I was initially lured into searching by rank because it gives
the illusion of providing the "best match". However, in practice, FTS
never gives back "bad" matches with low ranks -- all of the results it
returns will contain your query in some form (most commonly a direct
substring, but they do take some liberties if you have multiple tokens
in your queries). Given that, in general, more recent search results are
in fact more relevant, we can sort by date exclusively and get a better
ordering overall.
 2018-05-24 09:39:57 -04:00
Greyson Parrelli
0503c9eea5 Prevent replies on action messages. 
Fixes #7829
 2018-05-23 15:16:42 -04:00
Greyson Parrelli
abae419853 Flatten multiline text snippets in search results. 
If a search result snippet spans two lines, we only show the first line.
For the purpose of display, we first remove all newlines in order to
make the full snippet visible.
 2018-05-23 14:32:46 -04:00
Greyson Parrelli
71ccbf2a1b Secondarily sort search results by date. 
This should help with getting back search results that more closely
match user intention.
 2018-05-23 14:17:43 -04:00
Greyson Parrelli
92a64f59a4 Switch search to use the existing header. 
Probably best to not try out any possible new design changes just yet.
Let's stick with what we have.
 2018-05-23 11:06:07 -04:00
Greyson Parrelli
e189fff856 Fixed some cursor-related bugs in Search. 2018-05-23 08:32:46 -04:00
Greyson Parrelli
e6e8416aec Use correct recipient for message search results. 
Previously, we'd always use the recipient of the message record, which
was incorrect for messages sent to groups. Now we always use the
recipient for the matching thread record.

Fixes #7823
 2018-05-23 08:22:08 -04:00
Greyson Parrelli
a792a6e6ae Fixed ThumbnailView sizing problems. 
Glide will use the dimensions of the target ImageView as the dimensions
for the image it's loading. This caused problems in the case of
ThumbnailView, as we were constantly changing the ImageView dimensions,
meaning Glide may not have the most recent values (it may be called in
between measure calls, for instance).

To solve this, we now will always override the default image dimensions
when we load an image. If no dimensions are present, we will default to
the layout_width and layout_height of the ThumbnailView.

Fixes #7810
 2018-05-22 17:03:51 -04:00
Greyson Parrelli
0b1b568893 Fix notifications for replies. 
Notifications for replies will no longer display as a "Media Message" if
they do not contain media. Instead, they will just contain the reply
text.

Fixes #7798
 2018-05-22 13:12:13 -04:00
Greyson Parrelli
93effc8890 Disable contact sending. 2018-05-21 19:57:50 -04:00
Greyson Parrelli
5d75f11cbc Bump version to 4.20.0. 2018-05-21 17:19:03 -04:00
Greyson Parrelli
0449647cf9 Implemented full-text search. 
You can now use the search bar on the conversation list to find
conversations, messages, and contacts.
 2018-05-21 16:36:59 -04:00
Greyson Parrelli
c0b75c2ef5 Disable shared contact sending. 
Sending shared contacts isn't backwards-compatible, so we want to have a
few releases where receiving is enabled, but not sending. That way, when
we enable sending, most users should be able to properly receive the
shared contact messages.
 2018-05-21 15:45:22 -04:00
Greyson Parrelli
ca260a92e3 Convert vCard attachments to Shared Contacts. 
When you share a vCard from an external app (like the Contacts app) into
Signal, we'll now convert it to a pretty Shared Contact message and
allow you to choose which fields of the contact you wish to send.
 2018-05-21 15:45:22 -04:00
Greyson Parrelli
e6c16cf28d Allow editing of contact names. 
Took care to properly format CJK names.
 2018-05-21 15:45:22 -04:00
Greyson Parrelli
54dbffaf30 Added ability to share contacts. 
The "contact" option in the attachments tray now brings you through an
optimized contact sharing flow, allowing you to select specific fields
to share. The contact is then presented as a special message type,
allowing you to interact with the card to add the contact to your system
contacts, invite them to signal, initiate a signal message, etc.
 2018-05-21 15:45:22 -04:00
Greyson Parrelli
17dbdbd0a9 Handle quote position task finishing after fragment detaches. 
There's a chance that the AsyncTask that retrieves a quoted message's
position could finish after the fragment is detached, which would cause
a crash. I've changed it so if this case occurs, the result is ignored.

Also, I noticed that when searching the message table, if a quote can't
be found, we'd end up traversing the entire table. To prevent this from
taking forever on large message tables, I've limited it to searchin only
what is currently present in the adapter.

Fixes #7756
 2018-05-21 15:45:22 -04:00
Greyson Parrelli
ca8fecea9c Clean up camera flipping, handle having missing cameras. 
Did a refactor to better organize the camera flipping code. Also, I
wanted to make sure we handle the cases where the user doesn't have two
cameras (or no cameras, for that matter). In these cases, we just don't
show the appropriate buttons.
 2018-05-21 15:45:22 -04:00
Niklas Hambüchen
f1c79eaebf Add button to flip camera (front vs rear). Fixes #6279 2018-05-21 15:45:22 -04:00
Moxie Marlinspike
6c1a1fb9ad Use cache directory on removable storage for backups if present 
Fixes #7692
 2018-05-21 15:45:22 -04:00
Moxie Marlinspike
35d158cfee Treat Permissions "not now" as a denial 
Fixes #7713
 2018-05-21 15:45:22 -04:00
Moxie Marlinspike
a5047cb17b Fix for sender's expiring messages in group with unregistered user 
Fixes #7719
 2018-05-21 15:45:22 -04:00
Moxie Marlinspike
5006b36e2d Show lock notification immediately after setting is toggled 
Fixes #7659
Closes #7678
 2018-05-21 15:45:22 -04:00
Greyson Parrelli
102941c18c Fix QuoteView measuring when voice notes are present. 
Fixes #7740
 2018-04-26 17:41:37 -07:00
Greyson Parrelli
43622e603d Save replies in drafts. 
Previously, quotes were not saved to drafts, meaning they would be lost
when leaving the conversation or app. Now, a QuoteId (which represents
the necessary data to restore the QuoteModel) is serialized and stored
in the DraftDatabase.

Fixes #7716
Closes #7729
 2018-04-26 09:19:22 -07:00
Greyson Parrelli
6fbbc9d078 Render emoji's properly in quote bubbles. 
Unfortunately, the change wasn't as simple as just switching to use our
EmojiTextView. That view only supported single-line text. I added
support for multi-line text.

Fixes #7704.
 2018-04-24 12:18:33 -07:00
Greyson Parrelli
cbe394025d Fix reply-to colors in dark mode to increase contrast. 
Fixes #7705
 2018-04-20 17:35:48 -07:00
Nicholas Rizzio
e6f76159b0 Export "creating backup" string 
Closes #7656
 2018-04-19 17:59:31 -07:00
Henning Dodenhof
e0603abdd3 Use FileProvider for update file handling 
Fixes #7654
Closes #7658
 2018-04-19 13:30:21 -07:00
Moxie Marlinspike
2a1ce859c4 Add Moto G (5S) Plus to hardware AEC blacklist 
For #7635
 2018-04-19 10:58:39 -07:00
Moxie Marlinspike
8452fc6c58 Correctly avoid displaying about category in groups 
Fixes #7702
 2018-04-19 10:53:37 -07:00
Moxie Marlinspike
2ac0179d65 Handle odd sized buffers on backup import decrypt 
Fixes #7701
 2018-04-18 21:20:06 -07:00
Greyson Parrelli
fa99e8f0d0 Updated reply-to UI. 
All UI components are now properly styled and functioning according to
spec.
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
d567534609 replies 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
8bec5a96f5 Make delivery receipts work correctly on CDMA networks 
Fixes #7646
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
d8a6fcf979 Retain latest 2 instead of latest 5 backups 
Fixes #7650
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
2c405d1769 Delete raw contacts that are marked for deletion 
Fixes #7628
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
821957137a Check for context liveness to prevent NPE 
Fixes #7633
 2018-04-16 17:33:26 -07:00
Greyson Parrelli
b8fbc91f33 Only show copy if text is selected, remove newlines from copied text. 
We now check if _any_ text is selected when doing a batch selection
to determine if we should show the copy option. Also, previously it
was putting in empty lines for messages that don't have any text. I
changed it so empty messages have no effect on the text that is copied.

Fixes #7472
 2018-04-16 17:33:26 -07:00
FeuRenard
404610fbcd Pass correct address from media overview to preview 
Fixes #7384
Closes #7387
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
3f3d7f549b Make an attempt to store/retrieve backups from removable storage 
Fixes #7521
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
7dd8baba5a Add permission callback to preference fragment 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
eb0af13887 Fix location URL encoding 
Fixes #7604
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
72310ed3c6 Group member dialog tap takes you to recipient preference 
Fixes #7463
 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
e86a9ce7eb Add phone number and direct dial to recipient preferences 2018-04-16 17:33:26 -07:00
Moxie Marlinspike
0b0853a223 Clear cache on update 2018-04-12 17:19:18 -07:00
Moxie Marlinspike
ccc3ff4aac Fix for Glide image caching issue 
Fixes #7630
 2018-04-09 09:03:42 -07:00
Moxie Marlinspike
ca471b1408 Explicitly remove messages.db journal 
Fixes #7636
 2018-04-05 03:50:33 -07:00
Moxie Marlinspike
3bceb0d8ec Delete old message DB 2018-04-04 05:09:43 -07:00
Moxie Marlinspike
0753ff85ed Default snippet type to 0 if it's null 
Fixes #7551
 2018-04-03 08:59:19 -07:00
Moxie Marlinspike
b9f99f9941 Manually calculate length of attachments if they're super old 
Fixes #7560
 2018-04-02 10:03:26 -07:00
Moxie Marlinspike
2c82b3610d Mark DB current after backup upgrade process 
Fixes #7596
 2018-04-02 06:27:50 -07:00
Greyson Parrelli
18039bc3f4 Show groups when searching for contacts. 
Currently, if you're searching for a contact to start a conversation
with or send a share to (via the Android sharing system), groups do not
appear. With this change, groups will now appear when searching, located
under their own  heading.

Fixes #7202.
Closes #7577
 2018-03-31 02:14:02 -07:00
Greyson Parrelli
a573ab7c76 Setup alternate domain front. 
In preparation for Google shutting down domain fronting.

Closes #7584
 2018-03-31 02:14:02 -07:00
Greyson Parrelli
ea374735e1 Render images in a conversation true-to-size. 
Previously, we were always rendering images as squares. Instead of doing
that, we now render them as close to true-to-size as possible (within
reasonable min/max width/height boundaries).
 2018-03-31 02:14:02 -07:00
Moxie Marlinspike
9f8b4cf892 Populate incoming attachments with width and height from message 2018-03-31 02:14:02 -07:00
Moxie Marlinspike
3c30db7edf No longer generate image thumbnails manually 
Delete manually calculated image thumbnails
 2018-03-31 02:14:02 -07:00
Moxie Marlinspike
95d76638dc Simple encrypted glide disk cache 2018-03-31 02:14:02 -07:00
Greyson Parrelli
7e1e666172 Strip EXIF metadata from all JPEG images. 
Strip all EXIF metadata from all JPEGs by re-encoding the JPEG. This
will keep all of the necessary visual effects of the tags (by encoding
them directly in the image data) while stripped the EXIF tags
themselves.
 2018-03-31 02:14:02 -07:00
Greyson Parrelli
10e5b24cfd Allow batch deletion of media. 
It is now possible to batch-delete media in the "media overview" screen.
You can long press to enter multi-select mode. Then a delete button
appears on the menu bar. After pressing delete, you will get a
confirmation, and if the user confirms, the items will delete while a
progres dialog shows.
 2018-03-31 02:14:02 -07:00
Greyson Parrelli
0c768a24e4 Allow deletion of media through preview. 
When viewing a media in the media preview, you can delete it by pressing
a delete button on the action bar. It will then ask you to confirm your
choice. If you confirm, it will delete the attachment from the database
and from disk. If it was the only attachment for that message, the
message itself will also be deleted.
 2018-03-31 02:14:02 -07:00
Moxie Marlinspike
d6610f0dd0 Add profile avatars to backup 
Fixes #7450
 2018-03-19 14:10:21 -07:00
Moxie Marlinspike
261296e41b Don't crash direct share service if avatar photo is missing 
Fixes #7541
 2018-03-19 13:17:57 -07:00
FeuRenard
9c0129c4b0 Allow skipping registration PIN intervals on success 
Closes #7517
Closes #7518
 2018-03-15 12:14:43 -07:00
Moxie Marlinspike
b168e14985 Move salt outside the loop 2018-03-15 10:18:14 -07:00
Moxie Marlinspike
73233c01ba Fix backup NPE 
Fixes #7526
 2018-03-14 23:40:01 -07:00
Moxie Marlinspike
90006e81db Add salt to backup header 2018-03-14 10:28:41 -07:00
Greyson Parrelli
f544b7d7b4 Reduce image stutter by using subsampling more often. 
Fixes #7208.
 2018-03-13 13:25:41 -07:00
Moxie Marlinspike
41d06fc8c2 Simplify reminder interval lookup 
Fixes #7513
 2018-03-13 09:39:56 -07:00
Moxie Marlinspike
aff65abe91 Hide keyboard after backup passphrase entered 
Fixes #7508
 2018-03-13 09:28:27 -07:00
Moxie Marlinspike
64afce5f66 Switch to parameterized statements for backup 
Fixes #7507
 2018-03-13 09:27:58 -07:00
Moxie Marlinspike
6b5da7f8cf Disable registration lock reminders for <=KK devices 
Fixes #7500
 2018-03-11 17:30:31 -07:00
Moxie Marlinspike
43d7e99a50 Don't offer backup restore on reregistration 
Fixes #7502
 2018-03-11 17:12:42 -07:00
平民·寻梦(Pingmin Fenlly Liu)
cc288d1e43 Just update to the new repo path "github.com/signalapp" 
Closes #7469
 2018-03-11 17:06:22 -07:00
junitas
7f7aab044c Escape single quotes in SQLite entries for message backups 
Fixes #7491
Closes #7497
 2018-03-11 17:00:53 -07:00
Moxie Marlinspike
c8dd62cecf Make it possible to set a zero value for screen lock timeout 
Fixes #7485
 2018-03-09 15:27:20 -08:00
Moxie Marlinspike
11ce4ee807 Actually increment event count 2018-03-09 14:29:15 -08:00
Moxie Marlinspike
40d14698b8 Fix NPE introduced by #6886 2018-03-09 11:14:37 -08:00
Moxie Marlinspike
34ed55d3ac Post backup progress event for every item 
Fixes #7483
 2018-03-09 11:03:18 -08:00
Moxie Marlinspike
954b2f22f6 Don't immediately prompt for registration lock pin after reregistration 
Fixes #7484
 2018-03-09 10:41:43 -08:00
Moxie Marlinspike
b39820dcb6 Clarify Registration Lock reminder 
Fixes #7484
 2018-03-09 10:40:29 -08:00
Moxie Marlinspike
1a24885110 Fix issue "home button" issue with screen lock 
Fixes #7475
 2018-03-09 10:25:29 -08:00
Moxie Marlinspike
29fcce23b1 Prevent double screen lock intent from firing 
Fixes #7475
 2018-03-08 17:41:27 -08:00
Moxie Marlinspike
a2d04f4806 Prevent us from sql injecting ourselves on backup/restore 
Fixes #7478
 2018-03-08 16:39:57 -08:00
Andy Staudacher
61a7062030 Remove obsolete workaround for DE/FI/SK shortcodes 
libphonenumber supports these since December 2015 / January 2016.
Most of these changes went into libphonenumber-7.2.2 (Dec 15, 2015),
the last changes related to this into libphonenumber-7.2.4 (Jan 28, 2016).
This was about adding EU-wide helplines 116xxx (http://ec.europa.eu/digital-agenda/en/116-helplines).
See: https://github.com/googlei18n/libphonenumber/blob/master/java/release_notes.txt

Closes #6130
 2018-03-07 09:59:43 -08:00
Sam Lanning
69f180a5ec Fix some potential integer overflows for expiration time 
In a number of locations in the code, there were conversions of message
expiration times from seconds to milliseconds, and then assigned to `long`
contexts. However these conversions were being done as integer multiplication
rather than long multiplication, meaning that there was a potential for
overflows.

Specifically, the maximum value that could be represented before overflowing
was (2^31 / 1000 / 60 / 60 / 24) days = 24.8 days (< 1 month). Luckily the
current allowed timeouts are all less than that value, but this fix would
remove the artificial restriction, effectively allowing values of 1000x greater
(68 years), at least for android.

Related #5775
Closes #7338
 2018-03-07 09:55:24 -08:00
Andrew Gaul
10c1ee70e8 Make some inner classes static 
Closes #7370
 2018-03-07 09:51:05 -08:00
FeuRenard
0efda2df91 Make toast after saving attachment translatable 
Closes #7374
 2018-03-07 09:41:33 -08:00
art1fa
4bdb2acd29 Batch selection mode improvements 
Simplified and now the same for conversation and conversation list.

Added also some styling.

Closes #7410
 2018-03-07 09:38:51 -08:00
FeuRenard
527e39eee8 Don't save white space drafts 
Fixes #7308
Closes #7383
 2018-03-07 09:33:57 -08:00
Marek Sebera
694a5de2c3 Send m-notifyresp-ind (NotifyRespInd) for retrieved MMS on Lollipop API 2018-03-06 17:34:31 -08:00
junitas
4b5d7bbfa4 Ignore swipe events for ConversationListItemInboxZero 
Fixes #7423
 2018-03-06 09:35:13 -08:00
Moxie Marlinspike
110d33ddf8 Support for Registration Lock PINs 2018-03-05 16:13:56 -08:00
Moxie Marlinspike
d28dc670ea Migrate to Android fingerprints and auth for Signal screen lock 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
3970a30e14 Add chunk IV to chunk MAC 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
24e573e537 Support for full backup/restore to sdcard 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
9f6b761d98 Migrate sessions into database 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
9f3c04dfb5 Migrate prekeys into database 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
6239508b39 Clean file names for belt and suspenders 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
71c7ef5b5e Support for custom call ringtone selection and per-chat ringtones 2018-03-05 16:11:49 -08:00
Moxie Marlinspike
bebdbe2aaa Remove master secret requirement from SMS received job 
Fixes #7444
 2018-02-28 10:45:50 -08:00
Moxie Marlinspike
18aa202695 Really really delay SMS processing until sqlcipher migration completes 
Blocking the SMS job on the screen lock isn't enough, since then
the job races against the migration.

Fixes #7390
 2018-02-26 14:02:12 -08:00
Moxie Marlinspike
a0a9e412b4 Correctly lock screen when locked from conversation list 
Fixes #7441
 2018-02-26 10:47:41 -08:00
Moxie Marlinspike
028c6edd8a Manually calculate attachment offsets 
The CipherInputStream skip() method is pretty non-functional

Fixes #7438
 2018-02-24 11:09:26 -08:00
Moxie Marlinspike
7318236286 Delay processing SMS messages until after sqlcipher migration 
When screen lock passphrase is enabled

Fixes #7390
 2018-02-21 18:49:52 -08:00
Moxie Marlinspike
0bbe83f8f2 Don't copy column to sqlcipher db if it doesn't exist there 
Fixes #7386
 2018-02-05 17:32:24 -08:00
Moxie Marlinspike
2b651ee323 Prevent NPE in #7375 2018-02-05 12:08:40 -08:00
Moxie Marlinspike
9d5d43cf3a Wait to process messages until after migration when screenlocked 
Fixes #7390
 2018-02-04 11:26:02 -08:00
Moxie Marlinspike
93ca2ad8cf Fix new conversation activity crash 2018-02-01 19:36:09 -08:00
Moxie Marlinspike
3633d805c8 More MasterSecret cleanup 2018-02-01 19:22:48 -08:00
Moxie Marlinspike
59092e2ec0 No need for an encrypted serializer any longer 2018-02-01 18:33:12 -08:00
Moxie Marlinspike
e6a069af6d Remove unnecessary body model 2018-02-01 18:29:09 -08:00
Moxie Marlinspike
23aee53c7d Add determinte progress and foreground service for sqlcipher migration 2018-02-01 16:01:24 -08:00
Moxie Marlinspike
bdd4b456c4 Have stream generate random value 2018-02-01 15:42:28 -08:00
Moxie Marlinspike
7b353a94d8 Trigger DB schema change on application DB update Activity 2018-01-31 17:49:08 -08:00
Moxie Marlinspike
5496f5baac Deprecate encrypted storage DB types 2018-01-30 17:45:12 -08:00
Moxie Marlinspike
f36b296e2e Migrate from SQLite and ciphertext blobs to SQLCipher + KeyStore 2018-01-30 17:27:05 -08:00
Moxie Marlinspike
799b9c2074 Adjust media preview viewpager swipe direction for rtl 2018-01-23 13:43:37 -08:00
Moxie Marlinspike
14644077e7 Change media preview swipe direction based on entry point 
Fixes #7354
 2018-01-23 12:52:24 -08:00
Moxie Marlinspike
24e6605024 Reverse media order in ViewPager 
Fixes #7354
 2018-01-22 09:32:27 -08:00
Moxie Marlinspike
bc64230a65 Switch to HackyViewPager for media preview 
Fixes #7344
Fixes #7335
 2018-01-18 10:16:35 -08:00
Moxie Marlinspike
763fa0dd21 Catch exception on image decoding error in notification 2018-01-18 10:11:33 -08:00
Moxie Marlinspike
e60715587f Update service lib to 2.7.0 2018-01-18 10:01:41 -08:00
Moxie Marlinspike
95ebae5d5f Support onStop/onStart media display in the correct position 
Fixes #7330
Fixes #7329
 2018-01-16 12:06:55 -08:00
Moxie Marlinspike
fe02b3f8d3 Catch exception from misconfigured MMSC 
Fixes #7339
 2018-01-16 11:32:51 -08:00
Moxie Marlinspike
94e2b9e66e Make video player in media player control a view stub 2018-01-16 11:21:58 -08:00
Moxie Marlinspike
b307980d8c Perform a contact sync with every directory refresh 2018-01-04 11:56:55 -08:00
Moxie Marlinspike
8bba45f396 Add swipe gestures to media view 
Fixes #2355
Closes #6632
 2018-01-04 11:11:49 -08:00
Moxie Marlinspike
34424a9b3e Fix crash when signal messages disabled in group conversation 
Fixes #6419
Closes #6803
 2017-12-25 15:57:33 -08:00
Moxie Marlinspike
a798f97aa3 Update to webrtc M64 2017-12-21 16:37:07 -08:00
Moxie Marlinspike
6dcec7c2c5 Fix service calls that won't foreground 2017-12-20 11:27:57 -08:00
Moxie Marlinspike
512dc19471 Fix dynamic permissions problem for MMS messages 2017-12-20 11:21:00 -08:00
Moxie Marlinspike
425d6b8adf Fix crash for dynamic permissions + background directory load 2017-12-20 11:10:12 -08:00
Moxie Marlinspike
4acedd2a4b Fix notification ringtone problems 
Default ringtone was often showing up as a call tone

Silent wasn't working correctly globally
 2017-12-19 14:42:00 -08:00
Moxie Marlinspike
d782d3006b Per-recipient ringtones can't be file based 2017-12-19 11:01:55 -08:00
Moxie Marlinspike
9c77ffc2a4 The webrtc busy state could be idle, but system dialer connected 2017-12-19 10:57:34 -08:00
Moxie Marlinspike
0ec1ae4ed3 Request needed permissions for thread search 2017-12-19 10:54:06 -08:00
Moxie Marlinspike
f22186e6f4 Debounce call screen answer button 
Fixes #7274
 2017-12-15 15:27:23 -08:00
Moxie Marlinspike
4de14a5dc1 Only use startForegroundService for initial service construction 2017-12-15 09:45:00 -08:00
Moxie Marlinspike
f72e35bf42 Fix typo that requests SMS permission for media/group message 
Fixes #7271
 2017-12-13 10:29:19 -08:00
Moxie Marlinspike
303b98b7c2 Register and unregister receiver with same context 
Fixes #7267
 2017-12-12 11:16:40 -08:00
Moxie Marlinspike
d5215b3593 Avoid potentially unregistering bluetooth twice 2017-12-11 09:52:03 -08:00
Moxie Marlinspike
f315b1db80 Make save attachment task toast location instead of snackbar 2017-12-08 15:21:46 -08:00
Moxie Marlinspike
f100137e0f Synchronize and copy Recipient.getParticipants 2017-12-08 14:38:01 -08:00
Moxie Marlinspike
37092eee01 Externalize strings 2017-12-08 14:36:56 -08:00
Moxie Marlinspike
261d187567 Don't perform multi-device contact update without contact perms 2017-12-08 14:36:36 -08:00
Moxie Marlinspike
b58c87a56b Only notify when address is in contacts 2017-12-07 11:53:17 -08:00
Moxie Marlinspike
23e9b3a61e Fix colors in all images toolbar 
Fixes #7242
 2017-12-05 12:07:37 -08:00
Moxie Marlinspike
06e0d7d72d Appease the linter 2017-12-05 11:52:03 -08:00
Moxie Marlinspike
27e11e9627 Make sure we have SEND_SMS permission before sending an SMS 
Fixes #7246
 2017-12-05 11:35:15 -08:00
Moxie Marlinspike
8686691a5a Fix missing recipient calculation for system contact 
Fixes #7244
 2017-12-05 10:27:34 -08:00
Moxie Marlinspike
8b3a3d163f Don't check subscription info on dual sim devices wihout permission 
Fixes #7239
 2017-12-02 12:23:14 -08:00
Moxie Marlinspike
02c422cb26 Some old group avatar IDs can be 0 
Fixes #7235
 2017-12-01 13:56:56 -08:00
Moxie Marlinspike
3523952ef9 As of 'N' we can no longer offer external ringtone selection 
1. Replace custom ringtone picker with system Intent, since we
   don't need it anymore. Fixes #7174

2. Make sure 'silent' ringtone selection is stored appropriately
   Fixes #7115 Closes #7141

3. Replace any existing file:// notification URIs with the system
   default Fixes #7234
 2017-12-01 12:55:24 -08:00
Moxie Marlinspike
4cb2ac7b27 Use FileProvider for external camera capture Uri on L+ 
Fixes #7237
 2017-12-01 11:06:37 -08:00
Moxie Marlinspike
8cd5ff5fa1 Mark directory retrieved on registered update 2017-11-30 13:30:15 -08:00
Moxie Marlinspike
6f10de5e30 Fix trying to launch a dialog from an application context 2017-11-30 13:05:16 -08:00
Moxie Marlinspike
c58d5c32bb Remove request for permission that doesn't exist < O 2017-11-30 13:04:11 -08:00
Moxie Marlinspike
acfc9d75e0 Use startForegroundService instead of startService on Android 8 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
d9ab1a93f8 Fix problem with creating group and empty avatar 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
c2dbb34b25 Extract string resource 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
ed508a8def Be more explicit with mastersecret passing 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
d5cb804f90 Switch from PACKAGE_REPLACED to MY_PACKAGE_REPLACED 
As part of the Oreo 'no more implicit intents' thing
 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
c8104a91a4 Remove dead code 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
4c8e259b56 Update compileSdk to 27 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
7a5846a6d4 Move more system contact info into recipient database 
1) Move contact URI, contact photo URI, and custom label
   into recipient database, so there are no longer any
   contact DB queries during Recipient object loading.

2) Use a SoftHashMap so that any referenced Recipient objects
   can't get kicked out of the cache.

3) Don't load Recipient objects through the provider during sync.
   This was a super expensive thing to do, and blew up the cache.

4) Only apply changes to Recipient objects during sync if they
   are in the cache. Otherwise, there should be no outstanding
   references, and the changes are fine going exclusively to
   the DB.
 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
64c8b4b2ef Support for selective permissions 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
99a26e2bcc Don't invalidate entire recipient cache when contact data changes 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
f855e161d9 Ensure notifications for new users won't be generated first fetch 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
66e1be1aeb Don't invalidate entire recipient cache when contact data changes 2017-11-30 10:26:41 -08:00
Moxie Marlinspike
73c75a9b34 Don't delete GCM id during registration if it never existed 
Fixes #7229
 2017-11-28 14:33:22 -08:00
Moxie Marlinspike
a350106f7d Don't check DB workaround if push group 
Fixes #7225
 2017-11-27 09:44:50 -08:00
Moxie Marlinspike
7eb089c9de Temporary fix for Signal contact displaying as SMS for N seconds 
The whole recipient pipeline needs to be changed more subsantially,
particularly given the way directory discovery works with it. This
will temporarily solve the problem though.
 2017-11-25 09:50:36 -08:00
Moxie Marlinspike
ba5febd222 Fix some emoji rendering issues related to obsolete images 
1) The "obsolete" images like "swimmer" need to alias to
"man_swimming" so that they can be rendered correctly.

2) There are a whole bunch of emoji-data elements
(like white_frowning_face) that have "unified" code points which
have changed to include a "terminator."

Fixes #7212
 2017-11-20 19:11:26 -08:00
Moxie Marlinspike
c1b2098bd9 Fix race condition that would display end call button over answer 
Fixes #7211
 2017-11-20 11:17:50 -08:00
Moxie Marlinspike
d3c72fa697 Avoid green background on item below archived conversation list item 2017-11-19 18:34:03 -08:00
Moxie Marlinspike
58f1e68961 Update emoji 
Fixes #6637
Fixes #7206
 2017-11-19 18:11:25 -08:00
Moxie Marlinspike
be6a51b123 Hide photo/mic options on whitespace entry 
Fixes #7204
 2017-11-19 16:53:12 -08:00
Moxie Marlinspike
08c72ed874 Don't show group ID in recent contact selection list 
Fixes #7201
 2017-11-19 16:46:12 -08:00
Moxie Marlinspike
86bd2351bc Replace answer/decline button and action for incoming calls 
Fixes #7199
 2017-11-19 16:32:22 -08:00
Moxie Marlinspike
cf81815bf6 Add recent chats to top of share list 2017-11-16 15:21:46 -08:00
Moxie Marlinspike
c5a9f27c31 Catch some activity not found exceptions for expired builds 2017-11-16 12:31:42 -08:00
Moxie Marlinspike
de812d3f0f Extract string resources 2017-11-16 12:28:29 -08:00
Moxie Marlinspike
2da47c3bb3 Fix share list crash and update look/feel 
Fixes #7195
 2017-11-16 12:22:09 -08:00
Moxie Marlinspike
e37c06c563 Show dialog if another device registered with same number 2017-11-15 16:29:00 -08:00
Moxie Marlinspike
909c0c544c Make sure thread preview text is to left of unread indicator 2017-11-15 15:49:45 -08:00
Moxie Marlinspike
b42e91134b Remove inset divider from last recyclerview element 2017-11-14 12:09:19 -08:00
Moxie Marlinspike
682abbf66b Add unread count to synthesized cursor 2017-11-14 11:47:15 -08:00
Moxie Marlinspike
ad9a995ffa Correctly display cropped profile image 
Fixes #7191
 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
21ddc1dbba Fix profile crash 
Fixes #7192
 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
534dec282f Brighten light theme 
1) Brighten background color

2) Add unread indicator in conversation list

3) Eliminate some conversation list overdraw
 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
03573df00f Add inset dividers in conversation list 
Closes #7074
 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
40caf20188 Make sure nav drawable is mutable before tinting 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
405ee3b741 Improve search bar visibility 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
9a75f49aa1 Add an empty state for search 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
9c50057909 Add an empty state for archived 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
bb878f8a67 Adjust Conversation List toolbar to match RecyclerView alignment 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
3097c2855e Add empty state for conversation list 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
90ff0e58b0 Update registration flow 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
e56e55363d Add some debug logging 2017-11-14 10:49:54 -08:00
Moxie Marlinspike
50ae2dd1b8 Fix multi device race condition 
Fixes #7175
 2017-11-12 13:54:37 -08:00
Moxie Marlinspike
ad6ae10a41 Fix scaling issue when loading emoji sprites 
Fixes #5973
// FREEBIE
 2017-11-06 08:11:36 -08:00
Moxie Marlinspike
bcdf3bf311 Fix for scribbles on Android 8 
Fixes #6998
// FREEBIE
 2017-11-03 11:32:18 -07:00
Moxie Marlinspike
3e9bfcb3fd Delete "external" persistent blobs on cleanup 
Also switch external persistent blog directory to cache

Fixes #6909
// FREEBIE
 2017-11-03 10:53:37 -07:00
Moxie Marlinspike
3ed82c1726 Glide -> glideRequests in GiphyAdapter 
// FREEBIE
 2017-11-02 18:12:06 -07:00
Christian Ascheberg
69e656af76 Add back a way to access quick contact from conversation 
Closes #7051
// FREEBIE
 2017-11-01 15:56:46 -07:00
Greg Cooksey
23a23ebd72 CreateProfileActivity uses DynamicTheme 
Fixes #6981
Closes #6997
// FREEBIE
 2017-11-01 15:56:46 -07:00
Christian Ascheberg
fdd070c1dd Do not show sent checkmark for verification status changes 
Fixes #6743
Closes #7041
// FREEBIE
 2017-11-01 15:56:46 -07:00
Nicholas Rizzio
0ab9b56a18 Add a space between group member names 
Fixes #7059
Closes #7060
// FREEBIE
 2017-11-01 15:56:46 -07:00
haffenloher
3df9112cf8 Fix synced sent media messages expiring too fast 
Fixes #6928
Closes #7135
 2017-11-01 15:56:46 -07:00
Moxie Marlinspike
9a8d058051 Update to glide 4.3.0 
// FREEBIE
 2017-11-01 15:56:44 -07:00
Moxie Marlinspike
6d88710a88 Update to libsignal-service 2.6.11 
// FREEBIE
 2017-11-01 15:56:31 -07:00
Moxie Marlinspike
e056bd1aa2 Update giphy connectivity strategy for glide 
// FREEBIE
 2017-11-01 15:51:38 -07:00
Moxie Marlinspike
e7937fd424 Cache external address formatter for better performance 
// FREEBIE
 2017-10-11 17:47:12 -07:00
Moxie Marlinspike
b80408bcb4 Use Glide for all contact photo caching 
// FREEBIE
 2017-10-11 17:47:12 -07:00
Moxie Marlinspike
10f224ede5 Update to glide 4.x 
// FREEBIE
 2017-10-11 17:47:12 -07:00
Moxie Marlinspike
17dd681dc8 Run all AsyncTasks on thread pool executor 
Should Fix #7002
 2017-10-23 13:03:32 -07:00
Moxie Marlinspike
263846bba0 Fix mms group migration for those who haven't encountered it yet 
Fixes #7091
// FREEBIE
 2017-10-23 09:52:34 -07:00
Moxie Marlinspike
7a8bd0597a Correctly load group avatars in RecipientPreferencesActivity 
Fixes #7102
// FREEBIE
 2017-10-16 10:16:15 -07:00
Moxie Marlinspike
5711adb2c9 Fix profile out of memory errors on low mem devices 
Fixes #7094
// FREEBIE
 2017-10-15 10:00:03 -07:00
Moxie Marlinspike
4bd3094bad Fix problem where recycled group avatar icons have stale listener 
Fixes #7089
// FREEBIE
 2017-10-13 09:51:37 -07:00
Moxie Marlinspike
4e45d53bd9 Scroll on list post 
Fixes #7054

// FREEBIE
 2017-10-10 10:00:24 -07:00
Moxie Marlinspike
d40fea9423 Catch Glide exception when loading avatar image 
Workaround for #7016
// FREEIBE
 2017-10-10 09:18:00 -07:00
Moxie Marlinspike
c15d1a3bce Update pipe when injecting message sender 
// FREEBIE
 2017-10-10 09:14:53 -07:00
Moxie Marlinspike
655be5adf4 Fix RingtoneManager cursor crash on some devices 
Fixes #7055
// FREEBIE
 2017-10-08 18:46:09 -07:00
Moxie Marlinspike
445f3c234c Connect "mark all read" to sync and read receipts 
Fixes #7069
// FREEBIE
 2017-10-08 18:09:46 -07:00
Moxie Marlinspike
a382694b1f Don't hide keyboard when back arrow tapped in Conversation Activity 
Fixes #7065
// FREEBIE
 2017-10-08 17:44:18 -07:00
Moxie Marlinspike
12020a3f86 Fix vector drawable problems < Android 5.0 
Fixes #7056
// FREEBIE
 2017-10-08 17:42:45 -07:00
Moxie Marlinspike
9fa4ba126b Fix non-collapsing layout when scrolled from horiz recyclerview 
Fixes #7042
// FREEBIE
 2017-10-08 17:36:35 -07:00
Moxie Marlinspike
5a607918d2 Name message retrieval service thread 
// FREEBIE
 2017-10-08 11:34:24 -07:00
Moxie Marlinspike
d0570ef7cb Fix media preview crash 
Fixes #7050
// FREEBIE
 2017-10-05 17:20:28 -07:00
Moxie Marlinspike
ac282ccf70 Display contact color in background for generated avatars 
Fixes #7028
// FREEBIE
 2017-10-04 15:24:04 -07:00
Moxie Marlinspike
42f613e722 Be more explicit with running on main thread 
// FREEBIE
 2017-10-04 14:56:31 -07:00
Moxie Marlinspike
99b2149deb Fixed avatar icons not rendering in contact selection view 
// FREEBIE
 2017-10-04 14:47:29 -07:00
Moxie Marlinspike
5ad7e3b48a Make avatar in conversation activity tappable 
Fixes #7025
// FREEBIE
 2017-10-04 14:04:04 -07:00
Moxie Marlinspike
5270dad789 Fix screen security preference migration 
// FREEBIE
 2017-10-04 12:37:53 -07:00
Veeti Paananen
eb456ef2b0 Fix implicit locale string formatting bugs 
Depending on the phone language the default format may use Arabic
numerals, etc. when not desired.

Bug: fixes #7006
Closes #7040
 2017-10-04 11:36:43 -07:00
Moxie Marlinspike
9a876a3672 Show "you" in MediaPreviewActivity 
Fixes #7038
// FREEBIE
 2017-10-04 11:35:16 -07:00
Moxie Marlinspike
ba849bce2c Add support for incognito keyboard preference 
Closes #6985
// FREEBIE
 2017-10-03 18:57:23 -07:00
Moxie Marlinspike
5de89d4f26 Correctly disable preferences in group conversation preferences 
Fixes #7031
// FREEBIE
 2017-10-03 17:05:52 -07:00
Moxie Marlinspike
b7340cc356 Don't show voice notes in conversation documents overview 
Fixes #7029
// FREEBIE
 2017-10-03 16:43:31 -07:00
Moxie Marlinspike
9287b00317 Make conversation settings menu item work 
Fixes #7023
// FREEBIE
 2017-10-03 16:27:12 -07:00
Moxie Marlinspike
d7d6f38cb6 Enable censorship circumvention in Qatar 
// FREEBIE
 2017-10-03 14:08:41 -07:00
Moxie Marlinspike
b34eb08088 Fix look of default group photo in conversation preferences view 
Fixes #7022
// FREEBIE
 2017-10-03 14:01:02 -07:00
Moxie Marlinspike
a929bf91f1 Show profile name in call screen 
Fixes #7020
// FREEBIE
 2017-10-03 13:29:49 -07:00
Moxie Marlinspike
c09d2951b1 Fix preference compat crash 
Fixes #7018
// FREEBIE
 2017-10-03 10:43:06 -07:00
Moxie Marlinspike
2c1337b33e Make early receipts work in group messages 
For both conversation item view and message details view

// FREEBIE
 2017-10-02 14:54:55 -07:00
Moxie Marlinspike
856a4d2860 Process configuration request messages 
// FREEBIE
 2017-10-02 12:39:44 -07:00
Moxie Marlinspike
b3f0888a2e Synchronize read receipt configuration from splash screen 
// FREEBIE
 2017-10-02 12:15:45 -07:00
Moxie Marlinspike
182d571e1b Fix experience upgrade strings for notification 
// FREEBIE
 2017-10-02 10:45:43 -07:00
Moxie Marlinspike
e145875164 Fix json serialization for group message error 
Fixes #6919
// FREEBIE
 2017-10-02 10:35:49 -07:00
Moxie Marlinspike
4c2269175b Improve profile upload animation 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
893cf9c01d Add support for setting empty profile names 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
285947eb66 Show per-member delivery/read status on message info in groups 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
2b4064f3b7 Add splash screen for read receipts 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Brian St. Pierre
6e6bfaa932 set MMS default characterset to utf-8. 
Fixes #6374
Closes #6965
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
8d08f3969a Switch from secure indicator to insecure indicator 
Instead of cluttering Signal messages with a little padlock,
let's highlight the insecurity of SMS messages instead.

// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
8ce914a344 Refactor media overview activity to display documents 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
c6b2e785a5 Reorganize conversation media activity to have sticky headers 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
b47665aa44 Fix migration typo 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
d0e781ccb4 Sync read receipt configuration to sibling devices 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
e5e0bc2333 Reorganize preference widgets 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
4828a8a274 Add conversation media photo rail to recipient preferences 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
a1c276f70b Update to V7 PreferencesCompat library 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
cb9bc9659b Support for read receipts 
// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
65124fd1f2 Redesign conversation and conversation preferences layouts 
Remove avatars from conversation items unless in a group chat.

// FREEBIE
 2017-10-01 22:36:52 -07:00
Moxie Marlinspike
009c01fd7e Move experience upgrade after passphrase and registration 
// FREEBIE
 2017-09-25 09:32:44 -07:00
Moxie Marlinspike
a39d9bf132 Fix for RTL layout detection crash on < API 17 
Fixes #6987
// FREEBIE
 2017-09-25 09:05:41 -07:00
Moxie Marlinspike
74779adc34 Use correct open helper for old directory database 
// FREEBIE
 2017-09-19 11:03:18 -07:00
Moxie Marlinspike
260383ac21 Fix problem with direct share 
Fixes #6968
// FREEBIE
 2017-09-15 10:36:33 -07:00
Moxie Marlinspike
b6aedd330e Disable signal messaging if unregistered 
Fixes #6963
// FREEBIE
 2017-09-14 16:46:12 -07:00
Moxie Marlinspike
5a0f671aa4 Fix not sending group info request messages 
Fixes #6962
// FREEBIE
 2017-09-13 17:19:59 -07:00
Moxie Marlinspike
b7109e9ebb Fix for NPE if MMS notification has no transaction ID 
// FREEBIE
 2017-09-13 16:38:02 -07:00
Moxie Marlinspike
93395c3ff4 Include own profile key in normal contact sync 
// FREEBIE
 2017-09-12 22:49:30 -07:00
Moxie Marlinspike
40d7826fb9 Fix <= KitKat bug that prompts for MMS configuration 
Fixes #6954
 2017-09-11 13:04:20 -07:00
Moxie Marlinspike
962944a974 Add some annotations 
// FREEBIE
 2017-09-10 11:21:51 -07:00
Moxie Marlinspike
08948fe05a Don't create groups for 1:1 MMS conversations 
Fixes #6947
// FREEBIE
 2017-09-10 11:13:53 -07:00
Moxie Marlinspike
f3d943270c Be more conservative with handlers and references 
Expiring message timers could end up leaking references and
executing work even after their conversation item was no longer
visible

Maybe fixes #6898

// FREEBIE
 2017-09-09 23:46:48 -07:00
Moxie Marlinspike
f335a65d32 Stop Thread.interrupt() from being called 
// FREEBIE
 2017-09-08 11:48:44 -07:00
Moxie Marlinspike
79a88f378b Avoid NPE if capture file isn't available 
// FREEBIE
 2017-09-08 11:38:07 -07:00
Moxie Marlinspike
afed60f870 Handle recipient modification callbacks on main thread 
// FREEBIE
 2017-09-08 11:36:09 -07:00
Moxie Marlinspike
989ea4042c MMS group includes the sender 
Fixes #6942
// FREEBIE
 2017-09-08 11:19:57 -07:00
Moxie Marlinspike
5173921ce0 Fix bad MMS group creation logic 
Fixes #6939
Fixes #6938

// FREEBIE
 2017-09-07 20:41:34 -07:00
Moxie Marlinspike
032eaa4389 Fix crash on conversation list search 
Fixes #6936
// FREEBIE
 2017-09-07 13:52:58 -07:00
Moxie Marlinspike
962fb60ffb Don't synchronize MMS groups to sibling devices 
Fixes #6934
// FREEBIE
 2017-09-07 11:12:57 -07:00
Moxie Marlinspike
6455c66a0b Fix bug that prevented selecting insecure SMS 
Fixes #6929

// FREEBIE
 2017-09-06 17:54:32 -07:00
Moxie Marlinspike
2890490ab4 Support cameras that don't return data intent 
Fixes #6926

// FREEBIE
 2017-09-06 16:16:01 -07:00
Moxie Marlinspike
bcff186b10 Add self to MMS groups when migrating 
Fixes #6925
// FREEBIE
 2017-09-06 16:08:20 -07:00
Moxie Marlinspike
967c374213 Display error when camera doesn't return image 
Partial #6926
// FREEBIE
 2017-09-06 16:03:08 -07:00
Moxie Marlinspike
e172b84603 Fix crash on displaying unknown contact header 
Fixes #6924

// FREEBIE
 2017-09-06 15:49:10 -07:00
Moxie Marlinspike
bdb67725c5 Add additional debug information for mysterious stack trace 
Related #6923

// FREEBIE
 2017-09-06 13:56:09 -07:00
Moxie Marlinspike
29b561fe41 Fix group conversation items glitching to use conversation recipient 
// FREEBIE
 2017-09-06 10:31:48 -07:00
Moxie Marlinspike
19be527370 Fix recursive experience upgrade activity problem 
// FREEBIE
 2017-09-06 00:29:49 -07:00
Moxie Marlinspike
efc4a5ab9d Fix problem with prefetched recipient details 
Don't use a cached recipient if we have a prefetched recipient
detail object and the cached recipient is still in progress
and without a name

// FREEBIE
 2017-09-06 00:11:11 -07:00
Moxie Marlinspike
7197d513a3 Add target for 'who can see this' profile link 
// FREEBIE
 2017-09-05 12:52:50 -07:00
Moxie Marlinspike
5cccea5846 Revert "Change default charset to UTF-8" 
This reverts commit 86eb14b7bbad2be6e23f36478b4f3d6a43d55dd7.
 2017-09-05 12:43:21 -07:00
Christian Bundy
86eb14b7bb Change default charset to UTF-8 
This resolves #6374 where the character set is set to
`CharacterSets.MIMENAME_ANY_CHARSET` but the character set being
 used is _actually_ UTF-8.

Fixes #6374
Closes #6892
 2017-09-04 14:58:25 -07:00
Moxie Marlinspike
2add02c62f Add splash screen for setting profiles 
// FREEBIE
 2017-09-03 19:45:43 -07:00
Moxie Marlinspike
3e3ae5f865 Adjust profile key sharing based on sync messages 
// FREEBIE
 2017-08-28 17:57:07 -07:00
jdaminato94
6945ecf81d Keep screen on when viewing a video 
Fixes #6642
Closes #6837

// FREEBIE
 2017-08-28 10:45:32 -07:00
Markus Brenneis
66062f200a Work around SmsMessage.calculateLength NPE on broken ROMs 
//FREEBIE
 2017-08-28 10:43:14 -07:00
marcoscezar
37a5622525 Display appropriate registration error msg w/ bad verification code 
Fixes #6551
 2017-08-28 10:38:35 -07:00
Moxie Marlinspike
d0cd2621ca Only process messages if a body is present 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
51c1e4485f Support for profile key syncing to sibling devices 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
beed9d8034 Add length limit feedback when setting profile name 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
638a9576f8 Add censorship circumvention endpoints for CDN 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
6bfe05323e Update recipient preference style 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
64ad9ec9dd Add group profile sharing logic 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
f17af19d09 Access all RecipientDatabase settings directly from Recipient 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
d1790dfe17 Rename RecipientPreferences -> RecipientSettings 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
8e6ca53023 Rename RecipientPreferencesDatabase -> RecipientDatabase 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
6924f0519e No need for a RecipientFactory any longer 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
6af836735b Remove unnecessary logging 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
1252b3ca00 Don't display unknown sender footer for group messages 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
1b2f52209d Display unknown sender footer for unknown senders 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
5942e93a33 Share profile key when initiating a conversation 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
c11f2eddf5 Display user profile information in settings activity 
Allow for editing

// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
df99deb480 Insert profile creation into registration flow, fix capture 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
e7c20499ec Display profile name in when appropriate 
Display in conversation list, conversation actionbar, group
messages, and group members list when address is not in system
contacts

// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
77a216b705 Support for retrieving and storing profile information 
Initial support for sharing profile keys

// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
1893047a78 Profile creation activity 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
da94fd5f9e Join group information into conversation list query 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
159fdb317f Store system contacts display name in recipient preferences db 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
f61c52aace Consolidate user "capability" enums to a single value 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
5a5e47f2df Move "directory" information into RecipientPreferencesDatabase 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
a02f223a96 Join recipient preferences into thread query for faster lookup 
// FREEBIE
 2017-08-28 10:30:50 -07:00
Moxie Marlinspike
375207f073 Switch MMS groups to use the group database infrastructure 
Eliminate the concept of 'Recipients' (plural). There is now just
a 'Recipient', which contains an Address that is either an individual
or a group ID.

MMS groups now exist as part of the group database, just like push
groups.

// FREEBIE
 2017-08-28 10:30:50 -07:00
mcloo
60eaade6b0 Fix plaintext export XML name escaping 
Fixes #6830
Closes #6861
 2017-08-22 15:22:03 -07:00
Benedikt Constantin Radtke
54396a3a9c Fix group info request responses 
GroupRecords have a list of Addresses, not Strings.

Fixes #6881
Closes #6882
 2017-08-22 15:19:39 -07:00
Moxie Marlinspike
a80fe178ea Canonicalize addresses during import from system SMS database 
// FREEBIE
 2017-08-10 12:30:13 -07:00
Moxie Marlinspike
422b4c345b Catch IllegalArgumentException thrown internally on some devices 
// FREEBIE
 2017-08-10 12:17:05 -07:00
Moxie Marlinspike
47901e4198 Disallow alpha chars in country code field 
// FREEBIe
 2017-08-07 12:40:40 -07:00
Moxie Marlinspike
25a30d63a5 A blocked contact doesn't necessarily have to be a number 
// FREEBIE
 2017-08-07 12:27:34 -07:00
Moxie Marlinspike
c5a7d320f7 Don't query contacts DB if we have nothing to query 
// FREEBIE
 2017-08-04 09:28:20 -07:00
Moxie Marlinspike
8de9261081 MMS addresses can be email addresses 
Fixes #6853
// FREEBIE
 2017-08-04 09:22:58 -07:00
Moxie Marlinspike
cb4303ac23 Handle migration case where recipient_ids is completely empty 
No idea how a DB is in that state, but apparently it's possible

Fixes #6850
// FREEBIE
 2017-08-03 09:32:56 -07:00
Moxie Marlinspike
9a78615991 Switch regexp matcher to find() in order to handle alpha addresses 
Any address with an alpha character anywhere in it should be used
as-is.

Fixes #6849

// FREEBIE
 2017-08-03 09:24:08 -07:00
Moxie Marlinspike
7f46e99f9c Use SIM country code when registered number is unavailable 
Convert directory operations to Addresses

Fixes #6845
// FREEBIE
 2017-08-02 12:51:46 -07:00
Moxie Marlinspike
4838fade6c Fix typo 
// FREEBIE
 2017-08-02 11:15:58 -07:00
Moxie Marlinspike
1e934f6146 Escape addresess in thread and recipient pref migrations 
For clients that have not yet migrated

// FREEBIE
 2017-08-02 11:08:38 -07:00
Moxie Marlinspike
aacf50316d Escape addresses in thread, recipient pref, and group databases 
Fixes #6847
// FREEBIE
 2017-08-02 11:04:10 -07:00
Moxie Marlinspike
24c48afd2e Fix typo in migration constraint resolution 
Fixes #6846

// FREEBIE
 2017-08-02 08:02:15 -07:00