Commit Graph

2257 Commits

Author SHA1 Message Date
Moxie Marlinspike
b42e91134b Remove inset divider from last recyclerview element 2017-11-14 12:09:19 -08:00
Moxie Marlinspike
682abbf66b Add unread count to synthesized cursor 2017-11-14 11:47:15 -08:00
Moxie Marlinspike
ad9a995ffa Correctly display cropped profile image
Fixes #7191
2017-11-14 10:50:17 -08:00
Moxie Marlinspike
21ddc1dbba Fix profile crash
Fixes #7192
2017-11-14 10:50:17 -08:00
Moxie Marlinspike
534dec282f Brighten light theme
1) Brighten background color

2) Add unread indicator in conversation list

3) Eliminate some conversation list overdraw
2017-11-14 10:50:17 -08:00
Moxie Marlinspike
03573df00f Add inset dividers in conversation list
Closes #7074
2017-11-14 10:50:17 -08:00
Moxie Marlinspike
40caf20188 Make sure nav drawable is mutable before tinting 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
405ee3b741 Improve search bar visibility 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
9a75f49aa1 Add an empty state for search 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
9c50057909 Add an empty state for archived 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
bb878f8a67 Adjust Conversation List toolbar to match RecyclerView alignment 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
3097c2855e Add empty state for conversation list 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
90ff0e58b0 Update registration flow 2017-11-14 10:50:17 -08:00
Moxie Marlinspike
e56e55363d Add some debug logging 2017-11-14 10:49:54 -08:00
Moxie Marlinspike
50ae2dd1b8 Fix multi device race condition
Fixes #7175
2017-11-12 13:54:37 -08:00
Moxie Marlinspike
ad6ae10a41 Fix scaling issue when loading emoji sprites
Fixes #5973
// FREEBIE
2017-11-06 08:11:36 -08:00
Moxie Marlinspike
bcdf3bf311 Fix for scribbles on Android 8
Fixes #6998
// FREEBIE
2017-11-03 11:32:18 -07:00
Moxie Marlinspike
3e9bfcb3fd Delete "external" persistent blobs on cleanup
Also switch external persistent blog directory to cache

Fixes #6909
// FREEBIE
2017-11-03 10:53:37 -07:00
Moxie Marlinspike
3ed82c1726 Glide -> glideRequests in GiphyAdapter
// FREEBIE
2017-11-02 18:12:06 -07:00
Christian Ascheberg
69e656af76 Add back a way to access quick contact from conversation
Closes #7051
// FREEBIE
2017-11-01 15:56:46 -07:00
Greg Cooksey
23a23ebd72 CreateProfileActivity uses DynamicTheme
Fixes #6981
Closes #6997
// FREEBIE
2017-11-01 15:56:46 -07:00
Christian Ascheberg
fdd070c1dd Do not show sent checkmark for verification status changes
Fixes #6743
Closes #7041
// FREEBIE
2017-11-01 15:56:46 -07:00
Nicholas Rizzio
0ab9b56a18 Add a space between group member names
Fixes #7059
Closes #7060
// FREEBIE
2017-11-01 15:56:46 -07:00
haffenloher
3df9112cf8 Fix synced sent media messages expiring too fast
Fixes #6928
Closes #7135
2017-11-01 15:56:46 -07:00
Moxie Marlinspike
9a8d058051 Update to glide 4.3.0
// FREEBIE
2017-11-01 15:56:44 -07:00
Moxie Marlinspike
6d88710a88 Update to libsignal-service 2.6.11
// FREEBIE
2017-11-01 15:56:31 -07:00
Moxie Marlinspike
e056bd1aa2 Update giphy connectivity strategy for glide
// FREEBIE
2017-11-01 15:51:38 -07:00
Moxie Marlinspike
e7937fd424 Cache external address formatter for better performance
// FREEBIE
2017-10-11 17:47:12 -07:00
Moxie Marlinspike
b80408bcb4 Use Glide for all contact photo caching
// FREEBIE
2017-10-11 17:47:12 -07:00
Moxie Marlinspike
10f224ede5 Update to glide 4.x
// FREEBIE
2017-10-11 17:47:12 -07:00
Moxie Marlinspike
17dd681dc8 Run all AsyncTasks on thread pool executor
Should Fix #7002
2017-10-23 13:03:32 -07:00
Moxie Marlinspike
263846bba0 Fix mms group migration for those who haven't encountered it yet
Fixes #7091
// FREEBIE
2017-10-23 09:52:34 -07:00
Moxie Marlinspike
7a8bd0597a Correctly load group avatars in RecipientPreferencesActivity
Fixes #7102
// FREEBIE
2017-10-16 10:16:15 -07:00
Moxie Marlinspike
5711adb2c9 Fix profile out of memory errors on low mem devices
Fixes #7094
// FREEBIE
2017-10-15 10:00:03 -07:00
Moxie Marlinspike
4bd3094bad Fix problem where recycled group avatar icons have stale listener
Fixes #7089
// FREEBIE
2017-10-13 09:51:37 -07:00
Moxie Marlinspike
4e45d53bd9 Scroll on list post
Fixes #7054

// FREEBIE
2017-10-10 10:00:24 -07:00
Moxie Marlinspike
d40fea9423 Catch Glide exception when loading avatar image
Workaround for #7016
// FREEIBE
2017-10-10 09:18:00 -07:00
Moxie Marlinspike
c15d1a3bce Update pipe when injecting message sender
// FREEBIE
2017-10-10 09:14:53 -07:00
Moxie Marlinspike
655be5adf4 Fix RingtoneManager cursor crash on some devices
Fixes #7055
// FREEBIE
2017-10-08 18:46:09 -07:00
Moxie Marlinspike
445f3c234c Connect "mark all read" to sync and read receipts
Fixes #7069
// FREEBIE
2017-10-08 18:09:46 -07:00
Moxie Marlinspike
a382694b1f Don't hide keyboard when back arrow tapped in Conversation Activity
Fixes #7065
// FREEBIE
2017-10-08 17:44:18 -07:00
Moxie Marlinspike
12020a3f86 Fix vector drawable problems < Android 5.0
Fixes #7056
// FREEBIE
2017-10-08 17:42:45 -07:00
Moxie Marlinspike
9fa4ba126b Fix non-collapsing layout when scrolled from horiz recyclerview
Fixes #7042
// FREEBIE
2017-10-08 17:36:35 -07:00
Moxie Marlinspike
5a607918d2 Name message retrieval service thread
// FREEBIE
2017-10-08 11:34:24 -07:00
Moxie Marlinspike
d0570ef7cb Fix media preview crash
Fixes #7050
// FREEBIE
2017-10-05 17:20:28 -07:00
Moxie Marlinspike
ac282ccf70 Display contact color in background for generated avatars
Fixes #7028
// FREEBIE
2017-10-04 15:24:04 -07:00
Moxie Marlinspike
42f613e722 Be more explicit with running on main thread
// FREEBIE
2017-10-04 14:56:31 -07:00
Moxie Marlinspike
99b2149deb Fixed avatar icons not rendering in contact selection view
// FREEBIE
2017-10-04 14:47:29 -07:00
Moxie Marlinspike
5ad7e3b48a Make avatar in conversation activity tappable
Fixes #7025
// FREEBIE
2017-10-04 14:04:04 -07:00
Moxie Marlinspike
5270dad789 Fix screen security preference migration
// FREEBIE
2017-10-04 12:37:53 -07:00
Veeti Paananen
eb456ef2b0 Fix implicit locale string formatting bugs
Depending on the phone language the default format may use Arabic
numerals, etc. when not desired.

Bug: fixes #7006
Closes #7040
2017-10-04 11:36:43 -07:00
Moxie Marlinspike
9a876a3672 Show "you" in MediaPreviewActivity
Fixes #7038
// FREEBIE
2017-10-04 11:35:16 -07:00
Moxie Marlinspike
ba849bce2c Add support for incognito keyboard preference
Closes #6985
// FREEBIE
2017-10-03 18:57:23 -07:00
Moxie Marlinspike
5de89d4f26 Correctly disable preferences in group conversation preferences
Fixes #7031
// FREEBIE
2017-10-03 17:05:52 -07:00
Moxie Marlinspike
b7340cc356 Don't show voice notes in conversation documents overview
Fixes #7029
// FREEBIE
2017-10-03 16:43:31 -07:00
Moxie Marlinspike
9287b00317 Make conversation settings menu item work
Fixes #7023
// FREEBIE
2017-10-03 16:27:12 -07:00
Moxie Marlinspike
d7d6f38cb6 Enable censorship circumvention in Qatar
// FREEBIE
2017-10-03 14:08:41 -07:00
Moxie Marlinspike
b34eb08088 Fix look of default group photo in conversation preferences view
Fixes #7022
// FREEBIE
2017-10-03 14:01:02 -07:00
Moxie Marlinspike
a929bf91f1 Show profile name in call screen
Fixes #7020
// FREEBIE
2017-10-03 13:29:49 -07:00
Moxie Marlinspike
c09d2951b1 Fix preference compat crash
Fixes #7018
// FREEBIE
2017-10-03 10:43:06 -07:00
Moxie Marlinspike
2c1337b33e Make early receipts work in group messages
For both conversation item view and message details view

// FREEBIE
2017-10-02 14:54:55 -07:00
Moxie Marlinspike
856a4d2860 Process configuration request messages
// FREEBIE
2017-10-02 12:39:44 -07:00
Moxie Marlinspike
b3f0888a2e Synchronize read receipt configuration from splash screen
// FREEBIE
2017-10-02 12:15:45 -07:00
Moxie Marlinspike
182d571e1b Fix experience upgrade strings for notification
// FREEBIE
2017-10-02 10:45:43 -07:00
Moxie Marlinspike
e145875164 Fix json serialization for group message error
Fixes #6919
// FREEBIE
2017-10-02 10:35:49 -07:00
Moxie Marlinspike
4c2269175b Improve profile upload animation
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
893cf9c01d Add support for setting empty profile names
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
285947eb66 Show per-member delivery/read status on message info in groups
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
2b4064f3b7 Add splash screen for read receipts
// FREEBIE
2017-10-01 22:36:52 -07:00
Brian St. Pierre
6e6bfaa932 set MMS default characterset to utf-8.
Fixes #6374
Closes #6965
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
8d08f3969a Switch from secure indicator to insecure indicator
Instead of cluttering Signal messages with a little padlock,
let's highlight the insecurity of SMS messages instead.

// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
8ce914a344 Refactor media overview activity to display documents
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
c6b2e785a5 Reorganize conversation media activity to have sticky headers
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
b47665aa44 Fix migration typo
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
d0e781ccb4 Sync read receipt configuration to sibling devices
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
e5e0bc2333 Reorganize preference widgets
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
4828a8a274 Add conversation media photo rail to recipient preferences
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
a1c276f70b Update to V7 PreferencesCompat library
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
cb9bc9659b Support for read receipts
// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
65124fd1f2 Redesign conversation and conversation preferences layouts
Remove avatars from conversation items unless in a group chat.

// FREEBIE
2017-10-01 22:36:52 -07:00
Moxie Marlinspike
009c01fd7e Move experience upgrade after passphrase and registration
// FREEBIE
2017-09-25 09:32:44 -07:00
Moxie Marlinspike
a39d9bf132 Fix for RTL layout detection crash on < API 17
Fixes #6987
// FREEBIE
2017-09-25 09:05:41 -07:00
Moxie Marlinspike
74779adc34 Use correct open helper for old directory database
// FREEBIE
2017-09-19 11:03:18 -07:00
Moxie Marlinspike
260383ac21 Fix problem with direct share
Fixes #6968
// FREEBIE
2017-09-15 10:36:33 -07:00
Moxie Marlinspike
b6aedd330e Disable signal messaging if unregistered
Fixes #6963
// FREEBIE
2017-09-14 16:46:12 -07:00
Moxie Marlinspike
5a0f671aa4 Fix not sending group info request messages
Fixes #6962
// FREEBIE
2017-09-13 17:19:59 -07:00
Moxie Marlinspike
b7109e9ebb Fix for NPE if MMS notification has no transaction ID
// FREEBIE
2017-09-13 16:38:02 -07:00
Moxie Marlinspike
93395c3ff4 Include own profile key in normal contact sync
// FREEBIE
2017-09-12 22:49:30 -07:00
Moxie Marlinspike
40d7826fb9 Fix <= KitKat bug that prompts for MMS configuration
Fixes #6954
2017-09-11 13:04:20 -07:00
Moxie Marlinspike
962944a974 Add some annotations
// FREEBIE
2017-09-10 11:21:51 -07:00
Moxie Marlinspike
08948fe05a Don't create groups for 1:1 MMS conversations
Fixes #6947
// FREEBIE
2017-09-10 11:13:53 -07:00
Moxie Marlinspike
f3d943270c Be more conservative with handlers and references
Expiring message timers could end up leaking references and
executing work even after their conversation item was no longer
visible

Maybe fixes #6898

// FREEBIE
2017-09-09 23:46:48 -07:00
Moxie Marlinspike
f335a65d32 Stop Thread.interrupt() from being called
// FREEBIE
2017-09-08 11:48:44 -07:00
Moxie Marlinspike
79a88f378b Avoid NPE if capture file isn't available
// FREEBIE
2017-09-08 11:38:07 -07:00
Moxie Marlinspike
afed60f870 Handle recipient modification callbacks on main thread
// FREEBIE
2017-09-08 11:36:09 -07:00
Moxie Marlinspike
989ea4042c MMS group includes the sender
Fixes #6942
// FREEBIE
2017-09-08 11:19:57 -07:00
Moxie Marlinspike
5173921ce0 Fix bad MMS group creation logic
Fixes #6939
Fixes #6938

// FREEBIE
2017-09-07 20:41:34 -07:00
Moxie Marlinspike
032eaa4389 Fix crash on conversation list search
Fixes #6936
// FREEBIE
2017-09-07 13:52:58 -07:00
Moxie Marlinspike
962fb60ffb Don't synchronize MMS groups to sibling devices
Fixes #6934
// FREEBIE
2017-09-07 11:12:57 -07:00
Moxie Marlinspike
6455c66a0b Fix bug that prevented selecting insecure SMS
Fixes #6929

// FREEBIE
2017-09-06 17:54:32 -07:00
Moxie Marlinspike
2890490ab4 Support cameras that don't return data intent
Fixes #6926

// FREEBIE
2017-09-06 16:16:01 -07:00
Moxie Marlinspike
bcff186b10 Add self to MMS groups when migrating
Fixes #6925
// FREEBIE
2017-09-06 16:08:20 -07:00
Moxie Marlinspike
967c374213 Display error when camera doesn't return image
Partial #6926
// FREEBIE
2017-09-06 16:03:08 -07:00
Moxie Marlinspike
e172b84603 Fix crash on displaying unknown contact header
Fixes #6924

// FREEBIE
2017-09-06 15:49:10 -07:00
Moxie Marlinspike
bdb67725c5 Add additional debug information for mysterious stack trace
Related #6923

// FREEBIE
2017-09-06 13:56:09 -07:00
Moxie Marlinspike
29b561fe41 Fix group conversation items glitching to use conversation recipient
// FREEBIE
2017-09-06 10:31:48 -07:00
Moxie Marlinspike
19be527370 Fix recursive experience upgrade activity problem
// FREEBIE
2017-09-06 00:29:49 -07:00
Moxie Marlinspike
efc4a5ab9d Fix problem with prefetched recipient details
Don't use a cached recipient if we have a prefetched recipient
detail object and the cached recipient is still in progress
and without a name

// FREEBIE
2017-09-06 00:11:11 -07:00
Moxie Marlinspike
7197d513a3 Add target for 'who can see this' profile link
// FREEBIE
2017-09-05 12:52:50 -07:00
Moxie Marlinspike
5cccea5846 Revert "Change default charset to UTF-8"
This reverts commit 86eb14b7bb.
2017-09-05 12:43:21 -07:00
Christian Bundy
86eb14b7bb Change default charset to UTF-8
This resolves #6374 where the character set is set to
`CharacterSets.MIMENAME_ANY_CHARSET` but the character set being
 used is _actually_ UTF-8.

Fixes #6374
Closes #6892
2017-09-04 14:58:25 -07:00
Moxie Marlinspike
2add02c62f Add splash screen for setting profiles
// FREEBIE
2017-09-03 19:45:43 -07:00
Moxie Marlinspike
3e3ae5f865 Adjust profile key sharing based on sync messages
// FREEBIE
2017-08-28 17:57:07 -07:00
jdaminato94
6945ecf81d Keep screen on when viewing a video
Fixes #6642
Closes #6837

// FREEBIE
2017-08-28 10:45:32 -07:00
Markus Brenneis
66062f200a Work around SmsMessage.calculateLength NPE on broken ROMs
//FREEBIE
2017-08-28 10:43:14 -07:00
marcoscezar
37a5622525 Display appropriate registration error msg w/ bad verification code
Fixes #6551
2017-08-28 10:38:35 -07:00
Moxie Marlinspike
d0cd2621ca Only process messages if a body is present
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
51c1e4485f Support for profile key syncing to sibling devices
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
beed9d8034 Add length limit feedback when setting profile name
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
638a9576f8 Add censorship circumvention endpoints for CDN
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
6bfe05323e Update recipient preference style
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
64ad9ec9dd Add group profile sharing logic
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
f17af19d09 Access all RecipientDatabase settings directly from Recipient
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
d1790dfe17 Rename RecipientPreferences -> RecipientSettings
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
8e6ca53023 Rename RecipientPreferencesDatabase -> RecipientDatabase
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
6924f0519e No need for a RecipientFactory any longer
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
6af836735b Remove unnecessary logging
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
1252b3ca00 Don't display unknown sender footer for group messages
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
1b2f52209d Display unknown sender footer for unknown senders
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
5942e93a33 Share profile key when initiating a conversation
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
c11f2eddf5 Display user profile information in settings activity
Allow for editing

// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
df99deb480 Insert profile creation into registration flow, fix capture
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
e7c20499ec Display profile name in when appropriate
Display in conversation list, conversation actionbar, group
messages, and group members list when address is not in system
contacts

// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
77a216b705 Support for retrieving and storing profile information
Initial support for sharing profile keys

// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
1893047a78 Profile creation activity
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
da94fd5f9e Join group information into conversation list query
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
159fdb317f Store system contacts display name in recipient preferences db
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
f61c52aace Consolidate user "capability" enums to a single value
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
5a5e47f2df Move "directory" information into RecipientPreferencesDatabase
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
a02f223a96 Join recipient preferences into thread query for faster lookup
// FREEBIE
2017-08-28 10:30:50 -07:00
Moxie Marlinspike
375207f073 Switch MMS groups to use the group database infrastructure
Eliminate the concept of 'Recipients' (plural). There is now just
a 'Recipient', which contains an Address that is either an individual
or a group ID.

MMS groups now exist as part of the group database, just like push
groups.

// FREEBIE
2017-08-28 10:30:50 -07:00
mcloo
60eaade6b0 Fix plaintext export XML name escaping
Fixes #6830
Closes #6861
2017-08-22 15:22:03 -07:00
Benedikt Constantin Radtke
54396a3a9c Fix group info request responses
GroupRecords have a list of Addresses, not Strings.

Fixes #6881
Closes #6882
2017-08-22 15:19:39 -07:00
Moxie Marlinspike
a80fe178ea Canonicalize addresses during import from system SMS database
// FREEBIE
2017-08-10 12:30:13 -07:00
Moxie Marlinspike
422b4c345b Catch IllegalArgumentException thrown internally on some devices
// FREEBIE
2017-08-10 12:17:05 -07:00
Moxie Marlinspike
47901e4198 Disallow alpha chars in country code field
// FREEBIe
2017-08-07 12:40:40 -07:00
Moxie Marlinspike
25a30d63a5 A blocked contact doesn't necessarily have to be a number
// FREEBIE
2017-08-07 12:27:34 -07:00
Moxie Marlinspike
c5a7d320f7 Don't query contacts DB if we have nothing to query
// FREEBIE
2017-08-04 09:28:20 -07:00
Moxie Marlinspike
8de9261081 MMS addresses can be email addresses
Fixes #6853
// FREEBIE
2017-08-04 09:22:58 -07:00
Moxie Marlinspike
cb4303ac23 Handle migration case where recipient_ids is completely empty
No idea how a DB is in that state, but apparently it's possible

Fixes #6850
// FREEBIE
2017-08-03 09:32:56 -07:00
Moxie Marlinspike
9a78615991 Switch regexp matcher to find() in order to handle alpha addresses
Any address with an alpha character anywhere in it should be used
as-is.

Fixes #6849

// FREEBIE
2017-08-03 09:24:08 -07:00
Moxie Marlinspike
7f46e99f9c Use SIM country code when registered number is unavailable
Convert directory operations to Addresses

Fixes #6845
// FREEBIE
2017-08-02 12:51:46 -07:00
Moxie Marlinspike
4838fade6c Fix typo
// FREEBIE
2017-08-02 11:15:58 -07:00
Moxie Marlinspike
1e934f6146 Escape addresess in thread and recipient pref migrations
For clients that have not yet migrated

// FREEBIE
2017-08-02 11:08:38 -07:00
Moxie Marlinspike
aacf50316d Escape addresses in thread, recipient pref, and group databases
Fixes #6847
// FREEBIE
2017-08-02 11:04:10 -07:00
Moxie Marlinspike
24c48afd2e Fix typo in migration constraint resolution
Fixes #6846

// FREEBIE
2017-08-02 08:02:15 -07:00
Moxie Marlinspike
9a55632202 During migration, support recipient id of "-1"
Fixes #6843
// FREEBIE
2017-08-01 18:45:13 -07:00
Moxie Marlinspike
6ed549cfb2 If two recipient ids get canonicalized to the same thing, drop one
There's not a great way for me to know which of them is the "real"
entry, which means that I could be deleting the wrong one. In the
case of recipient "preferences," it's hopefully not a huge loss,
and there aren't any other great options.

Fixes #6838

// FREEBIE
2017-08-01 14:52:03 -07:00
Moxie Marlinspike
8a5c89244a Be more liberal with migration addresses.
Anything alpha is an address as-is.

// FREEBIE.
2017-08-01 14:46:38 -07:00
Moxie Marlinspike
a67d0b18ff Be more liberal with external address formatting
A string like "bonbon" should just be "bonbon". That is apparently
a valid SMS source address.

// FREEBIE
2017-08-01 14:04:51 -07:00
Moxie Marlinspike
abea2d0bdf Fix for MediaOverviewActivity NPE
// FREEBIE
2017-08-01 10:00:55 -07:00
Moxie Marlinspike
5f9a3b7930 Only lookup contact address by number if address is a phone number
// FREEBIE
2017-08-01 09:57:50 -07:00
Moxie Marlinspike
4229c21bdc Fix NPE on contact update request
Fixes #6840

// FREEBIE
2017-08-01 08:57:26 -07:00
Moxie Marlinspike
0ae60da68b Fix some bugs that would mis-label threads in migration
// FREEBIE
2017-07-31 14:04:47 -07:00
Moxie Marlinspike
737810475e Remove the Canonical Address Database
This was a holdover from Signal's origins as a pure SMS app.
It causes problems, depends on undefined device specific behavior,
and should no longer be necessary now that we have all the
information we need to E164 all numbers.

// FREEBIE
2017-07-31 12:02:29 -07:00
Moxie Marlinspike
e452862813 Catch unsatisfied link error on start if webrtc so isn't found
// FREEBIE
2017-07-21 16:29:03 -07:00
Moxie Marlinspike
5be246ec8f Fix NPE for SMS pdus that could potentially be null
// FREEBIE
2017-07-21 16:11:55 -07:00
Moxie Marlinspike
72afb33c1b Add Moto G5 to hardware AEC blacklist
For #6241
// FREEBIE
2017-07-21 16:03:31 -07:00
Moxie Marlinspike
0b39224d88 getMemoryClass -> getLargeMemoryClass
Fixes #6812

// FREEBIe
2017-07-21 16:01:32 -07:00
Moxie Marlinspike
82b5b35d3b Eliminate MediaNetworkRequirement style attachment job handling
// FREEBIE
2017-07-21 15:59:27 -07:00
AndHell
10de144b77 Trim message text to prohibit sending empty whitespace messages
Closes #6788
2017-07-12 18:15:49 -07:00
Moxie Marlinspike
c36db03a3a Prevent audio control click handler feedback loops
Fixes #6356
Fixes #6406
Fixes #6169

Closes #6800
// FREEBIE
2017-07-12 16:18:54 -07:00
Moxie Marlinspike
9dd508b6f5 Track pending incoming ice updates in addition to outgoing
// FREEBIE
2017-07-12 11:15:28 -07:00
Moxie Marlinspike
34443b059c Revert "We can now send trickle ice candidates immediately"
Need to hold off on this for some iOS changes.

This reverts commit 338f8de787.
2017-07-12 10:59:10 -07:00
Moxie Marlinspike
526d510423 Start creating "persistent" blobs in cache directory
Helps #5515
// FREEBIE
2017-07-06 12:58:05 -07:00
Gavin Howard
381237a315 Make plaintext export more compatible with SMS Backup and Restore
This commit adds the contact name and the readable date (and time) to
the plaintext export of every message. That's because that is how SMS
Backup and Restore does it, so this commit makes Signal more compatible.

Closes #6452
// FREEBIE
2017-07-06 12:19:12 -07:00
FeuRenard
512c6dc581 Keep screen off after end of audio playback
Fixes #6654
Closes #6669
// FREEBIE
2017-07-05 18:31:14 -07:00
Christian Ascheberg
d0bb68e137 Fix group creation through group info request
Closes #6763
// FREEBIE
2017-07-05 14:19:55 -07:00
Christian Ascheberg
95d48bd3e9 Improve wording of joined contact notification
Fixes #6757
Closes #6764
// FREEBIE
2017-07-05 14:18:07 -07:00
Moxie Marlinspike
338f8de787 We can now send trickle ice candidates immediately
// FREEBIE
2017-07-05 14:06:31 -07:00
Moxie Marlinspike
2c4c0f1349 Archive sessions and generate new registration id on re-register
Fixes #6703
// FREEBIE
2017-07-05 13:13:53 -07:00
Moxie Marlinspike
39b95ca4ed Do more to keep MessageRetrievalService alive
Closes #6456
2017-07-03 11:36:31 -07:00
Moxie Marlinspike
074e46b2d9 Enable verification syncing
// FREEBIE
2017-06-23 13:59:06 -07:00
Moxie Marlinspike
f193723182 Don't display verified marker in conversation if unregistered
Closes #6755
// FREEBIE
2017-06-22 10:37:26 -07:00
Moxie Marlinspike
a0e23612d4 We need to disable this until push notifications contain more info
This could be a sync message, delivery receipt, or some other
message that isn't user-visible. The push notification content
would need to indicate whether that's the case in order to be
able to accurately display a notification

// FREEBIE
2017-06-20 10:57:11 -07:00
Moxie Marlinspike
04f364942e Don't update thread state for groups w/ verified/default SNs
Fixes #6744
// FREEBIE
2017-06-19 11:20:15 -07:00
Moxie Marlinspike
0cc5618ba9 Only offer share/compare options when SN calculation is complete
Now that we're loading this asynchronously, these options need
to respond asynchronously as well

Fixes #6739
// FREEBIE
2017-06-19 10:39:15 -07:00
Moxie Marlinspike
8208bbf3c0 Remove stale identity approval preference (no longer used)
Fixes #6745
// FREEBIE
2017-06-19 09:27:35 -07:00
Moxie Marlinspike
1c8077a7fe Switch from a hardware AEC whitelist back to a blacklist
Disabling OpenSL ES seems to make the hardware AEC "work" on
devices where it was previously causing problems.

Using the WebRTC-based software AEC *without* OpenSL ES seems to
be causing new problems.

Fixes #6737
Related #6432
Related #6241
// FREEBIE
2017-06-19 09:22:07 -07:00
Moxie Marlinspike
ec240a94e6 Fix capitalization (innocuous)
// FREEBIE
2017-06-15 12:04:50 -07:00
Moxie Marlinspike
666be5f358 Preserve unverified status if aleady unverified on update
// FREEBIE
2017-06-14 11:01:24 -07:00
Moxie Marlinspike
7f76bcc976 Don't attempt to fetch profiles for SMS contacts
// FREEBIE
2017-06-14 09:53:22 -07:00
Moxie Marlinspike
2dbeebac77 Maintain placeholder encrypted body to avoid processing error
// FREEBIE
2017-06-14 09:45:38 -07:00
Moxie Marlinspike
0f6823d37e Null check just in case the profile comes back empty
// FREEBIE
2017-06-14 09:35:32 -07:00
Moxie Marlinspike
f92d768be5 Correctly handle ice candidate for stale call
Fixes #6373
Fixes #6305
// FREEBIE
2017-06-13 09:21:42 -07:00
Moxie Marlinspike
1eccc07673 Temporarily disable synchronization messages
Until desktop catches up

// FREEBIE
2017-06-12 09:47:58 -07:00
Moxie Marlinspike
76c28cfa7a Add support for SN verification
// FREEBIE
2017-06-09 19:58:01 -07:00
Moxie Marlinspike
58273997b9 Explicitly check for disabled play services if needs update
Fixes #6381
// FREEBIE
2017-06-02 09:59:23 -07:00
Moxie Marlinspike
5672701a60 Add uncaught exception handler to message retrieval thread
Related #6644
// FREEBIE
2017-06-02 09:49:44 -07:00
Moxie Marlinspike
711740d156 Update to libsignal-service 2.5.10
// FREEBIE
2017-06-02 09:49:29 -07:00
Moxie Marlinspike
b50a3fa2b8 Actually handle busy signal correctly
// FREEBIE
2017-06-01 13:11:48 -07:00
Moxie Marlinspike
7e40204eb2 Fix migration
Fixes #6695
// FREEBIE
2017-06-01 10:57:45 -07:00
Moxie Marlinspike
d413b80b15 Canonicalize number when retrieving profile
// FREEBIE
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
73410f64b5 Display a notification when unable retrieve messages for push
Fixes #6684
// FREEBIE
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
cd55feb2b9 Update signal-service to 2.5.9
// FREEBIE
2017-05-31 14:51:48 -07:00
FeuRenard
a9ea672888 Resolve media message race condition
Fixes #6677
Closes #6681
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
5455bdffb2 Make sure existing identity entries are approved in migration
// FREEBIE
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
0367bf0de4 Update signal-service to 2.5.8
// FREEBIE
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
e9ae439b70 Fix for out of bounds on last seen search
Fixes #6661
Fixes #6660
// FREEBIE
2017-05-31 14:51:48 -07:00
Paride Legovini
99d229bb45 Don't connect to server if !isPushRegistered
Partial fix for #6620.
Closes #6627
// FREEBIE
2017-05-31 14:51:48 -07:00
Nicholas Rizzio
3d7331159f Set the advanced menu icon correctly
Fixes #6638
Closes #6639
// FREEBIE
2017-05-31 14:51:48 -07:00
Christian Ascheberg
662fe826cb Fix conversation list safety number change snippet for groups
Fixes #5985
Closes #6655
// FREEBIE
2017-05-31 14:51:48 -07:00
FeuRenard
ec1a0547d6 Don't show sent checkmark for outgoing calls
Fixes #6502
Closes #6667
// FREEBIE
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
d507756821 Some identity key handling changes
1) Prefetch identity keys when possible

2) Always accept prefetched keys or keys from incoming messages

3) Block sending only if it's a recent change, or if always
   block is enabled

// FREEBIE
2017-05-31 14:51:48 -07:00
Moxie Marlinspike
4509077338 Lollipop MMS API doesn't seem to work reliably until L_MR1
Fixes #6663
Fixes #6668
// FREEBIE
2017-05-24 10:52:08 -07:00
Moxie Marlinspike
4dd5a92817 Fix for NPE when place picker name is unavailable
Fixes #6671
// FREEBIE
2017-05-24 10:03:35 -07:00
Moxie Marlinspike
782bd6003b Actually fallback to manual MMS receiving when system fails
Should resolve #6668 for tmobile users on older lollipop phones
// FREEBIE
2017-05-23 18:23:47 -07:00
Moxie Marlinspike
b78c05e70b Keep track of when audio attachments are voice notes
// FREEBIE
2017-05-11 22:46:35 -07:00
Moxie Marlinspike
e96bf2bdc7 Allow share intents for arbitrary file types
Fixes #6608
// FREEBIE
2017-05-10 15:21:52 -07:00
Moxie Marlinspike
1c8c6d5f85 Be sure to canonicalize numbers when updating groups
// FREEBIE
2017-05-09 17:46:07 -07:00
Moxie Marlinspike
1525d0833c Enforce ordered data channel
// FREEBIE
2017-05-09 12:13:42 -07:00
Moxie Marlinspike
3fd5e58bd5 Disable OpenSL ES by default
Fixes #6432
// FREEBIE
2017-05-09 11:03:32 -07:00
Moxie Marlinspike
51d6144591 Significant MMS changes
1) Remove all our PDU code and switch to the PDU code from the
   klinker library

2) Switch to using the system Lollipop MMS library by default,
   and falling back to our own custom library if that fails.

3) Format SMIL differently, using code from klinker instead of
   what we've pieced together.

4) Pull per-carrier MMS media constraints from the XML config
   files in the klinker library, instead of hardcoding it at 280kb.

Hopefully this is an improvement, but given that MMS is involved,
it will probably make things worse instead.
2017-05-08 18:14:55 -07:00
Audric Ackermann
165fae5734 Display contact custom label instead of phone number
Fixes #6211
2017-05-07 19:23:55 -07:00
AndHell
dc18f73594 update contact query
update query to remove duplicated numbers

Fixes #4191
Closes #6475
2017-05-07 19:18:26 -07:00
Moxie Marlinspike
12ce92bb83 Fix super call
// FREEBIE
2017-05-07 18:59:35 -07:00
Moxie Marlinspike
b0b08a37db Rename "other" to "sms"
// FREEBIE
2017-05-07 18:59:18 -07:00
FeuRenard
1b75d00de5 Color registration buttons correctly <API21
Fixes #6604
Closes #6605
// FREEBIE
2017-05-07 18:23:19 -07:00
Jonas Vautherin
dd3cef5ec2 Refactor storage management to have a centralized,
clearer way to get the Signal output directories

Closes #6476
// FREEBIE
2017-05-06 14:06:04 -07:00
Moxie Marlinspike
757ccd0c36 Updated emoji set
Fixes #4279
Fixes #6587
2017-05-05 19:42:23 -07:00
Moxie Marlinspike
e340f85258 Tint devices icon too
Fixes #6601
// FREEBIE
2017-04-28 16:30:20 -07:00
Mateo Hernandez
a93fb1a0e5 Fix font size preference
Closes #6597
// FREEBIE
2017-04-28 14:51:56 -07:00
Christian Juner
1c94137f7a Fall back to Camera1Enumerator on exceptions
If Camera2Enumerator.isSupported() throws, consider Camera2Enumerator to
not be supported, log the Throwable, and use Camera1Enumerator instead.

Before this patch, an exception thrown by Camera2Enumerator.isSupported
would crash any Signal call (even if video was not enabled).

Fixes #6537
// FREEBIE
2017-04-27 20:51:31 +02:00
Moxie Marlinspike
2e8250f25e Add LG G3 to OpenSLES blacklist
// FREEBIE
2017-04-27 11:38:49 -07:00
Mateo Hernandez
b17cba621e Show emoji-only messages larger
Closes #6531
// FREEBIE
2017-04-26 17:52:16 -07:00
Moxie Marlinspike
cb670d6783 Improve UI send latency
// FREEBIE
2017-04-26 10:27:30 -07:00
Moxie Marlinspike
4d889a45e2 Blacklist Nexus 5 from OpenSL ES
Fixes #6432
// FREEBIE
2017-04-26 10:26:32 -07:00
Moxie Marlinspike
66d1d88686 Fix file push media constraint
// FREEBIE
2017-04-25 10:01:09 -07:00
Moxie Marlinspike
31a549449b Mutate Drawables we tint
Fixes #6575
// FREEBIE
2017-04-24 16:37:13 -07:00
Moxie Marlinspike
9bf198bb81 Add media constraints for arbitrary file types
Fixes #6573
// FREEBIE
2017-04-24 15:53:22 -07:00
Ahmed Ibrahim Khalil
c2796285d5 Fix copying links when scrolling in #6343
Closes #6565
// FREEBIE
2017-04-23 16:25:57 -07:00
Moxie Marlinspike
25c7459464 Add support for notification priority preference
Fixes #6315
// FREEBIE
2017-04-21 23:05:59 -07:00
Moxie Marlinspike
2dceef50b7 Slim down some preference screens
// FREEBIE
2017-04-21 23:05:59 -07:00
Moxie Marlinspike
438a78ed30 Switch jobs with network requirement to timed wakelock
// FREEBIE
2017-04-21 23:05:59 -07:00
Moxie Marlinspike
8e7c7a9c54 Improve video thumbnail generation and handling on send side
For direct attach only

// FREEBIE
2017-04-21 23:05:59 -07:00
Moxie Marlinspike
ad4657df1f Fix video selection support with extra mime type
// FREEBIE
2017-04-21 23:05:59 -07:00
Moxie Marlinspike
2b79e131a7 Support for sending arbitrary file types
// FREEBIE
2017-04-21 23:05:59 -07:00
Ahmed Ibrahim Khalil
c3164a8e84 Support copying links on long click.
Fixes #6343
Closes #6454
2017-04-21 23:05:59 -07:00
Mateo Hernandez
f07ce7b1f1 Move SMS/MMS pref hiding logic to onCreate
Closes #6528
// FREEBIE
2017-04-21 23:05:59 -07:00
Mateo Hernandez
a353ebd834 Add tint to preference icons
Closes #6540
// FREEBIE
2017-04-21 23:05:59 -07:00