AL-Session 1e02845fd2
[SES-1486] Short voice message fix (#1523)
* Initial working push with debug comments

* Fixes #1522

* Cleanup, prevent multi-pointer recording, and don't show short msg toast if locked to record quickly

* Adjusted comment phrasing

* Fix comment phrasing

* Fixed inadvertant short voice message toast on exit conversation activity

* Comment adjustment

* Comment phrasing

* Adjusted AudioRecorder.startRecording to take a callback function rather than the InputBar

* Performed Thomas' PR feedback

* Move comment to more relevant place

* Removed unused / leftover callback definition

* Removed all redundant null checks after asserting binding is not null

* Removed remaining not-null assertions & added some logged feedback to fail states

* Addressed PR feedback

* Implemented additional PR feedback

* Adjusted InputBar property visibility as per PR feedback & adjusted Toast string following discussion with Lucy

* Minor adjustment to inform user if we see an obvious network issue when sending a voice message - also tweak the locked Cancel button size to prevent text entry when locked to voice recording

* Adjust comment phrasing following further testing

* Added TODO comments to replace hard-coded string in toasts

* Addressed Thomas PR feedback suggestion

* Addressed another feedback suggestion

* Adjustment to continue informing user of network / node path issues

* Improved & moved network check method

* Corrected ticket number into TODO comments

* Addressed Andy PR feedback

* Adjust network connectivity checks to just log issues rather than inform the user (as per Rebecca / Kee convo)

---------

Co-authored-by: alansley <aclansley@gmail.com>
2024-07-03 14:44:26 +10:00
..