TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-27 11:12:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/tstun: remove buffer on outbound channel

Browse Source 
The buffer is not necessary, I was unable to observe any optimization,
and having an unbuffered channel offers potential scheduler
optimization.

Signed-off-by: James Tucker <james@tailscale.com>
This commit is contained in:
James Tucker 2022-08-25 10:34:25 -07:00
parent 58f35261d0
commit 0c34fc7b5b
No known key found for this signature in database
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/tstun/wrap.go
View File

@ -202,10 +202,9 @@ func wrap(logf logger.Logf, tdev tun.Device, isTAP bool) *Wrapper {
// a goroutine should not block when setting it, even with no listeners. // a goroutine should not block when setting it, even with no listeners.
bufferConsumed: make(chan struct{}, 1), bufferConsumed: make(chan struct{}, 1),
closed: make(chan struct{}), closed: make(chan struct{}),
// outbound can be unbuffered; the buffer is an optimization. outbound: make(chan tunReadResult),
outbound: make(chan tunReadResult, 1), eventsUpDown: make(chan tun.Event),
eventsUpDown: make(chan tun.Event), eventsOther: make(chan tun.Event),
eventsOther: make(chan tun.Event),
// TODO(dmytro): (highly rate-limited) hexdumps should happen on unknown packets. // TODO(dmytro): (highly rate-limited) hexdumps should happen on unknown packets.
filterFlags: filter.LogAccepts | filter.LogDrops, filterFlags: filter.LogAccepts | filter.LogDrops,
} }