tailscaleroot: panic if tailscale_go build tag but Go toolchain mismatch

Fixes #13527

Change-Id: I05921969a84a303b60d1b3b9227aff9865662831
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2024-10-06 12:12:44 -07:00 committed by Brad Fitzpatrick
parent c48cc08de2
commit 1005cbc1e4
3 changed files with 45 additions and 10 deletions

View File

@ -0,0 +1,27 @@
// Copyright (c) Tailscale Inc & AUTHORS
// SPDX-License-Identifier: BSD-3-Clause
//go:build tailscale_go
package tailscaleroot
import (
"fmt"
"os"
"strings"
)
func init() {
tsRev, ok := tailscaleToolchainRev()
if !ok {
panic("binary built with tailscale_go build tag but failed to read build info or find tailscale.toolchain.rev in build info")
}
want := strings.TrimSpace(GoToolchainRev)
if tsRev != want {
if os.Getenv("TS_PERMIT_TOOLCHAIN_MISMATCH") == "1" {
fmt.Fprintf(os.Stderr, "tailscale.toolchain.rev = %q, want %q; but ignoring due to TS_PERMIT_TOOLCHAIN_MISMATCH=1\n", tsRev, want)
return
}
panic(fmt.Sprintf("binary built with tailscale_go build tag but Go toolchain %q doesn't match github.com/tailscale/tailscale expected value %q; override this failure with TS_PERMIT_TOOLCHAIN_MISMATCH=1", tsRev, want))
}
}

View File

@ -4,7 +4,10 @@
// Package tailscaleroot embeds VERSION.txt into the binary. // Package tailscaleroot embeds VERSION.txt into the binary.
package tailscaleroot package tailscaleroot
import _ "embed" import (
_ "embed"
"runtime/debug"
)
// VersionDotTxt is the contents of VERSION.txt. Despite the tempting filename, // VersionDotTxt is the contents of VERSION.txt. Despite the tempting filename,
// this does not necessarily contain the accurate version number of the build, which // this does not necessarily contain the accurate version number of the build, which
@ -22,3 +25,16 @@
// //
//go:embed go.toolchain.rev //go:embed go.toolchain.rev
var GoToolchainRev string var GoToolchainRev string
func tailscaleToolchainRev() (gitHash string, ok bool) {
bi, ok := debug.ReadBuildInfo()
if !ok {
return "", false
}
for _, s := range bi.Settings {
if s.Key == "tailscale.toolchain.rev" {
return s.Value, true
}
}
return "", false
}

View File

@ -7,23 +7,15 @@
import ( import (
"os" "os"
"runtime/debug"
"strings" "strings"
"testing" "testing"
) )
func TestToolchainMatches(t *testing.T) { func TestToolchainMatches(t *testing.T) {
bi, ok := debug.ReadBuildInfo() tsRev, ok := tailscaleToolchainRev()
if !ok { if !ok {
t.Fatal("failed to read build info") t.Fatal("failed to read build info")
} }
var tsRev string
for _, s := range bi.Settings {
if s.Key == "tailscale.toolchain.rev" {
tsRev = s.Value
break
}
}
want := strings.TrimSpace(GoToolchainRev) want := strings.TrimSpace(GoToolchainRev)
if tsRev != want { if tsRev != want {
if os.Getenv("TS_PERMIT_TOOLCHAIN_MISMATCH") == "1" { if os.Getenv("TS_PERMIT_TOOLCHAIN_MISMATCH") == "1" {