feature/taildrop, ipn/ipnlocal: remove leftover dup calls to osshare

I'd moved the osshare calls to feature/taildrop hooks, but forgot to
remove them from ipnlocal, or lost them during a rebase.

But then I noticed cmd/tailscaled also had some, so turn those into a
hook.

Updates #12614

Change-Id: I024fb1d27fbcc49c013158882ee5982c2737037d
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>

ipn/ipnlocal/local.go

@@ -102,7 +102,6 @@ import (
 	"tailscale.com/util/httpm"
 	"tailscale.com/util/mak"
 	"tailscale.com/util/multierr"
-	"tailscale.com/util/osshare"
 	"tailscale.com/util/osuser"
 	"tailscale.com/util/rands"
 	"tailscale.com/util/set"
@@ -274,7 +273,6 @@ type LocalBackend struct {
 	machinePrivKey key.MachinePrivate
 	tka            *tkaState // TODO(nickkhyl): move to nodeContext
 	state          ipn.State // TODO(nickkhyl): move to nodeContext
-	capFileSharing bool      // whether netMap contains the file sharing capability
 	capTailnetLock bool      // whether netMap contains the tailnet lock capability
 	// hostinfo is mutated in-place while mu is held.
 	hostinfo          *tailcfg.Hostinfo      // TODO(nickkhyl): move to nodeContext
@@ -460,7 +458,6 @@ func NewLocalBackend(logf logger.Logf, logID logid.PublicID, sys *tsd.System, lo
 	}
 
 	envknob.LogCurrent(logf)
-	osshare.SetFileSharingEnabled(false, logf)
 
 	ctx, cancel := context.WithCancel(context.Background())
 	clock := tstime.StdClock{}
@@ -6140,13 +6137,6 @@ func (b *LocalBackend) setNetMapLocked(nm *netmap.NetworkMap) {
 		b.health.SetControlHealth(nil)
 	}
 
-	// Determine if file sharing is enabled
-	fs := nm.HasCap(tailcfg.CapabilityFileSharing)
-	if fs != b.capFileSharing {
-		osshare.SetFileSharingEnabled(fs, b.logf)
-	}
-	b.capFileSharing = fs
-
 	if nm.HasCap(tailcfg.NodeAttrLinuxMustUseIPTables) {
 		b.capForcedNetfilter = "iptables"
 	} else if nm.HasCap(tailcfg.NodeAttrLinuxMustUseNfTables) {

ipn/ipnlocal/peerapi_test.go

@@ -67,18 +67,16 @@ func bodyNotContains(sub string) check {
 
 func TestHandlePeerAPI(t *testing.T) {
 	tests := []struct {
-		name       string
-		isSelf     bool // the peer sending the request is owned by us
-		capSharing bool // self node has file sharing capability
-		debugCap   bool // self node has debug capability
-		reqs       []*http.Request
-		checks     []check
+		name     string
+		isSelf   bool // the peer sending the request is owned by us
+		debugCap bool // self node has debug capability
+		reqs     []*http.Request
+		checks   []check
 	}{
 		{
-			name:       "not_peer_api",
-			isSelf:     true,
-			capSharing: true,
-			reqs:       []*http.Request{httptest.NewRequest("GET", "/", nil)},
+			name:   "not_peer_api",
+			isSelf: true,
+			reqs:   []*http.Request{httptest.NewRequest("GET", "/", nil)},
 			checks: checks(
 				httpStatus(200),
 				bodyContains("This is my Tailscale device."),
@@ -86,10 +84,9 @@ func TestHandlePeerAPI(t *testing.T) {
 			),
 		},
 		{
-			name:       "not_peer_api_not_owner",
-			isSelf:     false,
-			capSharing: true,
-			reqs:       []*http.Request{httptest.NewRequest("GET", "/", nil)},
+			name:   "not_peer_api_not_owner",
+			isSelf: false,
+			reqs:   []*http.Request{httptest.NewRequest("GET", "/", nil)},
 			checks: checks(
 				httpStatus(200),
 				bodyContains("This is my Tailscale device."),
@@ -160,9 +157,8 @@ func TestHandlePeerAPI(t *testing.T) {
 			}
 			var e peerAPITestEnv
 			lb := &LocalBackend{
-				logf:           e.logBuf.Logf,
-				capFileSharing: tt.capSharing,
-				clock:          &tstest.Clock{},
+				logf:  e.logBuf.Logf,
+				clock: &tstest.Clock{},
 			}
 			lb.currentNode().SetNetMap(&netmap.NetworkMap{SelfNode: selfNode.View()})
 			e.ph = &peerAPIHandler{