ipn/policy,tailcfg: document desire to not extend peerapi service advertisements in hostinfo

Updates #cleanup
Signed-off-by: James Tucker <james@tailscale.com>
This commit is contained in:
James Tucker 2023-11-09 17:26:27 -08:00
parent 933d201bba
commit 1b18952450
No known key found for this signature in database
2 changed files with 5 additions and 0 deletions

View File

@ -14,6 +14,8 @@ import (
// to our peer nodes for discovery purposes.
func IsInterestingService(s tailcfg.Service, os string) bool {
switch s.Proto {
// Avoid further extension of this approach to advertising peer services.
// TODO(bradfitz,raggi): point to preferred approach
case tailcfg.PeerAPI4, tailcfg.PeerAPI6, tailcfg.PeerAPIDNS, tailcfg.AppConnector:
return true
}

View File

@ -653,6 +653,9 @@ type Service struct {
// * "app-connector": the local app-connector service is
// available. For this service, the Port number is
// really the version number of the service.
//
// Avoid further extension of this approach to advertising peer services.
// TODO(bradfitz,raggi): point to preferred approach
Proto ServiceProto
// Port is the port number.