TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-07-31 00:03:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/filter: omit logging for all v6 multicast, remove debug panic :(

Browse Source 
(cherry picked from commit da3b50ad88d75693a80b1203075b531a5c89cdf1)
This commit is contained in:
Brad Fitzpatrick 2020-08-01 12:40:09 -07:00 committed by David Anderson
parent e98ed6319a
commit 1d9ab6d484
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
wgengine/filter/filter.go
View File

@ -349,7 +349,10 @@ func omitDropLogging(p *packet.ParsedPacket, dir direction) bool {
if string(dst) == ipv6AllMLDv2CapableRouters {
return true
}
panic(fmt.Sprintf("Got proto=%2x; src=%x dst=%x", int(p.IPProto), src, dst))
// Actually, just catch all multicast.
if dst[0] == 0xff {
return true
}
}
}
return false

6
wgengine/filter/filter_test.go
View File

@ -343,6 +343,12 @@ func TestOmitDropLogging(t *testing.T) {
dir: out,
want: true,
},
{
name: "v6_udp_multicast",
pkt: parseHexPkt(t, "60 00 00 00 00 00 11 00 fe800000000000007dc6bc04499262a3 ff120000000000000000000000008384"),
dir: out,
want: true,
},
}
for _, tt := range tests {