From 237c6c44cd8b4f39798d3d4f61baa1af6a041af9 Mon Sep 17 00:00:00 2001
From: Will Norris <will@tailscale.com>
Date: Wed, 1 Nov 2023 10:35:46 -0700
Subject: [PATCH] client/web: call /api/auth before rendering any client views

For now this is effectively a noop, since only the ManagementClientView
uses the auth data. That will change soon.

Updates tailscale/corp#14335

Signed-off-by: Will Norris <will@tailscale.com>
---
 client/web/src/components/app.tsx | 30 ++++++++++--------------------
 client/web/web.go                 | 10 +++++++++-
 2 files changed, 19 insertions(+), 21 deletions(-)

diff --git a/client/web/src/components/app.tsx b/client/web/src/components/app.tsx
index cf06ee724..8b10ae475 100644
--- a/client/web/src/components/app.tsx
+++ b/client/web/src/components/app.tsx
@@ -4,25 +4,29 @@ import LegacyClientView from "src/components/views/legacy-client-view"
 import LoginClientView from "src/components/views/login-client-view"
 import ReadonlyClientView from "src/components/views/readonly-client-view"
 import useAuth from "src/hooks/auth"
-import useNodeData, { NodeData } from "src/hooks/node-data"
+import useNodeData from "src/hooks/node-data"
 import ManagementClientView from "./views/management-client-view"
 
 export default function App() {
   const { data, refreshData, updateNode } = useNodeData()
+  const { data: auth, loading: loadingAuth, waitOnAuth } = useAuth()
 
   return (
     <div className="flex flex-col items-center min-w-sm max-w-lg mx-auto py-14">
-      {!data ? (
-        <div className="text-center">Loading...</div> // TODO(sonia): add a loading view
+      {!data || loadingAuth ? (
+        <div className="text-center py-14">Loading...</div> // TODO(sonia): add a loading view
       ) : data?.Status === "NeedsLogin" || data?.Status === "NoState" ? (
         // Client not on a tailnet, render login.
         <LoginClientView
           data={data}
           onLoginClick={() => updateNode({ Reauthenticate: true })}
         />
+      ) : data.DebugMode === "full" && auth?.ok ? (
+        // Render new client interface in management mode.
+        <ManagementClientView {...data} />
       ) : data.DebugMode === "login" || data.DebugMode === "full" ? (
-        // Render new client interface.
-        <WebClient {...data} />
+        // Render new client interface in readonly mode.
+        <ReadonlyClientView data={data} auth={auth} waitOnAuth={waitOnAuth} />
       ) : (
         // Render legacy client interface.
         <LegacyClientView
@@ -31,25 +35,11 @@ export default function App() {
           updateNode={updateNode}
         />
       )}
-      {data && <Footer licensesURL={data.LicensesURL} />}
+      {data && !loadingAuth && <Footer licensesURL={data.LicensesURL} />}
     </div>
   )
 }
 
-function WebClient(props: NodeData) {
-  const { data: auth, loading: loadingAuth, waitOnAuth } = useAuth()
-
-  if (loadingAuth) {
-    return <div className="text-center py-14">Loading...</div>
-  }
-
-  return props.DebugMode === "full" && auth?.ok ? (
-    <ManagementClientView {...props} />
-  ) : (
-    <ReadonlyClientView data={props} auth={auth} waitOnAuth={waitOnAuth} />
-  )
-}
-
 export function Footer(props: { licensesURL: string; className?: string }) {
   return (
     <footer
diff --git a/client/web/web.go b/client/web/web.go
index 97f73b683..849d1c519 100644
--- a/client/web/web.go
+++ b/client/web/web.go
@@ -252,6 +252,11 @@ func (s *Server) serveLoginAPI(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, "invalid endpoint", http.StatusNotFound)
 		return
 	}
+	if r.URL.Path != "/api/auth" {
+		// empty JSON response until we serve auth for the login client
+		fmt.Fprintf(w, "{}")
+		return
+	}
 	switch r.Method {
 	case httpm.GET:
 		// TODO(soniaappasamy): we may want a minimal node data response here
@@ -354,8 +359,11 @@ func (s *Server) serveAPI(w http.ResponseWriter, r *http.Request) {
 	case path == "/auth":
 		if s.tsDebugMode == "full" { // behind debug flag
 			s.serveTailscaleAuth(w, r)
-			return
+		} else {
+			// empty JSON response until we serve auth for other modes
+			fmt.Fprintf(w, "{}")
 		}
+		return
 	case path == "/data":
 		switch r.Method {
 		case httpm.GET: