TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-01-07 08:07:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/deephash: remove unused stack slice in typeIsRecursive (#5363)

Browse Source 
No operation ever reads from this variable.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
This commit is contained in:
Joe Tsai 2022-08-15 22:36:08 -07:00 committed by GitHub
parent c200229f9e
commit 23ec3c104a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/deephash/deephash.go
View File

@ -646,8 +646,6 @@ func getTypeInfoLocked(t reflect.Type, incomplete map[reflect.Type]*typeInfo) *t
func typeIsRecursive(t reflect.Type) bool { func typeIsRecursive(t reflect.Type) bool {
inStack := map[reflect.Type]bool{} inStack := map[reflect.Type]bool{}
var stack []reflect.Type
var visitType func(t reflect.Type) (isRecursiveSoFar bool) var visitType func(t reflect.Type) (isRecursiveSoFar bool)
visitType = func(t reflect.Type) (isRecursiveSoFar bool) { visitType = func(t reflect.Type) (isRecursiveSoFar bool) {
switch t.Kind() { switch t.Kind() {
@ -678,11 +676,9 @@ func typeIsRecursive(t reflect.Type) bool {
if inStack[t] { if inStack[t] {
return true return true
} }
stack = append(stack, t)
inStack[t] = true inStack[t] = true
defer func() { defer func() {
delete(inStack, t) delete(inStack, t)
stack = stack[:len(stack)-1]
}() }()
switch t.Kind() { switch t.Kind() {