TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2026-01-05 01:11:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/syspolicy/policytest: move policy test helper to its own package

Browse Source 
Updates #16998
Updates #12614

Change-Id: I9fd27d653ebee547951705dc5597481e85b60747
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2025-09-02 16:50:10 -07:00
committed by Brad Fitzpatrick
parent 2b3e533048
commit 24b8a57b1e
2 changed files with 120 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
ipn/ipnlocal/local_test.go
View File

@@ -64,7 +64,7 @@ import (
"tailscale.com/util/set"
"tailscale.com/util/syspolicy"
"tailscale.com/util/syspolicy/pkey"
"tailscale.com/util/syspolicy/policyclient"
"tailscale.com/util/syspolicy/policytest"
"tailscale.com/util/syspolicy/setting"
"tailscale.com/util/syspolicy/source"
"tailscale.com/wgengine"
@@ -1183,7 +1183,7 @@ func TestConfigureExitNode(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
var pol testPolicy
var pol policytest.Config
// Configure policy settings, if any.
if tt.exitNodeIDPolicy != nil {
pol.Set(pkey.ExitNodeID, string(*tt.exitNodeIDPolicy))
@@ -5539,62 +5539,6 @@ func TestReadWriteRouteInfo(t *testing.T) {
}
}
// testPolicy is a [policyclient.Client] with a static mapping of values.
// The map value must be of the correct type (string, []string, bool, etc).
//
// It is used for testing purposes to simulate policy client behavior.
// It panics if the values are the wrong type.
type testPolicy struct {
v map[pkey.Key]any
policyclient.NoPolicyClient
}
func (sp *testPolicy) Set(key pkey.Key, value any) {
if sp.v == nil {
sp.v = make(map[pkey.Key]any)
}
sp.v[key] = value
}
func (sp testPolicy) GetStringArray(key pkey.Key, defaultVal []string) ([]string, error) {
if val, ok := sp.v[key]; ok {
if arr, ok := val.([]string); ok {
return arr, nil
}
panic(fmt.Sprintf("key %s is not a []string", key))
}
return defaultVal, nil
}
func (sp testPolicy) GetString(key pkey.Key, defaultVal string) (string, error) {
if val, ok := sp.v[key]; ok {
if str, ok := val.(string); ok {
return str, nil
}
panic(fmt.Sprintf("key %s is not a string", key))
}
return defaultVal, nil
}
func (sp testPolicy) GetBoolean(key pkey.Key, defaultVal bool) (bool, error) {
if val, ok := sp.v[key]; ok {
if b, ok := val.(bool); ok {
return b, nil
}
panic(fmt.Sprintf("key %s is not a bool", key))
}
return defaultVal, nil
}
func (sp testPolicy) HasAnyOf(keys ...pkey.Key) (bool, error) {
for _, key := range keys {
if _, ok := sp.v[key]; ok {
return true, nil
}
}
return false, nil
}
func TestFillAllowedSuggestions(t *testing.T) {
tests := []struct {
name string
@@ -5628,7 +5572,7 @@ func TestFillAllowedSuggestions(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
var pol testPolicy
var pol policytest.Config
pol.Set(pkey.AllowedSuggestedExitNodes, tt.allowPolicy)
got := fillAllowedSuggestions(pol)