From 2a88428f2461ec6c39555ddc6f9508c228187451 Mon Sep 17 00:00:00 2001
From: Brad Fitzpatrick <bradfitz@tailscale.com>
Date: Fri, 9 Aug 2024 07:53:08 -0700
Subject: [PATCH] tstest/integration/nat: skip some tests by default without
 flags

Updates #13038

Change-Id: I7ebf8bd8590e65ce4d30dd9f03c713b77868fa36
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
---
 tstest/integration/nat/nat_test.go | 101 +++++++++++++----------------
 1 file changed, 44 insertions(+), 57 deletions(-)

diff --git a/tstest/integration/nat/nat_test.go b/tstest/integration/nat/nat_test.go
index 453a74cf1..052bab74b 100644
--- a/tstest/integration/nat/nat_test.go
+++ b/tstest/integration/nat/nat_test.go
@@ -53,22 +53,22 @@ func newNatTest(tb testing.TB) *natTest {
 	}
 	modRoot := filepath.Join(root, "../../..")
 
-	linuxKernel, err := findKernelPath(filepath.Join(modRoot, "gokrazy/tsapp/builddir/github.com/tailscale/gokrazy-kernel/go.mod"))
-	if err != nil {
-		tb.Fatalf("findKernelPath: %v", err)
-	}
-	tb.Logf("found kernel: %v", linuxKernel)
-
 	nt := &natTest{
 		tb:      tb,
 		tempDir: tb.TempDir(),
 		base:    filepath.Join(modRoot, "gokrazy/tsapp.qcow2"),
-		kernel:  linuxKernel,
 	}
 
 	if _, err := os.Stat(nt.base); err != nil {
 		tb.Skipf("skipping test; base image %q not found", nt.base)
 	}
+
+	nt.kernel, err = findKernelPath(filepath.Join(modRoot, "gokrazy/tsapp/builddir/github.com/tailscale/gokrazy-kernel/go.mod"))
+	if err != nil {
+		tb.Skipf("skipping test; kernel not found: %v", err)
+	}
+	tb.Logf("found kernel: %v", nt.kernel)
+
 	return nt
 }
 
@@ -388,68 +388,55 @@ func up(ctx context.Context, c *vnet.NodeAgentClient) error {
 	return nil
 }
 
+type nodeType struct {
+	name string
+	fn   addNodeFunc
+}
+
+var types = []nodeType{
+	{"easy", easy},
+	{"easyAF", easyAF},
+	{"hard", hard},
+	{"easyPMP", easyPMP},
+	{"hardPMP", hardPMP},
+	{"one2one", one2one},
+	{"sameLAN", sameLAN},
+}
+
 func TestEasyEasy(t *testing.T) {
 	nt := newNatTest(t)
 	nt.runTest(easy, easy)
 }
 
-func TestEasyHard(t *testing.T) {
+var pair = flag.String("pair", "", "comma-separated pair of types to test (easy, easyAF, hard, easyPMP, hardPMP, one2one, sameLAN)")
+
+func TestPair(t *testing.T) {
+	t1, t2, ok := strings.Cut(*pair, ",")
+	if !ok {
+		t.Skipf("skipping test without --pair=type1,type2 set")
+	}
+	find := func(name string) addNodeFunc {
+		for _, nt := range types {
+			if nt.name == name {
+				return nt.fn
+			}
+		}
+		t.Fatalf("unknown type %q", name)
+		return nil
+	}
+
 	nt := newNatTest(t)
-	nt.runTest(easy, hard)
+	nt.runTest(find(t1), find(t2))
 }
 
-func TestEasyAFHard(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(easyAF, hard)
-}
-
-func TestEasyHardPMP(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(easy, hardPMP)
-}
-
-func TestEasyPMPHard(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(easyPMP, hard)
-}
-
-func TestHardHardPMP(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(hard, hardPMP)
-}
-
-func TestHardHard(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(hard, hard)
-}
-
-func TestEasyOne2One(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(easy, one2one)
-}
-
-func TestHardOne2One(t *testing.T) {
-	nt := newNatTest(t)
-	nt.runTest(hard, one2one)
-}
+var runGrid = flag.Bool("run-grid", false, "run grid test")
 
 func TestGrid(t *testing.T) {
+	if !*runGrid {
+		t.Skip("skipping grid test; set --run-grid to run")
+	}
 	t.Parallel()
 
-	type nodeType struct {
-		name string
-		fn   addNodeFunc
-	}
-	types := []nodeType{
-		{"easy", easy},
-		{"easyAF", easyAF},
-		{"hard", hard},
-		{"easyPMP", easyPMP},
-		{"hardPMP", hardPMP},
-		{"one2one", one2one},
-		{"sameLAN", sameLAN},
-	}
-
 	sem := syncs.NewSemaphore(2)
 	var (
 		mu  sync.Mutex