TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-22 08:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipn: always guard LocalBackend.engineStatus with mu

Browse Source 
Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
This commit is contained in:
David Crawshaw 2020-02-28 14:58:46 -05:00
parent e7cdc11654
commit 3425d8d84f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ipn/local.go
View File

@ -47,7 +47,7 @@ type LocalBackend struct {
state State state State
hiCache *tailcfg.Hostinfo hiCache *tailcfg.Hostinfo
netMapCache *controlclient.NetworkMap netMapCache *controlclient.NetworkMap
engineStatus EngineStatus // TODO: many uses without holding mu engineStatus EngineStatus
endPoints []string // TODO: many uses without holding mu endPoints []string // TODO: many uses without holding mu
blocked bool blocked bool
authURL string authURL string
@ -265,9 +265,8 @@ func (b *LocalBackend) Start(opts Options) error {
b.mu.Lock() // why does this hold b.mu? parseWgStatus only reads b.logf b.mu.Lock() // why does this hold b.mu? parseWgStatus only reads b.logf
es := b.parseWgStatus(s) es := b.parseWgStatus(s)
c := b.c c := b.c
b.mu.Unlock()
b.engineStatus = es b.engineStatus = es
b.mu.Unlock()
if c != nil { if c != nil {
c.UpdateEndpoints(0, s.LocalAddrs) c.UpdateEndpoints(0, s.LocalAddrs)