github/windows: improve cache performance (#4171)

- Remove the expanded module files, as Go can likely expand the zips
  faster than tar can expand the extra copies.
- Add the go-build cache.
- Remove the extra restore key to avoid extra cache lookups on miss.

Signed-off-by: James Tucker <james@tailscale.com>
Co-authored-by: James Tucker <james@tailscale.com>

.github/workflows/windows.yml

@@ -27,10 +27,18 @@ jobs:
     - name: Restore Cache
       uses: actions/cache@v2
       with:
-        path: ~/go/pkg/mod
+        # Note: unlike some other setups, this is only grabbing the mod download
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+        # cache, rather than the whole mod directory, as the download cache
-        restore-keys: |
+        # contains zips that can be unpacked in parallel faster than they can be
-          ${{ runner.os }}-go-
+        # fetched and extracted by tar
+        path: |
+          ~/go/pkg/mod/cache
+          ~\AppData\Local\go-build
+
+        # The -2- here should be incremented when the scheme of data to be
+        # cached changes (e.g. path above changes).
+        # TODO(raggi): add a go version here.
+        key: ${{ runner.os }}-go-2-${{ hashFiles('**/go.sum') }}
 
     - name: Test
       # Don't use -bench=. -benchtime=1x.