From 37c0b9be638fe813314840b1a5704461dbf9ee3f Mon Sep 17 00:00:00 2001 From: Chris Palmer Date: Wed, 16 Aug 2023 14:01:10 -0700 Subject: [PATCH] clientupdate: return NOTREACHED for macsys (#8898) * clientupdate: return NOTREACHED for macsys The work is done in Swift; this is now a documentation placeholder. Updates #6995 Signed-off-by: Chris Palmer --- clientupdate/clientupdate.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/clientupdate/clientupdate.go b/clientupdate/clientupdate.go index 6cbff0b85..9e36cea21 100644 --- a/clientupdate/clientupdate.go +++ b/clientupdate/clientupdate.go @@ -588,12 +588,7 @@ func parseAlpinePackageVersion(out []byte) (string, error) { } func (up *updater) updateMacSys() error { - // use sparkle? do we have permissions from this context? does sudo help? - // We can at least fail with a command they can run to update from the shell. - // Like "tailscale update --macsys | sudo sh" or something. - // - // TODO(bradfitz,mihai): implement. But for now: - return errors.ErrUnsupported + return errors.New("NOTREACHED: On MacSys builds, `tailscale update` is handled in Swift to launch the GUI updater") } func (up *updater) updateMacAppStore() error {