TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-21 22:21:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

logtail: always record timestamps in UTC (#5732)

Browse Source 
Upstream optimizations to the Go time package will make
unmarshaling of time.Time 3-6x faster. See:
* https://go.dev/cl/425116
* https://go.dev/cl/425197
* https://go.dev/cl/429862

The last optimization avoids a []byte -> string allocation
if the timestamp string less than than 32B.
Unfortunately, the presence of a timezone breaks that optimization.
Drop recording of timezone as this is non-essential information.

Most of the performance gains is upon unmarshal,
but there is also a slight performance benefit to
not marshaling the timezone as well.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
This commit is contained in:
Joe Tsai 2022-10-05 12:27:52 -07:00 committed by GitHub
parent c321363d2c
commit 3af0d4d0f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
logtail/logtail.go
View File

@ -524,7 +524,7 @@ func (l *Logger) encodeText(buf []byte, skipClientTime bool, procID uint32, proc
b = append(b, `"logtail": {`...) b = append(b, `"logtail": {`...)
if !skipClientTime { if !skipClientTime {
b = append(b, `"client_time": "`...) b = append(b, `"client_time": "`...)
b = now.AppendFormat(b, time.RFC3339Nano) b = now.UTC().AppendFormat(b, time.RFC3339Nano)
b = append(b, `",`...) b = append(b, `",`...)
} }
if procID != 0 { if procID != 0 {
@ -617,7 +617,7 @@ func (l *Logger) encodeLocked(buf []byte, level int) []byte {
if !l.skipClientTime || l.procID != 0 || l.procSequence != 0 { if !l.skipClientTime || l.procID != 0 || l.procSequence != 0 {
logtail := map[string]any{} logtail := map[string]any{}
if !l.skipClientTime { if !l.skipClientTime {
logtail["client_time"] = now.Format(time.RFC3339Nano) logtail["client_time"] = now.UTC().Format(time.RFC3339Nano)
} }
if l.procID != 0 { if l.procID != 0 {
logtail["proc_id"] = l.procID logtail["proc_id"] = l.procID