TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-10-09 08:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

tsweb: avoid dashes in Prometheus metric names

Browse Source 
Ideally we should strip other invalid characters too, but that would
call for a regexp replacement which increases the number of allocations
and makes `TestVarzHandlerSorting` fail.

Signed-off-by: Anton Tolchanov <anton@tailscale.com>
This commit is contained in:
Anton Tolchanov
2022-11-17 09:34:32 -08:00
committed by Anton Tolchanov
parent dd50dcd067
commit 3c27632ffe
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tsweb/tsweb.go
View File

@@ -474,7 +474,7 @@ func writePromExpVar(w io.Writer, prefix string, kv expvar.KeyValue) {
label, key = a, b
}
}
name := prefix + key
name := strings.ReplaceAll(prefix+key, "-", "_")
switch v := kv.Value.(type) {
case PrometheusVar: