TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-06 12:52:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipn/localapi: fix validHost parsing logic

Browse Source 
Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
This commit is contained in:
David Crawshaw
2023-01-30 09:13:45 -08:00
committed by David Crawshaw
parent 0039993359
commit 4136f27f35
2 changed files with 42 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ipn/localapi/localapi.go
View File

@@ -179,6 +179,10 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
}
}
// validLocalHost allows either localhost or loopback IP hosts on platforms
// that use token security.
var validLocalHost = runtime.GOOS == "darwin" || runtime.GOOS == "ios" || runtime.GOOS == "android"
// validHost reports whether h is a valid Host header value for a LocalAPI request.
func validHost(h string) bool {
// The client code sends a hostname of "local-tailscaled.sock".
@@ -186,7 +190,9 @@ func validHost(h string) bool {
case "", apitype.LocalAPIHost:
return true
}
// Allow either localhost or loopback IP hosts.
if !validLocalHost {
return false
}
host, _, err := net.SplitHostPort(h)
if err != nil {
return false
@@ -194,7 +200,7 @@ func validHost(h string) bool {
if host == "localhost" {
return true
}
addr, err := netip.ParseAddr(h)
addr, err := netip.ParseAddr(host)
if err != nil {
return false
}