TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-18 12:32:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/magicsock/tests: call tstest.ResourceCheck for each test.

Browse Source 
This didn't catch anything yet, but it's good practice for detecting
goroutine leaks that we might not find otherwise.

Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>
This commit is contained in:
Avery Pennarun 2020-05-13 23:03:46 -04:00
parent 08acb502e5
commit 42a0e0c601
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
wgengine/magicsock/magicsock_test.go
View File

@ -35,6 +35,8 @@ import (
func TestListen(t *testing.T) { func TestListen(t *testing.T) {
tstest.PanicOnLog() tstest.PanicOnLog()
rc := tstest.NewResourceCheck()
defer rc.Assert(t)
epCh := make(chan string, 16) epCh := make(chan string, 16)
epFunc := func(endpoints []string) { epFunc := func(endpoints []string) {
@ -97,6 +99,8 @@ func pickPort(t *testing.T) uint16 {
func TestDerpIPConstant(t *testing.T) { func TestDerpIPConstant(t *testing.T) {
tstest.PanicOnLog() tstest.PanicOnLog()
rc := tstest.NewResourceCheck()
defer rc.Assert(t)
if DerpMagicIP != derpMagicIP.String() { if DerpMagicIP != derpMagicIP.String() {
t.Errorf("str %q != IP %v", DerpMagicIP, derpMagicIP) t.Errorf("str %q != IP %v", DerpMagicIP, derpMagicIP)
@ -108,6 +112,8 @@ func TestDerpIPConstant(t *testing.T) {
func TestPickDERPFallback(t *testing.T) { func TestPickDERPFallback(t *testing.T) {
tstest.PanicOnLog() tstest.PanicOnLog()
rc := tstest.NewResourceCheck()
defer rc.Assert(t)
c := &Conn{ c := &Conn{
derps: derpmap.Prod(), derps: derpmap.Prod(),
@ -256,6 +262,8 @@ func devLogger(t *testing.T, prefix string, logfx logger.Logf) *device.Logger {
// -count=10000 to be sure. // -count=10000 to be sure.
func TestDeviceStartStop(t *testing.T) { func TestDeviceStartStop(t *testing.T) {
tstest.PanicOnLog() tstest.PanicOnLog()
rc := tstest.NewResourceCheck()
defer rc.Assert(t)
conn, err := Listen(Options{ conn, err := Listen(Options{
EndpointsFunc: func(eps []string) {}, EndpointsFunc: func(eps []string) {},
@ -279,6 +287,8 @@ func TestDeviceStartStop(t *testing.T) {
func TestTwoDevicePing(t *testing.T) { func TestTwoDevicePing(t *testing.T) {
tstest.PanicOnLog() tstest.PanicOnLog()
rc := tstest.NewResourceCheck()
defer rc.Assert(t)
// This gets reassigned inside every test, so that the connections // This gets reassigned inside every test, so that the connections
// all log using the "current" t.Logf function. Sigh. // all log using the "current" t.Logf function. Sigh.
@ -444,8 +454,9 @@ func TestTwoDevicePing(t *testing.T) {
}) })
current_t = t current_t = t
// TODO: Remove this once the following tests are reliable.
if os.Getenv("RUN_CURSED_TESTS") == "" { if os.Getenv("RUN_CURSED_TESTS") == "" {
t.Skip("test is very broken, don't run in CI until it's reliable.") t.Skip("skipping following tests because RUN_CURSED_TESTS is not set.")
} }
pingSeq := func(t *testing.T, count int, totalTime time.Duration, strict bool) { pingSeq := func(t *testing.T, count int, totalTime time.Duration, strict bool) {
@ -592,6 +603,8 @@ func TestTwoDevicePing(t *testing.T) {
// TestAddrSet tests AddrSet appendDests and UpdateDst. // TestAddrSet tests AddrSet appendDests and UpdateDst.
func TestAddrSet(t *testing.T) { func TestAddrSet(t *testing.T) {
tstest.PanicOnLog() tstest.PanicOnLog()
rc := tstest.NewResourceCheck()
defer rc.Assert(t)
// This gets reassigned inside every test, so that the connections // This gets reassigned inside every test, so that the connections
// all log using the "current" t.Logf function. Sigh. // all log using the "current" t.Logf function. Sigh.