TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-11-29 04:55:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/interfaces: trim getPACWindows whitespace before parsing URL

Browse Source 
Fixes #2357

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2021-07-08 11:25:32 -07:00
parent 1e83b97498
commit 440566c5d2
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/interfaces/interfaces_windows.go
View File

@ -9,6 +9,7 @@
"log" "log"
"net" "net"
"net/url" "net/url"
"strings"
"syscall" "syscall"
"unsafe" "unsafe"
@ -198,6 +199,10 @@ func getPACWindows() string {
} }
defer globalFree.Call(uintptr(unsafe.Pointer(res))) defer globalFree.Call(uintptr(unsafe.Pointer(res)))
s := windows.UTF16PtrToString(res) s := windows.UTF16PtrToString(res)
s = strings.TrimSpace(s)
if s == "" {
return "" // Issue 2357: invalid URL "\n" from winhttp; ignoring
}
if _, err := url.Parse(s); err != nil { if _, err := url.Parse(s); err != nil {
log.Printf("getPACWindows: invalid URL %q from winhttp; ignoring", s) log.Printf("getPACWindows: invalid URL %q from winhttp; ignoring", s)
return "" return ""