TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-27 02:37:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/dnscache: use tls.Conn.HandshakeContext.

Browse Source 
Go 1.17 added a HandshakeContext func to take care of timeouts during
TLS handshaking, so switch from our homegrown goroutine implementation
to the standard way.

Signed-off-by: David Anderson <danderson@tailscale.com>
This commit is contained in:
David Anderson 2022-01-13 13:01:29 -08:00 committed by Dave Anderson
parent a9da6b73a8
commit 463b3e8f62
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
net/dnscache/dnscache.go
View File

@ -444,22 +444,9 @@ func TLSDialer(fwd DialContextFunc, dnsCache *Resolver, tlsConfigBase *tls.Confi
} }
tlsConn := tls.Client(tcpConn, cfg) tlsConn := tls.Client(tcpConn, cfg)
errc := make(chan error, 2)
handshakeCtx, handshakeTimeoutCancel := context.WithTimeout(ctx, 5*time.Second) handshakeCtx, handshakeTimeoutCancel := context.WithTimeout(ctx, 5*time.Second)
defer handshakeTimeoutCancel() defer handshakeTimeoutCancel()
done := make(chan bool) if err := tlsConn.HandshakeContext(handshakeCtx); err != nil {
defer close(done)
go func() {
select {
case <-done:
case <-handshakeCtx.Done():
errc <- errTLSHandshakeTimeout
}
}()
go func() {
errc <- tlsConn.Handshake()
}()
if err := <-errc; err != nil {
tcpConn.Close() tcpConn.Close()
// TODO: if err != errTLSHandshakeTimeout, // TODO: if err != errTLSHandshakeTimeout,
// assume it might be some captive portal or // assume it might be some captive portal or