TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-08-14 15:07:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

portlist: update some internals to use append-style APIs

Browse Source 
In prep for reducing garbage, being able to reuse memory.  So far this
doesn't actually reuse much. This is just changing signatures around.

But some improvement in any case:

    bradfitz@tsdev:~/src/tailscale.com$ ~/go/bin/benchstat before after
    name       old time/op    new time/op    delta
    GetList-8    11.8ms ± 9%     9.9ms ± 3%  -15.98%  (p=0.000 n=10+10)

    name       old alloc/op   new alloc/op   delta
    GetList-8    99.5kB ± 2%    91.9kB ± 0%   -7.62%  (p=0.000 n=9+9)

    name       old allocs/op  new allocs/op  delta
    GetList-8     3.05k ± 1%     2.93k ± 0%   -3.83%  (p=0.000 n=8+9)

More later, once parsers can reuse strings from previous parses.

Updates #5958

Change-Id: I76cd5048246dd24d11c4e263d8bb8041747fb2b0
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2022-10-21 21:30:40 -07:00
committed by Brad Fitzpatrick
parent 67597bfc9e
commit 46ce80758d
13 changed files with 53 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
portlist/portlist_windows.go
View File

@@ -15,11 +15,11 @@ import (
// Forking on Windows is insanely expensive, so don't do it too often.
const pollInterval = 5 * time.Second
func listPorts() (List, error) {
func appendListeningPorts(base []Port) ([]Port, error) {
// TODO(bradfitz): stop shelling out to netstat and use the
// net/netstat package instead. When doing so, be sure to filter
// out all of 127.0.0.0/8 and not just 127.0.0.1.
return listPortsNetstat("-na")
return appendListeningPortsNetstat(base, "-na")
}
func addProcesses(pl []Port) ([]Port, error) {
@@ -31,9 +31,9 @@ func addProcesses(pl []Port) ([]Port, error) {
}
defer tok.Close()
if !tok.IsElevated() {
return listPortsNetstat("-na")
return appendListeningPortsNetstat(nil, "-na")
}
return listPortsNetstat("-nab")
return appendListeningPortsNetstat(nil, "-nab")
}
func init() {