TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-06-09 09:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipn/ipnlocal: improve dohQuery error to suggest ?dns= and ?q= (#16056)

Browse Source 
Previously, a missing or invalid `dns` parameter on GET `/dns-query`
returned only “missing ‘dns’ parameter”. Now the error message guides
users to use `?dns=` or `?q=`.

Updates: #16055

Signed-off-by: Zach Buchheit <zachb@tailscale.com>
This commit is contained in:
Zach Buchheit 2025-05-23 14:17:28 -07:00 committed by GitHub
parent 00a7dd180a
commit 4a11514db5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ipn/ipnlocal/peerapi.go
View File

@ -859,7 +859,7 @@ func dohQuery(r *http.Request) (dnsQuery []byte, publicErr string) {
case "GET": case "GET":
q64 := r.FormValue("dns") q64 := r.FormValue("dns")
if q64 == "" { if q64 == "" {
return nil, "missing 'dns' parameter" return nil, "missing ‘dns’ parameter; try '?dns=' (DoH standard) or use '?q=<name>' for JSON debug mode"
} }
if base64.RawURLEncoding.DecodedLen(len(q64)) > maxQueryLen { if base64.RawURLEncoding.DecodedLen(len(q64)) > maxQueryLen {
return nil, "query too large" return nil, "query too large"