TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-10-09 08:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

client/web: fix redirect logic when accessing login client over TS IP

Browse Source 
Was previously failing to redirect to the manage client when accessing
the login client with the Tailscale IP.

Updates #10261
Fixes tailscale/corp#16348

Co-authored-by: Will Norris <will@tailscale.com>
Signed-off-by: Sonia Appasamy <sonia@tailscale.com>
This commit is contained in:
Sonia Appasamy
2023-12-13 11:44:06 -05:00
committed by Sonia Appasamy
parent 869b34ddeb
commit 4fb679d9cd
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/web/src/components/login-toggle.tsx
View File

@@ -125,7 +125,7 @@ function LoginPopoverContent({
useEffect(() => checkTSConnection(), [])
const handleSignInClick = useCallback(() => {
if (auth.viewerIdentity) {
if (auth.viewerIdentity && auth.serverMode === "manage") {
if (window.self !== window.top) {
// if we're inside an iframe, start session in new window
let url = new URL(window.location.href)
@@ -145,7 +145,7 @@ function LoginPopoverContent({
window.location.href = manageURL
}
}
}, [node.IPv4, auth.viewerIdentity, newSession])
}, [auth.viewerIdentity, auth.serverMode, newSession, node.IPv4])
return (
<div onMouseEnter={!canConnectOverTS ? checkTSConnection : undefined}>