From 5562fae9f017acbf530751baa3b8a0d252c27387 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Fri, 6 Mar 2020 14:42:38 -0500 Subject: [PATCH] ipn: use NewPrefs in e2e_test We weren't setting UsePacketFilter, so the synthetic ping packets used to establish a connection were never being sent. Signed-off-by: David Crawshaw --- ipn/e2e_test.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ipn/e2e_test.go b/ipn/e2e_test.go index 1474802d7..261cf9693 100644 --- a/ipn/e2e_test.go +++ b/ipn/e2e_test.go @@ -166,16 +166,12 @@ func newNode(t *testing.T, prefix string, https *httptest.Server) testNode { Provider: "google", LoginName: "test1@tailscale.com", } + prefs := NewPrefs() + prefs.ControlURL = https.URL + prefs.Persist = &c n.Start(Options{ FrontendLogID: prefix + "-f", - Prefs: &Prefs{ - ControlURL: https.URL, - RouteAll: true, - AllowSingleHosts: true, - CorpDNS: true, - WantRunning: true, - Persist: &c, - }, + Prefs: prefs, Notify: func(n Notify) { // Automatically visit auth URLs if n.BrowseToURL != nil {