TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-11-29 04:55:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

health/dns: reduce severity of DNS unavailable warning (#13152)

Browse Source 
`DNS unavailable` was marked as a high severity warning. On Android (and other platforms), these trigger a system notification. Here we reduce the severity level to medium. A medium severity warning will still display the warning icon on platforms with a tray icon because of the `ImpactsConnectivity=true` flag being set here, but it won't show a notification anymore. If people enter an area with bad cellular reception, they're bound to receive so many of these notifications and we need to reduce notification fatigue.

Signed-off-by: Andrea Gottardo <andrea@tailscale.com>
This commit is contained in:
Andrea Gottardo 2024-08-16 08:12:06 -07:00 committed by GitHub
parent ccf091e4a6
commit 5cbbb48c2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/dns/resolver/forwarder.go
View File

@ -177,7 +177,7 @@ func clampEDNSSize(packet []byte, maxSize uint16) {
var dnsForwarderFailing = health.Register(&health.Warnable{ var dnsForwarderFailing = health.Register(&health.Warnable{
Code: "dns-forward-failing", Code: "dns-forward-failing",
Title: "DNS unavailable", Title: "DNS unavailable",
Severity: health.SeverityHigh, Severity: health.SeverityMedium,
DependsOn: []*health.Warnable{health.NetworkStatusWarnable}, DependsOn: []*health.Warnable{health.NetworkStatusWarnable},
Text: health.StaticMessage("Tailscale can't reach the configured DNS servers. Internet connectivity may be affected."), Text: health.StaticMessage("Tailscale can't reach the configured DNS servers. Internet connectivity may be affected."),
ImpactsConnectivity: true, ImpactsConnectivity: true,