From 5d6198adeea9cae5e2dd20d755093769e6a5bfdb Mon Sep 17 00:00:00 2001 From: Denton Gentry Date: Sun, 10 Oct 2021 08:46:28 -0700 Subject: [PATCH] netcheck: don't log ErrGatewayRange "skipping portmap; gateway range likely lacks support" is really spammy on cloud systems, and not very useful in debugging. Fixes https://github.com/tailscale/tailscale/issues/3034 Signed-off-by: Denton Gentry --- net/netcheck/netcheck.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/netcheck/netcheck.go b/net/netcheck/netcheck.go index 2516e2e6f..f470a73af 100644 --- a/net/netcheck/netcheck.go +++ b/net/netcheck/netcheck.go @@ -704,7 +704,12 @@ func (rs *reportState) probePortMapServices() { res, err := rs.c.PortMapper.Probe(context.Background()) if err != nil { - rs.c.logf("probePortMapServices: %v", err) + if !errors.Is(err, portmapper.ErrGatewayRange) { + // "skipping portmap; gateway range likely lacks support" + // is not very useful, and too spammy on cloud systems. + // If there are other errors, we want to log those. + rs.c.logf("probePortMapServices: %v", err) + } return }