TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-27 02:37:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/linuxfw: add missing error checks in tests

Browse Source 
This would surface as panics when run on Fly. Still fail, but at least don't panic.

Updates #10003

Signed-off-by: Maisem Ali <maisem@tailscale.com>
This commit is contained in:
Maisem Ali 2023-10-27 21:56:17 -07:00 committed by Maisem Ali
parent 387a98fe28
commit 62d580f0e8
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
util/linuxfw/nftables_runner_test.go
View File

@ -533,7 +533,9 @@ func TestAddAndDelNetfilterChains(t *testing.T) {
checkChains(t, conn, nftables.TableFamilyIPv6, 0) checkChains(t, conn, nftables.TableFamilyIPv6, 0)
runner := newFakeNftablesRunner(t, conn) runner := newFakeNftablesRunner(t, conn)
runner.AddChains() if err := runner.AddChains(); err != nil {
t.Fatalf("runner.AddChains() failed: %v", err)
}
tables, err := conn.ListTables() tables, err := conn.ListTables()
if err != nil { if err != nil {
@ -664,9 +666,13 @@ func TestNFTAddAndDelNetfilterBase(t *testing.T) {
conn := newSysConn(t) conn := newSysConn(t)
runner := newFakeNftablesRunner(t, conn) runner := newFakeNftablesRunner(t, conn)
runner.AddChains() if err := runner.AddChains(); err != nil {
t.Fatalf("AddChains() failed: %v", err)
}
defer runner.DelChains() defer runner.DelChains()
runner.AddBase("testTunn") if err := runner.AddBase("testTunn"); err != nil {
t.Fatalf("AddBase() failed: %v", err)
}
// check number of rules in each IPv4 TS chain // check number of rules in each IPv4 TS chain
inputV4, forwardV4, postroutingV4, err := getTsChains(conn, nftables.TableFamilyIPv4) inputV4, forwardV4, postroutingV4, err := getTsChains(conn, nftables.TableFamilyIPv4)
@ -754,7 +760,9 @@ func TestNFTAddAndDelLoopbackRule(t *testing.T) {
conn := newSysConn(t) conn := newSysConn(t)
runner := newFakeNftablesRunner(t, conn) runner := newFakeNftablesRunner(t, conn)
runner.AddChains() if err := runner.AddChains(); err != nil {
t.Fatalf("AddChains() failed: %v", err)
}
defer runner.DelChains() defer runner.DelChains()
inputV4, _, _, err := getTsChains(conn, nftables.TableFamilyIPv4) inputV4, _, _, err := getTsChains(conn, nftables.TableFamilyIPv4)
@ -810,9 +818,13 @@ func TestNFTAddAndDelLoopbackRule(t *testing.T) {
func TestNFTAddAndDelHookRule(t *testing.T) { func TestNFTAddAndDelHookRule(t *testing.T) {
conn := newSysConn(t) conn := newSysConn(t)
runner := newFakeNftablesRunner(t, conn) runner := newFakeNftablesRunner(t, conn)
runner.AddChains() if err := runner.AddChains(); err != nil {
t.Fatalf("AddChains() failed: %v", err)
}
defer runner.DelChains() defer runner.DelChains()
runner.AddHooks() if err := runner.AddHooks(); err != nil {
t.Fatalf("AddHooks() failed: %v", err)
}
forwardChain, err := getChainFromTable(conn, runner.nft4.Filter, "FORWARD") forwardChain, err := getChainFromTable(conn, runner.nft4.Filter, "FORWARD")
if err != nil { if err != nil {