From 66505358c0b40802ae706266fcd546c1aa08e6fa Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Sun, 8 Mar 2020 08:37:20 -0400 Subject: [PATCH] ipn: move e2e test skipping into subtests Signed-off-by: David Crawshaw --- ipn/e2e_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipn/e2e_test.go b/ipn/e2e_test.go index 261cf9693..c2f28fb67 100644 --- a/ipn/e2e_test.go +++ b/ipn/e2e_test.go @@ -106,11 +106,10 @@ func TestIPN(t *testing.T) { } } - t.Skip("skipping ping tests, they are flaky") // TODO(crawshaw): this exposes a real bug! - n1addr := n1.Backend.NetMap().Addresses[0].IP n2addr := n2.Backend.NetMap().Addresses[0].IP t.Run("ping n2", func(t *testing.T) { + t.Skip("TODO(crawshaw): skipping ping test, it is flaky") msg := tuntest.Ping(n2addr.IP(), n1addr.IP()) n1.ChannelTUN.Outbound <- msg select { @@ -123,6 +122,7 @@ func TestIPN(t *testing.T) { } }) t.Run("ping n1", func(t *testing.T) { + t.Skip("TODO(crawshaw): skipping ping test, it is flaky") msg := tuntest.Ping(n1addr.IP(), n2addr.IP()) n2.ChannelTUN.Outbound <- msg select {