{,cmd/}k8s-operator: minor nits self-review

Change-Id: Ic6fb93cefa9f7cd7e30c5e4f45c03f58d7a102f8
Signed-off-by: Tom Proctor <tomhjp@users.noreply.github.com>

cmd/k8s-operator/proxygroup.go

@@ -963,10 +963,6 @@ func pgTailscaledConfig(pg *tsapi.ProxyGroup, pc *tsapi.ProxyClass, idx int32, a
 		conf.ServerURL = &loginServer
 	}
 
-	if pg.Spec.HostnamePrefix != "" {
-		conf.Hostname = ptr.To(fmt.Sprintf("%s-%d", pg.Spec.HostnamePrefix, idx))
-	}
-
 	if shouldAcceptRoutes(pc) {
 		conf.AcceptRoutes = "true"
 	}

cmd/k8s-operator/proxygroup_specs.go

@@ -427,10 +427,9 @@ func pgRole(pg *tsapi.ProxyGroup, namespace string) *rbacv1.Role {
 				},
 				ResourceNames: func() (secrets []string) {
 					for i := range pgReplicas(pg) {
-						podName := pgPodName(pg.Name, i)
 						secrets = append(secrets,
 							pgConfigSecretName(pg.Name, i), // Config with auth key.
-							podName,                        // State.
+							pgPodName(pg.Name, i),          // State.
 						)
 					}
 					return secrets

k8s-operator/apis/v1alpha1/types_connector.go

@@ -226,6 +226,4 @@ const (
 
 	IngressSvcValid      ConditionType = `TailscaleIngressSvcValid`
 	IngressSvcConfigured ConditionType = `TailscaleIngressSvcConfigured`
-
-	APIServerProxyReady ConditionType = `APIServerProxyReady`
 )