TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-11-25 19:15:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/magicsock: avoid log spam from ReceiveFunc on shutdown

Browse Source 
The new logging in 2dd71e64ac is spammy at shutdown:

    Receive func ReceiveIPv6 exiting with error: *net.OpError, read udp [::]:38869: raw-read udp6 [::]:38869: use of closed network connection
    Receive func ReceiveIPv4 exiting with error: *net.OpError, read udp 0.0.0.0:36123: raw-read udp4 0.0.0.0:36123: use of closed network connection

Skip it if we're in the process of shutting down.

Updates #10976

Change-Id: I4f6d1c68465557eb9ffe335d43d740e499ba9786
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2024-10-02 18:10:20 -07:00 committed by Brad Fitzpatrick
parent 09ec2f39b5
commit 6f694da912
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wgengine/magicsock/magicsock.go
View File

@ -1299,7 +1299,7 @@ func (c *Conn) mkReceiveFunc(ruc *RebindingUDPConn, healthItem *health.ReceiveFu
healthItem.Enter() healthItem.Enter()
defer healthItem.Exit() defer healthItem.Exit()
defer func() { defer func() {
if retErr != nil { if retErr != nil && !c.closing.Load() {
c.logf("Receive func %s exiting with error: %T, %v", healthItem.Name(), retErr, retErr) c.logf("Receive func %s exiting with error: %T, %v", healthItem.Name(), retErr, retErr)
} }
}() }()