TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-05 04:11:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/deephash: rely on direct memory hashing for primitive kinds (#5457)

Browse Source 
Rather than separate functions to hash each kind,
just rely on the fact that these are direct memory hashable,
thus simplifying the code.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
This commit is contained in:
Joe Tsai
2022-08-26 20:50:56 -07:00
committed by GitHub
parent f1c9812188
commit 70f9fc8c7a
2 changed files with 31 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
util/deephash/deephash_test.go
View File

@@ -11,6 +11,7 @@ import (
"fmt"
"hash"
"math"
"math/bits"
"math/rand"
"net/netip"
"reflect"
@@ -342,6 +343,13 @@ func u8(n uint8) string { return string([]byte{n}) }
func u16(n uint16) string { return string(binary.LittleEndian.AppendUint16(nil, n)) }
func u32(n uint32) string { return string(binary.LittleEndian.AppendUint32(nil, n)) }
func u64(n uint64) string { return string(binary.LittleEndian.AppendUint64(nil, n)) }
func ux(n uint) string {
if bits.UintSize == 32 {
return u32(uint32(n))
} else {
return u64(uint64(n))
}
}
func TestGetTypeHasher(t *testing.T) {
switch runtime.GOARCH {
@@ -367,12 +375,12 @@ func TestGetTypeHasher(t *testing.T) {
{
name: "int",
val: int(1),
out: "\x01\x00\x00\x00\x00\x00\x00\x00",
out: ux(1),
},
{
name: "int_negative",
val: int(-1),
out: "\xff\xff\xff\xff\xff\xff\xff\xff",
out: ux(math.MaxUint),
},
{
name: "int8",