TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-27 18:57:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/tstun: remove tailscaled_outbound_dropped_packets_total reason=acl metric for now

Browse Source 
Updates #14280

Change-Id: Idff102b3d7650fc9dfbe0c340168806bdf542d76
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2024-12-04 08:41:37 -08:00 committed by Brad Fitzpatrick
parent 2aac916888
commit 74069774be
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/tstun/wrap.go
View File

@ -876,9 +876,10 @@ func (t *Wrapper) filterPacketOutboundToWireGuard(p *packet.Parsed, pc *peerConf
if filt.RunOut(p, t.filterFlags) != filter.Accept { if filt.RunOut(p, t.filterFlags) != filter.Accept {
metricPacketOutDropFilter.Add(1) metricPacketOutDropFilter.Add(1)
t.metrics.outboundDroppedPacketsTotal.Add(usermetric.DropLabels{ // TODO(#14280): increment a t.metrics.outboundDroppedPacketsTotal here
Reason: usermetric.ReasonACL, // once we figure out & document what labels to use for multicast,
}, 1) // link-local-unicast, IP fragments, etc. But they're not
// usermetric.ReasonACL.
return filter.Drop, gro return filter.Drop, gro
} }

2
net/tstun/wrap_test.go
View File

@ -453,7 +453,7 @@ func TestFilter(t *testing.T) {
assertMetricPackets(t, "inACL", 3, metricInboundDroppedPacketsACL) assertMetricPackets(t, "inACL", 3, metricInboundDroppedPacketsACL)
assertMetricPackets(t, "inError", 0, metricInboundDroppedPacketsErr) assertMetricPackets(t, "inError", 0, metricInboundDroppedPacketsErr)
assertMetricPackets(t, "outACL", 1, metricOutboundDroppedPacketsACL) assertMetricPackets(t, "outACL", 0, metricOutboundDroppedPacketsACL)
} }
func assertMetricPackets(t *testing.T, metricName string, want, got int64) { func assertMetricPackets(t *testing.T, metricName string, want, got int64) {