wgengine/magicsock: finish TODO to speed up peerMap.forEachEndpointWithDiscoKey

Now that peerMap tracks the set of nodes for a DiscoKey.

Updates #3088

Change-Id: I927bf2bdfd2b8126475f6b6acc44bc799fcb489f
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2021-10-18 14:38:03 -07:00 committed by Brad Fitzpatrick
parent c6ea282b3f
commit 7a243ae5b1

View File

@ -153,12 +153,17 @@ func (m *peerMap) forEachEndpoint(f func(ep *endpoint)) {
// forEachEndpointWithDiscoKey invokes f on every endpoint in m
// that has the provided DiscoKey.
func (m *peerMap) forEachEndpointWithDiscoKey(dk tailcfg.DiscoKey, f func(ep *endpoint)) {
// TODO(bradfitz): once byDiscoKey is a set of endpoints, then range
// over that instead.
for _, pi := range m.byNodeKey {
if pi.ep.discoKey == dk {
f(pi.ep)
for nk := range m.nodesOfDisco[dk] {
pi, ok := m.byNodeKey[nk]
if !ok {
// Unexpected. Data structures would have to
// be out of sync. But we don't have a logger
// here to log [unexpected], so just skip.
// Maybe log later once peerMap is merged back
// into Conn.
continue
}
f(pi.ep)
}
}