TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-18 20:51:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

logtail/filch: skip a broken test on Windows

Browse Source 
Add a TODO with some notes about why it's skipped for now.

Updates #50
This commit is contained in:
Brad Fitzpatrick 2020-10-14 21:32:26 -07:00
parent a6c34bdc28
commit 7a2a3955d3
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
logtail/filch/filch_test.go
View File

@ -8,6 +8,7 @@ import (
"fmt" "fmt"
"io/ioutil" "io/ioutil"
"os" "os"
"runtime"
"strings" "strings"
"testing" "testing"
"unicode" "unicode"
@ -128,6 +129,14 @@ func TestRecover(t *testing.T) {
} }
func TestFilchStderr(t *testing.T) { func TestFilchStderr(t *testing.T) {
if runtime.GOOS == "windows" {
// TODO(bradfitz): this is broken on Windows but not
// fully sure why. Investigate. But notably, the
// stderrFD variable (defined in filch.go) and set
// below is only ever read in filch_unix.go. So just
// skip this for test for now.
t.Skip("test broken on Windows")
}
pipeR, pipeW, err := os.Pipe() pipeR, pipeW, err := os.Pipe()
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)