TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-21 12:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/netstack: disable RACK on all platforms

Browse Source 
The gVisor RACK implementation appears to perfom badly, particularly in
scenarios with higher BDP. This may have gone poorly noticed as a result
of it being gated on SACK, which is not enabled by default in upstream
gVisor, but itself has a higher positive impact on performance. Both the
RACK and DACK implementations (which are now one) have overlapping
non-completion of tasks in their work streams on the public tracker.

Updates #9707

Signed-off-by: James Tucker <james@tailscale.com>
This commit is contained in:
James Tucker 2025-02-03 16:18:07 -08:00 committed by James Tucker
parent 431216017b
commit 83808029d8
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
wgengine/netstack/netstack.go
View File

@ -317,16 +317,14 @@ func Create(logf logger.Logf, tundev *tstun.Wrapper, e wgengine.Engine, mc *magi
if tcpipErr != nil { if tcpipErr != nil {
return nil, fmt.Errorf("could not enable TCP SACK: %v", tcpipErr) return nil, fmt.Errorf("could not enable TCP SACK: %v", tcpipErr)
} }
if runtime.GOOS == "windows" { // See https://github.com/tailscale/tailscale/issues/9707
// See https://github.com/tailscale/tailscale/issues/9707 // gVisor's RACK performs poorly. ACKs do not appear to be handled in a
// Windows w/RACK performs poorly. ACKs do not appear to be handled in a // timely manner, leading to spurious retransmissions and a reduced
// timely manner, leading to spurious retransmissions and a reduced // congestion window.
// congestion window. tcpRecoveryOpt := tcpip.TCPRecovery(0)
tcpRecoveryOpt := tcpip.TCPRecovery(0) tcpipErr = ipstack.SetTransportProtocolOption(tcp.ProtocolNumber, &tcpRecoveryOpt)
tcpipErr = ipstack.SetTransportProtocolOption(tcp.ProtocolNumber, &tcpRecoveryOpt) if tcpipErr != nil {
if tcpipErr != nil { return nil, fmt.Errorf("could not disable TCP RACK: %v", tcpipErr)
return nil, fmt.Errorf("could not disable TCP RACK: %v", tcpipErr)
}
} }
err := setTCPBufSizes(ipstack) err := setTCPBufSizes(ipstack)
if err != nil { if err != nil {