net/sockstats: quiet some log spam in release builds

Updates #13731

Change-Id: Ibee85426827ebb9e43a1c42a9c07c847daa50117
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2024-10-08 10:34:08 -07:00 committed by Brad Fitzpatrick
parent 861dc3631c
commit 841eaacb07

View File

@ -18,6 +18,7 @@
"tailscale.com/net/netmon" "tailscale.com/net/netmon"
"tailscale.com/types/logger" "tailscale.com/types/logger"
"tailscale.com/util/clientmetric" "tailscale.com/util/clientmetric"
"tailscale.com/version"
) )
const IsAvailable = true const IsAvailable = true
@ -156,7 +157,11 @@ func withSockStats(ctx context.Context, label Label, logf logger.Logf) context.C
} }
} }
willOverwrite := func(trace *net.SockTrace) { willOverwrite := func(trace *net.SockTrace) {
logf("sockstats: trace %q was overwritten by another", label) if version.IsUnstableBuild() {
// Only spam about this in dev builds.
// See https://github.com/tailscale/tailscale/issues/13731 for known problems.
logf("sockstats: trace %q was overwritten by another", label)
}
} }
return net.WithSockTrace(ctx, &net.SockTrace{ return net.WithSockTrace(ctx, &net.SockTrace{