TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-16 03:31:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

ssh/tailssh: enable recording of non-pty sessions

Browse Source 
Updates tailscale/corp#9967

Signed-off-by: Maisem Ali <maisem@tailscale.com>
This commit is contained in:
Maisem Ali 2023-03-23 12:32:44 -07:00 committed by Maisem Ali
parent 8765568373
commit 8a246487c2
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ssh/tailssh/tailssh.go
View File

@ -1130,10 +1130,7 @@ func (ss *sshSession) recorders() []netip.AddrPort {
} }
func (ss *sshSession) shouldRecord() bool { func (ss *sshSession) shouldRecord() bool {
// for now only record pty sessions return len(ss.recorders()) > 0
// TODO(bradfitz,maisem): support recording non-pty stuff too.
_, _, isPtyReq := ss.Pty()
return isPtyReq && len(ss.recorders()) > 0
} }
type sshConnInfo struct { type sshConnInfo struct {

3
ssh/tailssh/tailssh_test.go
View File

@ -540,7 +540,8 @@ func TestSSH(t *testing.T) {
node: &tailcfg.Node{}, node: &tailcfg.Node{},
uprof: tailcfg.UserProfile{}, uprof: tailcfg.UserProfile{},
} }
sc.finalAction = &tailcfg.SSHAction{Accept: true} sc.action0 = &tailcfg.SSHAction{Accept: true}
sc.finalAction = sc.action0
sc.Handler = func(s ssh.Session) { sc.Handler = func(s ssh.Session) {
sc.newSSHSession(s).run() sc.newSSHSession(s).run()